adafruit-mirror/Adafruit_CircuitPython_LED_Animation
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix initial offset calculation when reversed in chase.py

Browse source 
Found a bug in the chase animation when reverse is set to True which results in the animation being offset by the length of the size parameter.  You can observe this by setting up two animations of equal length on a single strip of pixels with the second one reversed.  The bars should appear to meet in the middle but don't.

Example:
pixels = neopixel.NeoPixel(board.A0, 22, auto_write=False, brightness = .5)
left_pixels = PixelSubset(pixels, 0, 11)
right_pixels = PixelSubset(pixels, 11, 22)
left_animation = Chase(
    left_pixels, speed=.5, color=CYAN, size=2, spacing=11
)

right_animation = Chase(
    right_pixels, speed=.5, color=CYAN, size=2, spacing=11, reverse=True
)

animations = AnimationSequence(
    AnimationGroup(
        left_animation,
        right_animation,
        sync=True
    ),
    auto_clear=True,
    auto_reset=True,
)

while True:
    animations.animate()
This commit is contained in:
hberg32 2025-07-31 16:41:58 -04:00 committed by GitHub
parent 5d13d0966a
commit 9cb567f013
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
adafruit_led_animation/animation/chase.py
View file

@ -51,10 +51,10 @@ class Chase(Animation):
self._overflow = len(pixel_object) % self._repeat_width self._overflow = len(pixel_object) % self._repeat_width
self._direction = 1 if not reverse else -1 self._direction = 1 if not reverse else -1
self._reverse = reverse self._reverse = reverse
self._offset = 0 self._offset = 0 if not reverse else len(pixel_object) - size
def _resetter(): def _resetter():
self._offset = 0 self._offset = 0 if not reverse else len(self.pixel_object) - size
self._reverse = reverse self._reverse = reverse
self._direction = 1 if not reverse else -1 self._direction = 1 if not reverse else -1