Use FIXME instead of BUGBUG

This commit is contained in:
Henry Gabryjelski 2020-08-09 23:50:13 -07:00
parent 55a9930808
commit 66b0a74073
5 changed files with 8 additions and 8 deletions

View file

@ -210,11 +210,11 @@ byte getconfdescr( byte addr, byte conf )
{
uint8_t buf[ BUFSIZE ];
uint8_t* buf_ptr = buf;
byte rcode; // BUGBUG -- code does not actually check return code (no error handling!)
byte rcode; // FIXME -- code does not actually check return code (no error handling!)
byte descr_length;
byte descr_type;
uint16_t total_length;
// BUGBUG -- no check of return code from usb.getConfDescr()
// FIXME -- no check of return code from usb.getConfDescr()
rcode = usb.getConfDescr( addr, 0, 4, conf, buf ); //get total length
LOBYTE( total_length ) = buf[ 2 ];
HIBYTE( total_length ) = buf[ 3 ];
@ -222,7 +222,7 @@ byte getconfdescr( byte addr, byte conf )
printProgStr(Conf_Trunc_str);
total_length = sizeof(buf);
}
// BUGBUG -- no check of return code from usb.getConfDescr()
// FIXME -- no check of return code from usb.getConfDescr()
rcode = usb.getConfDescr( addr, 0, total_length, conf, buf ); //get the whole descriptor
while( buf_ptr < buf + total_length ) { //parsing descriptors
descr_length = *( buf_ptr );

View file

@ -104,7 +104,7 @@ bool ConfigDescParser<CLASS_ID, SUBCLASS_ID, PROTOCOL_ID, MASK>::ParseDescriptor
#pragma GCC diagnostic push // Available since GCC 4.6.4
/*
* BUGBUG -- Enabled and review all `-Wimplicit-fallthrough` messages
* FIXME -- Enabled and review all `-Wimplicit-fallthrough` messages
* This code has multiple switch statements that "fall through" to the
* next case -- but it's not always clear if this is intentional or not.
* Review and commenting of code, and reducing cyclomatic complexity

View file

@ -1094,7 +1094,7 @@ uint8_t ReportDescParserBase::ParseItem(uint8_t **pp, uint32_t *pcntdn) {
#pragma GCC diagnostic push // Available since GCC 4.6.4
/*
* BUGBUG -- Enabled and review all `-Wimplicit-fallthrough` messages
* FIXME -- Enabled and review all `-Wimplicit-fallthrough` messages
* This code has multiple switch statements that "fall through" to the
* next case -- but it's not always clear if this is intentional or not.
* Review and commenting of code, and reducing cyclomatic complexity
@ -1453,7 +1453,7 @@ uint8_t ReportDescParser2::ParseItem(uint8_t **pp, uint32_t *pcntdn) {
#pragma GCC diagnostic push // Available since GCC 4.6.4
/*
* BUGBUG -- Enabled and review all `-Wimplicit-fallthrough` messages
* FIXME -- Enabled and review all `-Wimplicit-fallthrough` messages
* This code has multiple switch statements that "fall through" to the
* next case -- but it's not always clear if this is intentional or not.
* Review and commenting of code, and reducing cyclomatic complexity

View file

@ -35,7 +35,7 @@ bool PTPListParser::Parse(uint8_t **pp, uint32_t *pcntdn, PTP_ARRAY_EL_FUNC pf,
#pragma GCC diagnostic push // Available since GCC 4.6.4
/*
* BUGBUG -- Enabled and review all `-Wimplicit-fallthrough` messages
* FIXME -- Enabled and review all `-Wimplicit-fallthrough` messages
* This code has multiple switch statements that "fall through" to the
* next case -- but it's not always clear if this is intentional or not.
* Review and commenting of code, and reducing cyclomatic complexity

View file

@ -68,7 +68,7 @@ public:
bool Skip(uint8_t **pp, uint32_t *pcntdn, uint32_t bytes_to_skip) {
#pragma GCC diagnostic push // Available since GCC 4.6.4
/*
* BUGBUG -- Enabled and review all `-Wimplicit-fallthrough` messages
* FIXME -- Enabled and review all `-Wimplicit-fallthrough` messages
* This code has multiple switch statements that "fall through" to the
* next case -- but it's not always clear if this is intentional or not.
* Review and commenting of code, and reducing cyclomatic complexity