fix hangup when up/right or down/right pressed

MCUME_pico/pico5200/emuapi.cpp

@@ -49,13 +49,13 @@ static char selection[MAX_FILENAME_SIZE+1]="";
 static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
-static int keyMap;
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
 #endif
+static int keyMap;
 
 static bool joySwapped = false;
 static uint16_t bLastState;
@@ -67,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -137,8 +139,9 @@ void emu_Free(void * pt)
 
 
 
-
-
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -319,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -347,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -513,7 +515,9 @@ int emu_setKeymap(int index) {
 
 
 
-
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -685,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -753,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -780,19 +779,11 @@ int emu_FileSeek(int seek)
   return (seek);
 }
 
-#ifdef SDIO
-
-
 int emu_FileTell(void) 
 {
-#ifdef USE_SDFS
   return (f_tell(&file));
-#else
-  return (50);
-#endif
 }
 
-
 int emu_LoadFile(char * filename, char * buf, int size)
 {
   int filesize = 0;
@@ -803,82 +794,28 @@ int emu_LoadFile(char * filename, char * buf, int size)
   strcat(filepath, filename);
   emu_printf("LoadFile...");
   emu_printf(filepath);
-#ifdef USE_SDFS
   if( !(f_open(&file, filepath, FA_READ)) ) {
     filesize = f_size(&file);
     emu_printf(filesize);
     if (size >= filesize)
     {
-      int retval=0;
+      unsigned int retval=0;
       if( (f_read (&file, buf, filesize, &retval)) ) {
         emu_printf("File read failed");        
       }
     }
     f_close(&file);
   }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
  
   return(filesize);
 }
 
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 

MCUME_pico/pico64/emuapi.cpp

@@ -49,13 +49,13 @@ static char selection[MAX_FILENAME_SIZE+1]="";
 static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
-static int keyMap;
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
 #endif
+static int keyMap;
 
 static bool joySwapped = false;
 static uint16_t bLastState;
@@ -67,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -137,6 +139,9 @@ void emu_Free(void * pt)
 
 
 
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -317,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -345,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -511,6 +515,9 @@ int emu_setKeymap(int index) {
 
 
 
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -523,7 +530,6 @@ static int readNbFiles(char * rootdir) {
   FILINFO entry;
   FRESULT fr = f_findfirst(&dir, &entry, rootdir, "*");
   while ( (fr == FR_OK) && (entry.fname[0]) && (totalFiles<MAX_FILES) ) {  
-//    f_readdir(&dir, &entry);
     if (!entry.fname[0]) {
       // no more files
       break;
@@ -683,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -751,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -772,29 +773,17 @@ int emu_FileSize(char * filename)
   return(filesize);    
 }
 
-
-#ifdef SDIO
-
 int emu_FileSeek(int seek) 
 {
-#ifdef USE_SDFS
   f_lseek(&file, seek);
-#else
-  file.seek(seek);
-#endif
   return (seek);
 }
 
 int emu_FileTell(void) 
 {
-#ifdef USE_SDFS
   return (f_tell(&file));
-#else
-  return (50);
-#endif
 }
 
-
 int emu_LoadFile(char * filename, char * buf, int size)
 {
   int filesize = 0;
@@ -805,82 +794,28 @@ int emu_LoadFile(char * filename, char * buf, int size)
   strcat(filepath, filename);
   emu_printf("LoadFile...");
   emu_printf(filepath);
-#ifdef USE_SDFS
   if( !(f_open(&file, filepath, FA_READ)) ) {
     filesize = f_size(&file);
     emu_printf(filesize);
     if (size >= filesize)
     {
-      int retval=0;
+      unsigned int retval=0;
       if( (f_read (&file, buf, filesize, &retval)) ) {
         emu_printf("File read failed");        
       }
     }
     f_close(&file);
   }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
  
   return(filesize);
 }
 
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 

MCUME_pico/pico800/emuapi.cpp

@@ -49,13 +49,13 @@ static char selection[MAX_FILENAME_SIZE+1]="";
 static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
-static int keyMap;
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
 #endif
+static int keyMap;
 
 static bool joySwapped = false;
 static uint16_t bLastState;
@@ -67,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -137,6 +139,9 @@ void emu_Free(void * pt)
 
 
 
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -317,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -345,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -510,6 +514,10 @@ int emu_setKeymap(int index) {
 }
 
 
+
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -681,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -749,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -770,29 +773,17 @@ int emu_FileSize(char * filename)
   return(filesize);    
 }
 
-
-#ifdef SDIO
-
 int emu_FileSeek(int seek) 
 {
-#ifdef USE_SDFS
   f_lseek(&file, seek);
-#else
-  file.seek(seek);
-#endif
   return (seek);
 }
 
 int emu_FileTell(void) 
 {
-#ifdef USE_SDFS
   return (f_tell(&file));
-#else
-  return (50);
-#endif
 }
 
-
 int emu_LoadFile(char * filename, char * buf, int size)
 {
   int filesize = 0;
@@ -803,82 +794,28 @@ int emu_LoadFile(char * filename, char * buf, int size)
   strcat(filepath, filename);
   emu_printf("LoadFile...");
   emu_printf(filepath);
-#ifdef USE_SDFS
   if( !(f_open(&file, filepath, FA_READ)) ) {
     filesize = f_size(&file);
     emu_printf(filesize);
     if (size >= filesize)
     {
-      int retval=0;
+      unsigned int retval=0;
       if( (f_read (&file, buf, filesize, &retval)) ) {
         emu_printf("File read failed");        
       }
     }
     f_close(&file);
   }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
  
   return(filesize);
 }
 
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 

MCUME_pico/pico81/emuapi.cpp

@@ -49,13 +49,13 @@ static char selection[MAX_FILENAME_SIZE+1]="";
 static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
-static int keyMap;
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
 #endif
+static int keyMap;
 
 static bool joySwapped = false;
 static uint16_t bLastState;
@@ -67,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -136,6 +138,10 @@ void emu_Free(void * pt)
 }
 
 
+
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -316,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -344,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -509,6 +514,10 @@ int emu_setKeymap(int index) {
 }
 
 
+
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -680,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -748,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -769,29 +773,17 @@ int emu_FileSize(char * filename)
   return(filesize);    
 }
 
-
-#ifdef SDIO
-
 int emu_FileSeek(int seek) 
 {
-#ifdef USE_SDFS
   f_lseek(&file, seek);
-#else
-  file.seek(seek);
-#endif
   return (seek);
 }
 
 int emu_FileTell(void) 
 {
-#ifdef USE_SDFS
   return (f_tell(&file));
-#else
-  return (50);
-#endif
 }
 
-
 int emu_LoadFile(char * filename, char * buf, int size)
 {
   int filesize = 0;
@@ -802,82 +794,28 @@ int emu_LoadFile(char * filename, char * buf, int size)
   strcat(filepath, filename);
   emu_printf("LoadFile...");
   emu_printf(filepath);
-#ifdef USE_SDFS
   if( !(f_open(&file, filepath, FA_READ)) ) {
     filesize = f_size(&file);
     emu_printf(filesize);
     if (size >= filesize)
     {
-      int retval=0;
+      unsigned int retval=0;
       if( (f_read (&file, buf, filesize, &retval)) ) {
         emu_printf("File read failed");        
       }
     }
     f_close(&file);
   }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
  
   return(filesize);
 }
 
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 

MCUME_pico/picocolem/emuapi.cpp

@@ -50,7 +50,7 @@ static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
@@ -67,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -137,6 +139,9 @@ void emu_Free(void * pt)
 
 
 
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -317,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -345,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -510,6 +514,10 @@ int emu_setKeymap(int index) {
 }
 
 
+
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -681,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -749,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -776,6 +779,10 @@ int emu_FileSeek(int seek)
   return (seek);
 }
 
+int emu_FileTell(void) 
+{
+  return (f_tell(&file));
+}
 
 int emu_LoadFile(char * filename, char * buf, int size)
 {
@@ -803,105 +810,12 @@ int emu_LoadFile(char * filename, char * buf, int size)
   return(filesize);
 }
 
-#ifdef SDIO
-
-
-int emu_FileTell(void) 
-{
-#ifdef USE_SDFS
-  return (f_tell(&file));
-#else
-  return (50);
-#endif
-}
-
-
-int emu_LoadFile(char * filename, char * buf, int size)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFile...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    filesize = f_size(&file);
-    emu_printf(filesize);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (f_read (&file, buf, filesize, &retval)) ) {
-        emu_printf("File read failed");        
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 

MCUME_pico/piconofrendo/emuapi.cpp

@@ -19,10 +19,6 @@ extern "C" {
 #include "tft_t_dma.h"
 #endif
 
-const uint16_t deflogo[] = {
-  0,0
-};
-static const uint16_t * logo = deflogo;
 
 #define MAX_FILES           64
 #define MAX_FILENAME_SIZE   24
@@ -53,13 +49,13 @@ static char selection[MAX_FILENAME_SIZE+1]="";
 static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
-static int keyMap;
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
 #endif
+static int keyMap;
 
 static bool joySwapped = false;
 static uint16_t bLastState;
@@ -71,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -141,6 +139,9 @@ void emu_Free(void * pt)
 
 
 
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -321,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -349,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -514,6 +514,10 @@ int emu_setKeymap(int index) {
 }
 
 
+
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -685,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -753,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -780,6 +779,10 @@ int emu_FileSeek(int seek)
   return (seek);
 }
 
+int emu_FileTell(void) 
+{
+  return (f_tell(&file));
+}
 
 int emu_LoadFile(char * filename, char * buf, int size)
 {
@@ -807,105 +810,12 @@ int emu_LoadFile(char * filename, char * buf, int size)
   return(filesize);
 }
 
-#ifdef SDIO
-
-
-int emu_FileTell(void) 
-{
-#ifdef USE_SDFS
-  return (f_tell(&file));
-#else
-  return (50);
-#endif
-}
-
-
-int emu_LoadFile(char * filename, char * buf, int size)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFile...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    filesize = f_size(&file);
-    emu_printf(filesize);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (f_read (&file, buf, filesize, &retval)) ) {
-        emu_printf("File read failed");        
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 
@@ -933,6 +843,5 @@ void emu_start(void)
 {
   usbnavpad = 0;
 
-  keys = (unsigned short *)key_map1;
   keyMap = 0;
 }

MCUME_pico/picoo2em/emuapi.cpp

@@ -19,6 +19,7 @@ extern "C" {
 #include "tft_t_dma.h"
 #endif
 
+
 #define MAX_FILES           64
 #define MAX_FILENAME_SIZE   24
 #define MAX_MENULINES       9
@@ -49,7 +50,7 @@ static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
@@ -66,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -135,6 +138,10 @@ void emu_Free(void * pt)
 }
 
 
+
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -315,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -343,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -508,6 +514,10 @@ int emu_setKeymap(int index) {
 }
 
 
+
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -679,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -747,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -774,6 +779,10 @@ int emu_FileSeek(int seek)
   return (seek);
 }
 
+int emu_FileTell(void) 
+{
+  return (f_tell(&file));
+}
 
 int emu_LoadFile(char * filename, char * buf, int size)
 {
@@ -801,105 +810,12 @@ int emu_LoadFile(char * filename, char * buf, int size)
   return(filesize);
 }
 
-#ifdef SDIO
-
-
-int emu_FileTell(void) 
-{
-#ifdef USE_SDFS
-  return (f_tell(&file));
-#else
-  return (50);
-#endif
-}
-
-
-int emu_LoadFile(char * filename, char * buf, int size)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFile...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    filesize = f_size(&file);
-    emu_printf(filesize);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (f_read (&file, buf, filesize, &retval)) ) {
-        emu_printf("File read failed");        
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 

MCUME_pico/picosnd/emuapi.cpp

@@ -50,14 +50,13 @@ static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
 #endif
 static int keyMap;
 
-static int keypadval=0; 
 static bool joySwapped = false;
 static uint16_t bLastState;
 static int xRef;
@@ -68,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -138,6 +139,9 @@ void emu_Free(void * pt)
 
 
 
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -203,7 +207,7 @@ int emu_SwapJoysticks(int statusOnly) {
 
 int emu_GetPad(void) 
 {
-  return(keypadval/*|((joySwapped?1:0)<<7)*/);
+  return(bLastState/*|((joySwapped?1:0)<<7)*/);
 }
 
 int emu_ReadKeys(void) 
@@ -276,10 +280,9 @@ int emu_ReadKeys(void)
   unsigned char row;
   unsigned short cols[6]={1,2,3,4,5,14};
   for (int i=0;i<6;i++){
-
+//    gpio_set_dir(cols[i], GPIO_OUT);
     gpio_put(cols[i], 0);
     row=0; 
-    
     row |= (gpio_get(9) ? 0 : 0x01);
     row |= (gpio_get(9) ? 0 : 0x01);
     row |= (gpio_get(9) ? 0 : 0x01);
@@ -289,20 +292,11 @@ int emu_ReadKeys(void)
     row |= (gpio_get(15) ? 0 : 0x08);
     row |= (gpio_get(7) ? 0 : 0x10);
     row |= (gpio_get(22) ? 0 : 0x20);
-    /*
-    if ( !gpio_get(9) ) row |= 0x01;
-    if ( !gpio_get(9) ) row |= 0x01;
-    if ( !gpio_get(9) ) row |= 0x01;
-    if ( !gpio_get(9) ) row |= 0x01;
-    if ( !gpio_get(8) ) row |= 0x02;
-    if ( !gpio_get(6) ) row |= 0x04;
-    if ( !gpio_get(15) ) row |= 0x08;  
-    if ( !gpio_get(7) ) row |= 0x10;
-    if ( !gpio_get(22) ) row |= 0x20;
-    */
+    gpio_put(cols[i], 1);
+//    gpio_set_dir(cols[i], GPIO_IN);
+
     keymatrix[i]=row;
     if (row) keymatrix_hitrow=i;
-    gpio_put(cols[i], 1);
   }
 
   //6,9,15,8,7,22
@@ -320,8 +314,17 @@ int emu_ReadKeys(void)
   if ( row & 0x4  ) retval |= MASK_JOY2_DOWN;
   if ( row & 0x8  ) retval |= MASK_JOY2_UP;  
 #endif
+
+  if ( keymatrix[0] & 0x02 ) { 
+    key_fn = true;
+  }
+  else  {
+    key_fn = false;  
+  }
+
   if ( row & 0x10) retval |= MASK_JOY2_BTN;
-  if ( row & 0x20 ) retval |= MASK_KEY_USER1;
+  if ( key_fn ) retval |= MASK_KEY_USER2;
+  if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
 
   //Serial.println(retval,HEX);
@@ -346,20 +349,18 @@ unsigned short emu_DebounceLocalKeys(void)
 int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
-  if ( keymatrix[0] & 0x02 ) { 
-    key_fn = true;
-  }  
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
-    for (int i=0; i<sizeof(matkeys); i++) {
+    if ( (match == 0x002 )  ) return 0; // shift or fn
+    if (match < 0x100 ) match = match & ~0x002; // ignore shift key
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
-        key_fn = false;  
         return (keys[i]);
       }
     }
@@ -368,6 +369,13 @@ int emu_ReadI2CKeyboard(void) {
   return(retval);
 }
 
+unsigned char emu_ReadI2CKeyboard2(int row) {
+  int retval=0;
+#ifdef PICOMPUTER
+  retval = keymatrix[row];
+#endif
+  return retval;
+}
 void emu_InitJoysticks(void) { 
 
   // Second Joystick   
@@ -438,31 +446,55 @@ void emu_InitJoysticks(void) {
 #endif
 
 #ifdef PICOMPUTER
+  // Output (rows)
   gpio_init(1);
   gpio_init(2);
   gpio_init(3);
   gpio_init(4);
   gpio_init(5);
   gpio_init(14);
-
-  gpio_init(6);
-  gpio_init(9);
-  gpio_init(15);
-  gpio_init(8);
-  gpio_init(7);
-  gpio_init(22);
   gpio_set_dir(1, GPIO_OUT); 
   gpio_set_dir(2, GPIO_OUT); 
   gpio_set_dir(3, GPIO_OUT); 
   gpio_set_dir(4, GPIO_OUT); 
   gpio_set_dir(5, GPIO_OUT); 
   gpio_set_dir(14, GPIO_OUT);
+   
   gpio_put(1, 1);
   gpio_put(2, 1);
   gpio_put(3, 1);
   gpio_put(4, 1);
   gpio_put(5, 1);
   gpio_put(14, 1);
+  
+/*
+  gpio_put(1, 0);
+  gpio_put(2, 0);
+  gpio_put(3, 0);
+  gpio_put(4, 0);
+  gpio_put(5, 0);
+  gpio_put(14, 0);
+  gpio_set_pulls(1,true,true);
+  gpio_set_pulls(2,true,true);
+  gpio_set_pulls(3,true,true);
+  gpio_set_pulls(4,true,true);
+  gpio_set_pulls(5,true,true);
+  gpio_set_pulls(14,true,true);
+  gpio_set_dir(1, GPIO_IN); 
+  gpio_set_dir(2, GPIO_IN); 
+  gpio_set_dir(3, GPIO_IN); 
+  gpio_set_dir(4, GPIO_IN); 
+  gpio_set_dir(5, GPIO_IN); 
+  gpio_set_dir(14, GPIO_IN); 
+*/
+
+  // Input pins (cols)
+  gpio_init(6);
+  gpio_init(9);
+  gpio_init(15);
+  gpio_init(8);
+  gpio_init(7);
+  gpio_init(22);
   gpio_set_pulls(6,true,false);
   gpio_set_dir(6,GPIO_IN);  
   gpio_set_pulls(9,true,false);
@@ -478,14 +510,14 @@ void emu_InitJoysticks(void) {
 #endif
 }
 
-
-
-
 int emu_setKeymap(int index) {
 }
 
 
 
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -498,7 +530,6 @@ static int readNbFiles(char * rootdir) {
   FILINFO entry;
   FRESULT fr = f_findfirst(&dir, &entry, rootdir, "*");
   while ( (fr == FR_OK) && (entry.fname[0]) && (totalFiles<MAX_FILES) ) {  
-//    f_readdir(&dir, &entry);
     if (!entry.fname[0]) {
       // no more files
       break;
@@ -658,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -726,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -747,29 +773,17 @@ int emu_FileSize(char * filename)
   return(filesize);    
 }
 
-
-#ifdef SDIO
-
 int emu_FileSeek(int seek) 
 {
-#ifdef USE_SDFS
   f_lseek(&file, seek);
-#else
-  file.seek(seek);
-#endif
   return (seek);
 }
 
 int emu_FileTell(void) 
 {
-#ifdef USE_SDFS
   return (f_tell(&file));
-#else
-  return (50);
-#endif
 }
 
-
 int emu_LoadFile(char * filename, char * buf, int size)
 {
   int filesize = 0;
@@ -780,82 +794,28 @@ int emu_LoadFile(char * filename, char * buf, int size)
   strcat(filepath, filename);
   emu_printf("LoadFile...");
   emu_printf(filepath);
-#ifdef USE_SDFS
   if( !(f_open(&file, filepath, FA_READ)) ) {
     filesize = f_size(&file);
     emu_printf(filesize);
     if (size >= filesize)
     {
-      int retval=0;
+      unsigned int retval=0;
       if( (f_read (&file, buf, filesize, &retval)) ) {
         emu_printf("File read failed");        
       }
     }
     f_close(&file);
   }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
  
   return(filesize);
 }
 
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 

MCUME_pico/picospeccy/emuapi.cpp

@@ -49,13 +49,13 @@ static char selection[MAX_FILENAME_SIZE+1]="";
 static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
-static int keyMap;
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
 #endif
+static int keyMap;
 
 static bool joySwapped = false;
 static uint16_t bLastState;
@@ -67,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -137,6 +139,9 @@ void emu_Free(void * pt)
 
 
 
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -317,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -345,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -510,6 +514,10 @@ int emu_setKeymap(int index) {
 }
 
 
+
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -681,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -749,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -776,6 +779,10 @@ int emu_FileSeek(int seek)
   return (seek);
 }
 
+int emu_FileTell(void) 
+{
+  return (f_tell(&file));
+}
 
 int emu_LoadFile(char * filename, char * buf, int size)
 {
@@ -803,105 +810,12 @@ int emu_LoadFile(char * filename, char * buf, int size)
   return(filesize);
 }
 
-#ifdef SDIO
-
-
-int emu_FileTell(void) 
-{
-#ifdef USE_SDFS
-  return (f_tell(&file));
-#else
-  return (50);
-#endif
-}
-
-
-int emu_LoadFile(char * filename, char * buf, int size)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFile...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    filesize = f_size(&file);
-    emu_printf(filesize);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (f_read (&file, buf, filesize, &retval)) ) {
-        emu_printf("File read failed");        
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver(); 

MCUME_pico/picovcs/emuapi.cpp

@@ -50,7 +50,7 @@ static char files[MAX_FILES][MAX_FILENAME_SIZE];
 static bool menuRedraw=true;
 
 #ifdef PICOMPUTER
-static unsigned short * keys;
+static const unsigned short * keys;
 static unsigned char keymatrix[6];
 static int keymatrix_hitrow=-1;
 static bool key_fn=false;
@@ -67,7 +67,9 @@ static bool menuOn=true;
 
 
 
-
+/********************************
+ * Generic output and malloc
+********************************/ 
 void emu_printf(char * text)
 {
   printf("%s\n",text);
@@ -137,6 +139,9 @@ void emu_Free(void * pt)
 
 
 
+/********************************
+ * Input and keyboard
+********************************/ 
 int emu_ReadAnalogJoyX(int min, int max) 
 {
   adc_select_input(0);
@@ -317,7 +322,7 @@ int emu_ReadKeys(void)
     key_fn = false;  
   }
 
-  if ( keymatrix[0] & 0x20) retval |= MASK_JOY2_BTN;
+  if ( row & 0x10) retval |= MASK_JOY2_BTN;
   if ( key_fn ) retval |= MASK_KEY_USER2;
   if ( ( key_fn ) && (row == 0x20 )) retval |= MASK_KEY_USER1;
 #endif
@@ -345,19 +350,18 @@ int emu_ReadI2CKeyboard(void) {
   int retval=0;
 #ifdef PICOMPUTER
   if (key_fn) {
-    keys = (unsigned short *)key_map2;    
+    keys = (const unsigned short *)key_map2;    
   }
   else {
-    keys = (unsigned short *)key_map1;    
+    keys = (const unsigned short *)key_map1;    
   }
   if (keymatrix_hitrow >=0 ) {
     unsigned short match = ((unsigned short)keymatrix_hitrow<<8) | keymatrix[keymatrix_hitrow];  
     if ( (match == 0x002 )  ) return 0; // shift or fn
     if (match < 0x100 ) match = match & ~0x002; // ignore shift key
-    for (int i=0; i<sizeof(matkeys); i++) {
+    for (int i=0; i<sizeof(matkeys)/sizeof(unsigned short); i++) {
       if (match == matkeys[i]) {    
         return (keys[i]);
-//        return (match);
       }
     }
   }
@@ -511,6 +515,9 @@ int emu_setKeymap(int index) {
 
 
 
+/********************************
+ * Menu file loader UI
+********************************/ 
 #include "ff.h"
 static FATFS fatfs;
 static FIL file; 
@@ -682,13 +689,9 @@ char * menuSelection(void)
 }
 
 
-
-
-
-
-
-
-
+/********************************
+ * File IO
+********************************/ 
 int emu_FileOpen(char * filename)
 {
   int retval = 0;
@@ -750,7 +753,6 @@ unsigned char emu_FileGetc(void) {
   return c; 
 }
 
-
 void emu_FileClose(void)
 {
   f_close(&file); 
@@ -777,6 +779,10 @@ int emu_FileSeek(int seek)
   return (seek);
 }
 
+int emu_FileTell(void) 
+{
+  return (f_tell(&file));
+}
 
 int emu_LoadFile(char * filename, char * buf, int size)
 {
@@ -804,105 +810,12 @@ int emu_LoadFile(char * filename, char * buf, int size)
   return(filesize);
 }
 
-#ifdef SDIO
-
-
-int emu_FileTell(void) 
-{
-#ifdef USE_SDFS
-  return (f_tell(&file));
-#else
-  return (50);
-#endif
-}
-
-
-int emu_LoadFile(char * filename, char * buf, int size)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFile...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    filesize = f_size(&file);
-    emu_printf(filesize);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (f_read (&file, buf, filesize, &retval)) ) {
-        emu_printf("File read failed");        
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    filesize = file.size(); 
-    emu_printf(filesize);
-    
-    if (size >= filesize)
-    {
-      if (emu_FileRead(buf, filesize) != filesize) 
-      {
-        emu_printf("File read failed");
-      }        
-    }
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-
-int emu_LoadFileSeek(char * filename, char * buf, int size, int seek)
-{
-  int filesize = 0;
-    
-  char filepath[80];
-  strcpy(filepath, romspath);
-  strcat(filepath, "/");
-  strcat(filepath, filename);
-  emu_printf("LoadFileSeek...");
-  emu_printf(filepath);
-#ifdef USE_SDFS
-  if( !(f_open(&file, filepath, FA_READ)) ) {
-    f_lseek(&file, seek);
-    emu_printf(size);
-    if (size >= filesize)
-    {
-      int retval=0;
-      if( (!f_read (&file, buf, size, &retval)) ) 
-      if (retval != size)
-      {
-        emu_printf("File read failed");      
-      }
-    }
-    f_close(&file);
-  }
-#else
-  if ((file = SD.open(filepath, O_READ))) 
-  {
-    file.seek(seek);
-    emu_printf(size);
-    if (file.read(buf, size) != size) {
-      emu_printf("File read failed");
-    }        
-    file.close();
-  }
-#endif  
-  
-  return(filesize);
-}
-#endif
 
 
 
+/********************************
+ * Initialization
+********************************/ 
 void emu_init(void)
 {
   sd_init_driver();