Merge pull request #148 from adafruit/fix-v1-i2c-output-components

[v1] I2C Output Component Bugfixes

.github/workflows/protoc-wrapper-generation.yml

@@ -15,7 +15,7 @@ jobs:
     steps:
 
     # Setup
-    - uses: actions/setup-python@v2
+    - uses: actions/setup-python@v5
       with:
         python-version: '3.x'
     - name: Install Protoc
@@ -28,7 +28,7 @@ jobs:
         python -m pip install --upgrade pip
         pip install protobuf setuptools
     - name: Self Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         path: protobuf-checkout
         submodules: true
@@ -53,7 +53,7 @@ jobs:
         # protoc --plugin=nanopb/generator/protoc-gen-nanopb -Inanopb/generator/proto --proto_path=./proto ./proto/wippersnapper/*/*/*.proto --nanopb_out=./arduino_out --nanopb_opt=-I./proto --nanopb_opt=-t --plugin=protoc-gen-doc=./protoc-gen-doc --doc_out=./doc --doc_opt=html,index.html
 
     - name: Checkout Arduino Repo
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         repository: adafruit/Adafruit_Wippersnapper_Arduino
         token: ${{ secrets.IO_BOT_PAT }}
@@ -84,7 +84,7 @@ jobs:
         protoc --proto_path=./protobuf-checkout/proto ./protobuf-checkout/proto/wippersnapper/*/*/*.proto --js_out=import_style=commonjs,binary:js_out
         protoc ./protobuf-checkout/nanopb/generator/proto/nanopb.proto --js_out=import_style=commonjs,binary:js_out
     - name: Checkout io-node Repo
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         repository: AdafruitInternalDev/io-node
         token: ${{ secrets.IO_BOT_PAT }}
@@ -112,7 +112,7 @@ jobs:
 
     # Docs
     - name: Checkout doc branch
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         ref: gh-pages
         path: protobuf-docs-checkout
@@ -124,11 +124,11 @@ jobs:
         git commit -m "Add generated HTML documentation for $GITHUB_SHA" || exit 0 # quit cleanly if nothing to commit
         git push
     - name: Setup Pages
-      uses: actions/configure-pages@v3
+      uses: actions/configure-pages@v5
     - name: Upload artifact
-      uses: actions/upload-pages-artifact@v2
+      uses: actions/upload-pages-artifact@v3
       with:
         path: 'protobuf-docs-checkout/doc'
     - name: Deploy to GitHub Pages
       id: deployment
-      uses: actions/deploy-pages@v2
+      uses: actions/deploy-pages@v4

proto/wippersnapper/i2c/v1/i2c.proto

@@ -91,7 +91,7 @@ message I2CDeviceInitRequest {
   int32  i2c_port_number                                    = 1; /** The desired I2C port to initialize an I2C device on. */
   I2CBusInitRequest i2c_bus_init_req                        = 2; /** An I2C bus initialization request. */
   uint32 i2c_device_address                                 = 3; /** The 7-bit I2C address of the device on the bus. */
-  string i2c_device_name                                    = 4[(nanopb).max_size = 15]; /** The I2C device's name, MUST MATCH the name on the JSON definition file on https://github.com/adafruit/Wippersnapper_Components. */
+  string i2c_device_name                                    = 4[(nanopb).max_size = 256]; /** The I2C device's name, MUST MATCH the name on the JSON definition file on https://github.com/adafruit/Wippersnapper_Components. */
   repeated I2CDeviceSensorProperties i2c_device_properties  = 5[(nanopb).max_count = 15]; /** Properties of each sensor on the I2C device. */
   bool is_output_device                                     = 6; /** True if the I2C device is an I2C output device, False otherwise (default). */
   I2COutputAdd i2c_output_add                               = 7; /** The configuration for an I2C output device. */
@@ -114,7 +114,7 @@ message I2CDeviceInitResponse {
 message I2CDeviceUpdateRequest {
   int32  i2c_port_number                                    = 1; /** The desired I2C port. */
   uint32 i2c_device_address                                 = 2; /** The 7-bit I2C address of the device on the bus. */
-  string i2c_device_name                                    = 3[(nanopb).max_size = 15]; /** The I2C device's name, MUST MATCH the name on the JSON file. */
+  string i2c_device_name                                    = 3[(nanopb).max_size = 256]; /** The I2C device's name, MUST MATCH the name on the JSON file. */
   repeated I2CDeviceSensorProperties i2c_device_properties  = 4[(nanopb).max_count = 15]; /** Properties for the I2C device's sensors. */
 }
 
@@ -215,7 +215,7 @@ message I2CDeviceEvent {
 */
 message I2CDeviceOutputWrite {
   uint32 i2c_device_address             = 1; /** The 7-bit I2C address of the device on the bus. */
-  string i2c_device_name                = 2[(nanopb).max_size = 15]; /** The I2C device's name, MUST MATCH the name on the JSON definition file on https://github.com/adafruit/Wippersnapper_Components. */
+  string i2c_device_name                = 2[(nanopb).max_size = 256]; /** The I2C device's name, MUST MATCH the name on the JSON definition file on https://github.com/adafruit/Wippersnapper_Components. */
   oneof output_msg {
     LEDBackpackWrite write_led_backpack = 3; /** Optional - If the I2C device is a LED backpack, fill this field. **/
     CharLCDWrite write_char_lcd         = 4; /** Optional - If the I2C device is a character LCD, fill this field. **/
@@ -284,7 +284,7 @@ message I2COutputAdd {
 * LEDBackpackWrite represents a request from the broker to write a message to a LED backpack.
 */
 message LEDBackpackWrite {
-  string message = 1 [(nanopb).max_size = 5]; /** Message to write to the LED backpack. **/
+  string message = 1 [(nanopb).max_size = 128]; /** Message to write to the LED backpack. **/
 }
 
 /**
@@ -300,5 +300,5 @@ message CharLCDWrite {
 * write to a SSD1306 OLED display.
 */
 message SSD1306Write {
-  string message = 1 [(nanopb).max_size = 128]; /** Message to write to a SSD1306 OLED display. **/
+  string message = 1 [(nanopb).max_size = 256]; /** Message to write to a SSD1306 OLED display. **/
 }