adafruit-mirror/arduino-esp32
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

change(MD5Builder): Const-correctness. (#9104)

Browse source 
* change(HashBuilder): Const-correctness

Propagate 'const' of buffer variable from underlying functions.

* Remove char* methods

---------

Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
This commit is contained in:
Stefan Oberhumer 2024-01-19 16:21:50 +01:00 committed by GitHub
parent 2e5c932aeb
commit 9aae6f5ec2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 6 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
cores/esp32/HashBuilder.h
View file

@ -26,14 +26,10 @@ public:
virtual ~HashBuilder() {}
virtual void begin() = 0;
virtual void add(uint8_t* data, size_t len) = 0;
virtual void add(const uint8_t* data, size_t len) = 0;
virtual void add(const char* data)
{
add((uint8_t*)data, strlen(data));
}
virtual void add(char* data)
{
add((const char*)data);
add((const uint8_t*)data, strlen(data));
}
virtual void add(String data)
{
@ -41,10 +37,6 @@ public:
}
virtual void addHexString(const char* data) = 0;
virtual void addHexString(char* data)
{
addHexString((const char*)data);
}
virtual void addHexString(String data)
{
addHexString(data.c_str());

2
cores/esp32/MD5Builder.cpp
View file

@ -27,7 +27,7 @@ void MD5Builder::begin(void)
esp_rom_md5_init(&_ctx);
}
void MD5Builder::add(uint8_t * data, size_t len)
void MD5Builder::add(const uint8_t * data, size_t len)
{
esp_rom_md5_update(&_ctx, data, len);
}

2
cores/esp32/MD5Builder.h
View file

@ -38,7 +38,7 @@ public:
void begin(void) override;
using HashBuilder::add;
void add(uint8_t * data, size_t len) override;
void add(const uint8_t * data, size_t len) override;
using HashBuilder::addHexString;
void addHexString(const char * data) override;

2
cores/esp32/SHA1Builder.cpp
View file

@ -230,7 +230,7 @@ void SHA1Builder::begin(void)
memset(hash, 0x00, sizeof(hash));
}
void SHA1Builder::add(uint8_t* data, size_t len)
void SHA1Builder::add(const uint8_t* data, size_t len)
{
size_t fill;
uint32_t left;

2
cores/esp32/SHA1Builder.h
View file

@ -36,7 +36,7 @@ public:
void begin() override;
using HashBuilder::add;
void add(uint8_t* data, size_t len) override;
void add(const uint8_t* data, size_t len) override;
using HashBuilder::addHexString;
void addHexString(const char* data) override;