adafruit-mirror/arduino-esp32
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve Log Messages in GPIO HAL (#9011)

Browse source 
* Improve Log Messages

* uses pin# in log messages

* Uses IO # in messages
This commit is contained in:
Rodrigo Garcia 2023-12-19 17:12:40 -03:00 committed by GitHub
parent c7a109bac4
commit e9ee9c118b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
cores/esp32/esp32-hal-gpio.c
View file

@ -104,14 +104,14 @@ extern void ARDUINO_ISR_ATTR __pinMode(uint8_t pin, uint8_t mode)
#endif #endif
if (pin >= SOC_GPIO_PIN_COUNT) { if (pin >= SOC_GPIO_PIN_COUNT) {
log_e("Invalid pin selected"); log_e("Invalid IO %i selected", pin);
return; return;
} }
if(perimanGetPinBus(pin, ESP32_BUS_TYPE_GPIO) == NULL){ if(perimanGetPinBus(pin, ESP32_BUS_TYPE_GPIO) == NULL){
perimanSetBusDeinit(ESP32_BUS_TYPE_GPIO, gpioDetachBus); perimanSetBusDeinit(ESP32_BUS_TYPE_GPIO, gpioDetachBus);
if(!perimanClearPinBus(pin)){ if(!perimanClearPinBus(pin)){
log_e("Deinit of previous bus failed"); log_e("Deinit of previous bus from IO %i failed", pin);
return; return;
} }
} }
@ -140,7 +140,7 @@ extern void ARDUINO_ISR_ATTR __pinMode(uint8_t pin, uint8_t mode)
} }
if(gpio_config(&conf) != ESP_OK) if(gpio_config(&conf) != ESP_OK)
{ {
log_e("GPIO config failed"); log_e("IO %i config failed", pin);
return; return;
} }
if(perimanGetPinBus(pin, ESP32_BUS_TYPE_GPIO) == NULL){ if(perimanGetPinBus(pin, ESP32_BUS_TYPE_GPIO) == NULL){
@ -164,7 +164,7 @@ extern void ARDUINO_ISR_ATTR __digitalWrite(uint8_t pin, uint8_t val)
if(perimanGetPinBus(pin, ESP32_BUS_TYPE_GPIO) != NULL){ if(perimanGetPinBus(pin, ESP32_BUS_TYPE_GPIO) != NULL){
gpio_set_level((gpio_num_t)pin, val); gpio_set_level((gpio_num_t)pin, val);
} else { } else {
log_e("Pin is not set as GPIO."); log_e("IO %i is not set as GPIO.", pin);
} }
} }
@ -174,7 +174,7 @@ extern int ARDUINO_ISR_ATTR __digitalRead(uint8_t pin)
return gpio_get_level((gpio_num_t)pin); return gpio_get_level((gpio_num_t)pin);
} }
else { else {
log_e("Pin is not set as GPIO."); log_e("IO %i is not set as GPIO.", pin);
return 0; return 0;
} }
} }
@ -204,7 +204,7 @@ extern void __attachInterruptFunctionalArg(uint8_t pin, voidFuncPtrArg userFunc,
interrupt_initialized = (err == ESP_OK) || (err == ESP_ERR_INVALID_STATE); interrupt_initialized = (err == ESP_OK) || (err == ESP_ERR_INVALID_STATE);
} }
if(!interrupt_initialized) { if(!interrupt_initialized) {
log_e("GPIO ISR Service Failed To Start"); log_e("IO %i ISR Service Failed To Start", pin);
return; return;
} }