As it was written, it was possible to leak the scan result array if esp_wifi_scan_get_ap_records() failed. Change will ensure that the array is deleted in that case.
* feat(openthread): add extended example
Creates a new example that mixes different APIs
* feat(openthread): create cj.json file
Adds neessary CI file
* feat(openthread): improve the example
Update ExtendedRoterNode.ino with more use of API
* feat(openthread): improve the example
Adds OpenThread Native calls to the example
* feat(openthread): improve the example
Update LeaderNode.ino example to add OpenThread Native calls.
* fix(openthread): bad formatting using space
Update keywords.txt to use TAB instead of SPACE in order to recognize correctly the keywords.
* fix(openthread): bad example file name - typo
Changed ExtendedRoterNode to ExtendedRouterNode - Typo error.
* feat(openthread): add extended example ci.json file
Added CI file to the example.
* fix(openthread): deleted bad file names in the example
Delete libraries/OpenThread/examples/SimpleThreadNetwork/ExtendedRoterNode directory
* fix(openthread): typo in commentaries
* fix(openthread): typo in commentaries
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(littlefs): Use VFSImpl::exists() to avoid false error log
* fix(ffat): Use VFSImpl::exists() to avoid false error log
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update WebServer.ino
* Enable FAT and LittleFS filesystems as configured.
* use new versions of RequestHandler::canHandle and RequestHandler::canUpload
* Update Documentation
* Documentation changed accoring review comments.
* README.md changed accoring to review comments.
* feat(net): Add NAPT examples for STA and ETH
* feat(net): Add NAPT example for PPP
* feat(net): Add CI configs to skip H2
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(lwip): Add early out in `NetworkUDP::parsePacket()` when socket has no data
Previously, `NetworkUDP::parsePacket()` would take the time to allocate a 1460 byte buffer
to call `recvfrom()` with, immediately freeing it if there was no data read.
This change has it check if there is available data via `ioctl()` with `FIONREAD` first,
saving the allocation and thus significantly increasing performance in no data situations.
* fix(lwip): Initialize `len` to ensure it's set before check
* add "getBattery" functions + #define simplicity
replaced all function protections with a #define to simplify code functionality. Also added "getBattery" functions to leverage "esp_modem_get_battery_status" call in ESP-MODEM.
* add "getBattery" function defs to PPP.h
* fix(ppp): uncomment error logging, change new function naming
* fix(ppp): rename new functions for naming conformity
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* IDF release/v5.1 dc859c1e67
* fix(lwip): Filter out V6 packets if V6 is not enabled
the ESP might accept and act on some IPv6 packets, even though IPv6 is not enabled for the interface in Arduino. This change makes the ESP ignore all IPv6 packets if IPv6 address is not available.
* fix(lwip): DNS header is not required
* fix(ot): Add LWIP_HOOK_IP6_INPUT_CUSTOM support
* feat(ledc): Allow attaching multiple pins to 1 channel
* feat(ledc): Add ledcWriteChannel function
* feat(ledc): Print info about already set channel
* docs(ledc): Add ledcWriteChannel function and attach update
* feat(ledc): Add example and fixes
* feat(ledc): Remove commented code
* feat(ledc): Fix missing new line at end of file
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
The setPins() function obviously comes from the SD_MMC lib. Not prepending
that lib, this code won't compile.
Signed-off-by: Martin Hübner <martin.hubner@web.de>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* fix(example): Add better WPS logging
Provides a better log of what went wrong when using WPS
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(eth): Allow setting the RX task stack size
Default stack size of 2K might not be enough in some cases. Increase the default to safer 4K and allow setting it to custom value.
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* Fix timeout in WebServer::_uploadReadByte and set timeout handleClient()
Fixes: #9990
* Set HTTP_MAX_CLOSE_WAIT equal to other HTTP_xxx_WAIT values
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
If the interface is already connected, try to enable IPv6 immediately. Otherwise the interface would need to go through disconnect/connect cycle for IPv6 to be enabled.
* feat(OThread): Add Library
* fix(OpenThread): fixes file list in CMakeLists.txt
* fix(openthread): Fixes JSON CI Files
* fix(openthread): Fixes JSON CI Files
* fix(openthread): Include Openthread guarding
* fix(openthread): COAP parametrization
* fix(openthread): Include Openthread guarding
* fix(openthread): Improves commentaries and code
* fix(openthread): Improves code
* fix(openthread): Includes StreamString.h
* feat(openthread): New Scan Example
* feat(openthread): Improved Scan Example
* feat(openthread): README.md
Initial documentation for ESP3 Arduino OpenThread CLI API.
* feat(openthread): helper functions documentation
Create helper_functions.md for ESP32 Arduino OpenThread API
* fix(openthread): begin end
* feat(openthread): onReceice example
* fix(openthread): tx queue error
* fix(doc): fixing documentation apresentation
Fixes the documentation first paragraph in order to make it easier fore reading. It also displays in the very top which SoC are supported by the library.
* fix(doc): documentation format
* feat(openthread): commentary
* fix(openthread): Typo, start/stop console
* fix(openthread): library properties
* ci(pre-commit): Apply automatic fixes
* feat(openthread): formatting text
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(ppp): Make modem reset delay configurable
The delay required to reset Simcom modem modules varies significantly across
different models, even where they have otherwise identical AT command
sets.
Simcom A7672 was failing to reset with the default 200ms delay. Make the reset
delay configurable to allow customising this for a specific modem.
Default delay, if not specified is kept at 200ms.
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat(net): Deprecate old WiFi APIs
Deprecates WiFiClient, WiFiServer, WiFiUdp and WiFiClientSecure
* fix(net): add defines to WiFi.h
Defines are added to not cause deprecation warnings. Will be removed in the future
* fix(net): Use typedefs instead to help with forward declarations
Defines do not allow forward declarations
* HTTPClient lib - add HTTPCLIENT_NOSECURE build flag
`HTTPCLIENT_NOSECURE` build flag disables TLS support in HTTPClient library by
excluding `NetworkClientSecure.h` header.
This allows linker to strip down mbedTLS lind and certificates bundle,
which in turn reduces firmware image for about ~80kib.
* Update HTTPClient.cpp
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(example): EXT0 and EXT1 wakeup
Fixes the Deep Sleep wakup example to run with IDF5.1. The API has changed and a adjustment was necessary.
* feat(wakeup): Use Macro for GPIO_NUM
Changed the example to use a #define for the RTC IO Pin (GPIO) used in the example.
* fix(typo): typo and commentaries
Fixes the commentary to the correct IDF terms.
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Adds a class for 0x2901 - Characteristic User Descriptor.
This Descriptor is usual in BLE and describes with text what each characteristic is about.
Improve Notify.ino example by adding the 0x2901 descriptor
* fix(netbios): Return interface address for NetBIOS
When NetBIOS returns a match, it should return the IP address of the device.
Presently, however, it returns the address of multicast IP for the subnet
since the incoming NBNS packet's UDP target will be multicast
(i.e. 192.168.1.255).
Iterate over the active network interfaces and check netmasks to determine
where the packet came from, and return the appropriate IP interface address
instead.
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(wifi): Fix WiFi setTxPower and getTxPower
We need to wait for the interface to be started in order to be able to set/get TX Power. Code was returning too early, so calling the functions after `begin()` resulted in failure.
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat: added support for filters in webserver
* feat: add setFilter function in StaticRequestHandler
* fix: ON_STA_FILTER & ON_AP_FILTER
* fix: make request handlers backward compatible
* fix: ON_STA_FILTER & ON_AP_FILTER
* fix: more filters to their own example
* chore: grammar
* fix: remove filters from header file
* fix: use same root route for both interfaces
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix(ssl): Fix load stream memory leak
Loading Ca Cert/Certificate or Private Key from stream was leaking memory, due to buffers not being freed.
* fix(ssl): Cast the buffers to non-const
* fix(net): Don't unreg events if there are netifs
Unregister IP events only if all other netifs are stopped.
* fix(eth): Delete mac and phy on end
* fix(net): Update pin naming and log levels
* IDF release/v5.1 01b912a9e5
* Fix USB OTG Init on new IDF
* Delete libraries/TFLiteMicro/examples/micro_speech directory
Done in order to fix a CI problem created by an entire folder that was removed in original Library Repository.
* IDF release/v5.1 442a798083
* Update esp32-hal-tinyusb.c
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* (feat)usbmsc: Add is_writable function
Add is_writable function to the USBMSC class.
Allows USBMSC to be mounted in read-only mode.
* Update USBMSC.ino
Changes to USB Mass Storage (MSC) example code in Arduino USB library
* Added MSC.isWritable(true) line to set the disk as writable
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* fix: NetworkClient - close the connection in stop() method
for all copies referring it
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
* feat: Ethernet - MAC address parameter for beginSPI
and `friend class EthernetClass`
as support for potential Arduino API compatibility layer
* ci(pre-commit): Apply automatic fixes
---------
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Work around because AF_UNSPEC does not check available addresses when
determining result.
If you have a global scope IPv6 address, then first check for IPv6 DNS result;
if you don't have an IPv6, or there is no IPv6 result, then check IPv4.
This allows IPv6-only networks to connect to dual-stack destinations, as they
will get the IPv6 address (rather than the unusable IPv4).
It also means a dual-stack host to a dual-stack destination will preference
IPv6.
There is no effect if you are on an IPv4-only network, or it is an IPv4-only
destination.
Similar to NetworkClient, check the family of the passed in address and configure the socket and socket address accordingly, for both IPv6 and IPv4 support.
* feat(net): Add support for esp_netif flags
Provides better automation for setting IP/DNS
* feat(net): Show DHCPC status as OFF when static IP is used
* fix(dns): Handle IPv6 DNS server address results
If the result from esp_netif_get_dns_info is an IPv6 address, then parse to an IPAddress.
* fix(dns): Use getaddrinfo for DNS, to fix some IPv6 issues
Replace hostbyname with getaddrinfo for better IPv6 support. The API is also
simpler, as it has no callbacks (they are handled internally). Allows
dual-stack networks to connect to IPv6-only destinations.
Still does not work for IPv6-only networks, as IPv6 DNS is not enabled in the
pre-built ESP-IDF libraries.
* feat(libs): Add ESP-NOW Arduino library
* Update libraries/ESP_NOW/src/ESP32_NOW.cpp
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update libraries/ESP_NOW/src/ESP32_NOW.cpp
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* fix(esp-now): Add check if Wifi is started.
* Fix ESP_NOW_Serial
* Add ESP NOW Serial Example
* Add comment
* Skip esp-now example for esp32h2
* Add broadcast address constant
* Change return value to align with other APIs
* Apply suggested changes
* Improve example
* Fix example
* Improve serial example
* Add argument to receive callback to know if a message was broadcasted
* Update libraries/ESP_NOW/src/ESP32_NOW_Serial.cpp
* Simplify example
* Add broadcast example
* Change comments
* Change comment
* Improve broadcast master example
* Remove examples using IDF's API
* Fix example
* Add network example
* Add skip file
* Add LMK back
* Add logs
* Improve example
* Fix example
* Apply @suglider suggestions from code review
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Add documentation
* fix examples links in docs
* Apply @lucasssvaz suggestions to docs
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update espnow.rst
* Update examples
* make onSent optional and remove underscores for virtual functions
* Make onRecieve also optional and make constructor protected
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: me-no-dev <hristo@espressif.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Matched pin numbers in doco to numbers in variants files
* Non-breaking dashes
* Changed SD examples to make REASSIGN_PINS more transparent. Fixes#9082
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Create ESP_NetworkInterface class and have Ethernet extending it
* Update CMakeLists.txt
* Split networking from WiFi (H2 can now use Ethernet)
Now all libs have been checked yet. More to do on WiFi side
* Fix build errors
* Guard WiFi classes and fix RMII ETH examples
* Decouple network related libraries from WiFi
* Fix examples and WiFiUpdate
* Guard WiFiProv lib to compile only on WiFi chips
* Add periman string for network and "fix" mdns on the first ETH
* Revert back location of Client/Server/Udp in order to accept some PRs
* Fix periman
* Some fixes from merging master
* Fix web server missing fs.h
* Move Client, Server and Udp out of WiFi
* More fixes
* more fixes
* Fix CMakekLists and rework lib menu dependencies
* Fix CMake issues
* move back WiFiClient to rebase with master
* Update ETH_TLK110.ino
* Move back WiFiClient
* Update progress
* Update WiFiGeneric.cpp
* More fixes
* Switch AP to the new interface
* Cleanup
* Rename AP methods
* Add extra interface info for Printable
* Rename IPv6 getters to clarify that they are returning LinkLocal address
cc @sgryphon
* Rename network classes
cc @sgryphon
* Update NetworkManager.h
* Rename WiFi Server and UDP
* Rename WiFiClient and WiFiClientSecure
* Update CMakeLists.txt
* Update on-push.sh
* Rename Network library
* Remove unnecessary guard
* Get the correct interface MAC address for mDND Workstation service
* Apply suggestions from code review
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* feat: onReceiveExample.ino
Adds a new example that uses HardwareSerial::onReceive(). The example demosntrates how to read all the data sent to UART0, considering that the end of transmission is defined by a period of time with UART in idle state.
* fix: onReceiveExample.ino
Fixes typos
* feat: add explanation header
* fix: mutex release
* fix: add Mutex verification
* feat: Mutex error message
* feat: Mutex NULL testing
* feat(hwcdc): fix delay
Fixes delay when CDC is disconnected. At this time is only fixes it when USB cable is unplugged.
* feat(hwcdc): fix delay
fixes delay when CDC is not connected. It was only considering when the USB cable was not plugged.
* feat(hwcdc): add 2 methods
Adds 2 new methods:
- isPlugged() will return true when USB cable is plugged, false otherwise.
- isConnected() will return true when USB CDC is connected to a application in the USB Host side and communication is stablished.
* feat(hwcdc): adjusts APIs
Fixes the example to use the new added APIs for checking if USB cable is plugged and for checking if CDC is connected.
* fixes api declaration
* fixes API declaration
* feat(hw_cdc):fixes the hardware cdc jtag plugged/unplugged status
This will use a new IDF 5.1 feature to detect if the USB HW CDC is plugged or not. This can be checked testing HWCDCSerial.
It also fixes issues related to timeout or delays while writing to the HW Serial when USB is unplugged.
* feat(usb): Creates HWSerial_Events.ino example
* feat: adds .skip.esp32
Skips the ESP32 SoC test given that it has no USB
* feat: adds .skip.esp32s2
Skips the ESP32S2 because it has no HW CDC JTAG interface
* fix: fixes issues with Ubuntu CI
Only compiles the example in case it is using Hardware CD and JTAG mode.
* feat(serialcdc): non block functions
modifies write and flush to do not clock in case CDC host is not connected to the CDC client from the C3/S3/C6/H2
* fix(HWCDC): changes made demands testing for CDC ON BOOT
* feat(hwcdc): Improves HWSerial_Events.ino
Improves the example by adding more information about USB being plugged and CDC being connected.
* feat(hwcdc): solves CDC connection issue
Detects correctly when CDC is or not connected.
Deals with USB unplugged while the sketch is printing to CDD.
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Update cores/esp32/HWCDC.cpp
* Apply suggestions from code review
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* [W5500] Support no-IRQ
Requires this commit from ESP-IDF to be cherry picked:
fd0a1dc53c
* Remove unrelated code to support ETH_PHY_JL1101
* remove the commented check and fix the error message
* Guard feature to be enabled when IDF backports it to v5.1
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* fix(esp32): 🐛 Fixed "Invalid mbox" in the Wi-Fi example
* fix: changes the code to actually connect to the WiFi in roder to get time and date
* fix: removing call to WiFi.begin() at the end of the sketch. It must be called at first.
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Update subpart ("PostArg") parsing to ignore extra headers instead of silently failing.
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* RMT (featt): adds a new function to set EOT level after RMT writing
* RMT (feat): adds new feature to set the EOT level after writing RMT channel
* adds return value to rmtSetEOT()
* adds bool return to rmtSetEOT()
* adds return value to the rmtSetEOT() function
* FIX (rmt): fixes eot_level setting using flags in the TX structure
* RMT(feat): Create RMT_EndOfTransmissionState.ino example
* Update cores/esp32/esp32-hal-rmt.h
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Update cores/esp32/esp32-hal-rmt.c
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Update cores/esp32/esp32-hal-rmt.c
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Split start_ssl_client into two phases; to allow the implementation of protocols that use some sort of in-band STARTTLS or STARTSSL signal to upgrade a plaint text connection to SSL/TLS. Examples of these protocols are XMPP, SMTP and various database TCP connections.
* Remove removed setTimeout that was accidentally included (was removed for IDF >=5), bring timeout inline with the other timeouts (ints), fix cert/key checks to look if there is actually something there (all issues caught by the CI/CD on windows-latest
* Quell compiler warning; use the right timeout
* Newer versions of MBEDTLS make the client key struct private (and most of the x509 struct too), so absent of a non-null pointer we cannot check wether it is populated. Solve this by looking at the version (as 0 is not a valid x509 version).
* Fix another \(rightfull\) compiler warning iwth the version pointer
* Quell CI/CD runs on non-WiFi supporting hardare
* Quell CI/CD runs on non-WiFi supporting hardare
* Fix typo in directory name
* Apply suggestions from code review
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Rename Files
* Remove leftover file
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* feature: create a Trust on First Use example the quell the increasingly common copy & paste of the insecure approach making it to production
* Quell CI/CD runs on non-WiFi supporting hardare
* Update libraries/WiFiClientSecure/examples/WiFiClientInsecure/WiFiClientInsecure.ino
typo/improvement to text
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update libraries/WiFiClientSecure/examples/WiFiClientTrustOnFirstUse/WiFiClientTrustOnFirstUse.ino
typo/improvement to text
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update libraries/WiFiClientSecure/examples/WiFiClientTrustOnFirstUse/WiFiClientTrustOnFirstUse.ino
Fix formatting
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update libraries/WiFiClientSecure/examples/WiFiClientTrustOnFirstUse/WiFiClientTrustOnFirstUse.ino
typo/improvement to text
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update libraries/WiFiClientSecure/examples/WiFiClientTrustOnFirstUse/WiFiClientTrustOnFirstUse.ino
typo/improvement to text
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update libraries/WiFiClientSecure/examples/WiFiClientTrustOnFirstUse/WiFiClientTrustOnFirstUse.ino
typo/improvement to text
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update libraries/WiFiClientSecure/examples/WiFiClientTrustOnFirstUse/WiFiClientTrustOnFirstUse.ino
typo/improvement to text
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update libraries/WiFiClientSecure/examples/WiFiClientTrustOnFirstUse/WiFiClientTrustOnFirstUse.ino
typo/improvement to text
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Various things can all stop_ssl_socket() which sets the socket to -1; but the WiFiClientSecure checks for _connected. So we want to make sure the latter is always set. And thus have moved the state handling around *ssl_client down into the C code; below WiFiClientSecure.
* Unitialized NVRAM/EEPROM is actual set to 0xFF; so adjust for this. And print the LF/CR for the header lines.
* Update libraries/WiFiClientSecure/examples/WiFiClientTrustOnFirstUse/WiFiClientTrustOnFirstUse.ino
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Update Update.h
* Update Updater.cpp
* Add files via upload
* Add files via upload
* Add files via upload
* Update Update.h
* Update Updater.cpp
* Add files via upload
* Revert changes
* Revert changes
* Fix CI
* Fix format
* Skip H2
* Use new
* Fix comments and formatting
* Format example
* Remove binaries and QoL improvements
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Fix ESP32-Solo WDT on HTTP OTA update
* Fix ESP32-Solo WDT on HTTP OTA update
* Fix commits
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Proposal for fixing file webserver uploads via form upload.
The form parser has shown to have issues with files ending with "--\r\n". This commit replaces the form parser with the parser from ESP8266, which passes the test case.
* Replace _uploadReadByte() in WebServer/Parsing.cpp with ESP8266 implementation.
* OTA upload often fails when client.read() return -1 and we subsequently try to write 4 gigabytes to flash. Fixed by signed comparison and retry.
* Delay of 1ms already solves the issue
* Update libraries/ArduinoOTA/src/ArduinoOTA.cpp
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
---------
Co-authored-by: Leif <git@leif.lc>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Update Ticker API to compatibility with ESP8266, prepares for co-op loop Scheduler
* Fixing Build server complaints
* Fix omitted casts in template member function
* Changes after review
* Expose µs resolution of OS API in Ticker class
* Return Ticker to libraries only for modularity.
* Unify Ticker examples.
* Default for LED_BUILTIN
* In Ticker, the *scheduled functions become available in another development branch.
* Astyle from ESP8266
* Fixed Arduino keywords.txt
* 64bit integers instead of 32bits, timer functions on ESP32 accept 64bit integers.
* Move code from header into compiliation unit.
Reformat.
* Test case same as ESP8266
* Implementing inline in header saves 204+ bytes program size.
* Examples
* Fix a compiler warning due to c-style casting.
* Revert formatting changes
* More format reversions
* Revert
* Revert
* Revert
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* Fix ambiguous for TwoWire::requestFrom() methods.
* Remove TwoWire::begin(int) overload
Inside the function, this overload truncated the data type to a shorter one. This could break some users' hopes.
* Rewrite TwoWire with using HardwareI2C
- implement proposal https://github.com/espressif/arduino-esp32/pull/8818#issuecomment-1792191815
to bring the HARDWARE interface into compliance
* Fix TwoWire::end() return type.
* Fix TwoWire::setClock() return type.
* Fix no return statement in the TwoWire::requestFrom.
* fix(libraries/Wire): fix bad return-statement
Remove non-void values of the return-statements in function returning 'void'.
* style(libraries/Wire): replace tabs with spaces
* refactor(libraries/Wire): use slave without support
TwoWire::begin(uint8_t address) should be available without slave
support by SoC?
* refactor(libraries/Wire): remove unused variables
Compiler reports "Wire.cpp:393:15: error: variable 'err' set but not used [-Werror=unused-but-set-variable]".
* refactor(libraries/Wire): remove unused variables
Compiler reports "Wire.cpp:337:15: error: variable 'err' set but not used [-Werror=unused-but-set-variable]".
* fix(libraries/Wire): hide slave support elements
TwoWire::user_onRequest is used only in conjunction with slave support?
* refactor(libraries/Wire): remove temporary comment
* fix(libraries/Wire): restore an accidentally deleted implementation
TwoWire::endTransmission() was accidentally deleted from a cpp file.
* refactor(libraries/Wire): return return types
In TwoWire class return return types.
* fix(libraries/Wire): fix return type
* refactor(libraries/Wire): add return statement if slave isn't supported
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* refactor(libraries/Wire): fix indentation
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* refactor(libraries/Wire): fix indentation
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* refactor(libraries/Wire): fix indentation
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* refactor(libraries/Wire): remove unnecessary empty lines
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* feat(wifi): Improves WiFiMulti
* fix(wifi): Fixes Initialization of Security Mode
* feat(wifi): simplifies the example by using HTTPClient
* fix(WiFi): fixes a type in the commentaries
because print-to-all-clients is not implemented
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* feat(i2s): Add I2S examples
- ES8388 loopback example using the LyraT board
- ESP32-S3-EYE record WAV to SD card example
- Simple tone example
* docs(i2s): Add I2S API docs
* feature(spi): Allow detach of some SPI pins
* fix(spi): Remove unnecessary check
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
* feat(spi): Rename CS pin to SS to match Arduino standard
* fix(spi): Remove unnecessary checks
* remove lock from spiAttackMISO
---------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: me-no-dev <hristo@espressif.com>
* First stab ad simplyfing webserver auth and adding a handler.
* Tweaks after testing against docs and latest Library tree
* Add documentatin for callback handler
* Bodge to allow things to compile without the dependencies
* Remove dependency on sodium to make it compile with 4.4
* Fix hex conversion
* Move some common HEX functions into a static HEX class, remove those from MD5 and add some examples. This allows for the cleanup of various to/from HEX routines elsewhere.
* Remove some duplicated code
* Add simplfiied HEXBuilder under MD5Bulder to CMakefile.
* Update for 3.0.0 and QoL improvements
* Remove examples that depend on external libraries
* Skip H2 testing
* Formatting improvements
* Move builders examples to Utilities folder
* Fix indentation
* Add HashBuilder abstract class
* Add SHA1Builder
* Fix comment
* Fix whitespace
* Fix crashes and improve log messages
* Fix indentation for webserver
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
there may be other copy of WiFiClient working with that connection.
let shared_ptr stop the connection when it is not refered anymore.
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* IPv6 for Arduino 3.0.0
* Fix warning in WifiUdp
* remove comment / formating
* Add zone to IPAddress and update WiFiUDP and WiFiGeneric
* Add from ip_addr_t conversion and better toString implementation
* Use constant for IPAddress offset
@sgryphon is this better?
* Combine hostByName to support both IPv6 and IPv4 results
* implement logic to use v6 dns only when global v6 address is assigned and remove IPv6Address
* Rename softAPenableIPv6
* Rename mDNS methods
* fix IPAddress method to work with const address
* Some cleanup and do not print zone in IPAddress
* rename WiFiMulti method
* Fix AP DHCPS not properly working on recent IDF
* Add option to print the zone at the end of IPv6
@TD-er
* remove log prints from hostByName
* Use correct array length for listing IPv6 addresses
* Implement some Tasmota requirements
Added constructor that takes `const ip_addr_t *`.
Added `addr_type()` getter
Organize header to highlight the Espressif additions to IPAddress
* add 'const' to IPAddress::addr_type()
* Fix WiFiUdp not updating mapped v4 address
* Update WiFiServer.cpp
---------
Co-authored-by: Jason2866 <24528715+Jason2866@users.noreply.github.com>
Co-authored-by: s-hadinger <49731213+s-hadinger@users.noreply.github.com>
* Added Serial as RS485 interface demo
* Added more detail to initial comment
* Switched to UART_MODE definitions from uart_types.h in order to accomodate some versions of Arduino core
* Update libraries/ESP32/examples/Serial/RS485_Echo_Demo/RS485_Echo_Demo.ino
Co-authored-by: Lucas Saavedra Vaz <lucassvaz@yahoo.com.br>
* Update libraries/ESP32/examples/Serial/RS485_Echo_Demo/RS485_Echo_Demo.ino
Co-authored-by: Lucas Saavedra Vaz <lucassvaz@yahoo.com.br>
* Update libraries/ESP32/examples/Serial/RS485_Echo_Demo/RS485_Echo_Demo.ino
Co-authored-by: Lucas Saavedra Vaz <lucassvaz@yahoo.com.br>
* Removed HardwareSerial.h include. Switched RTS pin to GPIO 4 for broader compatability.
* using 115200 for UART0 - console
---------
Co-authored-by: Lucas Saavedra Vaz <lucassvaz@yahoo.com.br>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* DNSServer: switch to AsyncUDP instead of WiFiUDP
AsyncUDP offers event driven approch for handling udp dns req's
WiFiUDP hooks to loop() for packet processing and making useless malloc's each run
* DNSServer code refactoring
get rid of intermediate mem buffers and extra data copies,
most of the data could be referenced or copied from the source packet
- removed _buffer member
- replaced DNSQuestion.QName from uint8_t[] to char*
added sanity checks for mem bounds
optimize label/packet length calculations
other code cleanup
* DNSServer drop dynamically allocated member structs
DNSHeader and DNSQuestion structs could be created on stack
no need to keep it as obj members
* DNSServer: labels min length checks, simplified labels parser
* DNSServer use default settings for catch-all setup
- default constructor and start() method simply runs a catch-all DNS setup
- avoid string comparison for domain reqs in catch-all mode
- use IPaddress class for _resolvedIP (looking for IPv6 support in future)
* CaptivePortal example refactored
- use webserver instead of simple tcp setver
- use redirects to allows CaptivePortal detection pop-ups in modern systems
* DNSServer status getters added
add isUp() method - returns 'true' if server is up and UDP socket is listening for UDP req's
add isCaptive() method - returns 'true' if server runs in catch-all (captive portal mode)
some doxygen comments added
start() method now keeps existing IP address if any
---------
Co-authored-by: Lucas Saavedra Vaz <lucas.vaz@espressif.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* Removed virtual + moved socketOptions ot read/write
* Removed no needed code + edit
* removed Client::getTimeout
* removed setTimeout from WifiClient - read/write timeouts in constructor now
* Changed seconds to miliseconds in other classes relaed + examples
* Applied same changes for WifiClientSecure
* Added 0 init values to constructor
* Seconds are not rounded now
* removed +500 for previous rounding
+ unnecessary comments removed.
* fix rebased code in WifiClientSecure
* Fix rebased code
* Fix rebase code
* Create WiFiScanAsync.ino
* Create .skip.esp32h2
* Create README.md
* Update README.md - adds C6
* Update wifi.rst with new example
* avoid timeout with Async Mode
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
dns_gethostbyname, as used in hostByName, is required to run in lwIP's TCP/IP
context. This can be verified by enabling LWIP_CHECK_THREAD_SAFETY in the
sdkconfig.
Calling dns_gethostbyname from the Arduino task can trigger race conditions
in lwIP or lower layers. One possibility is a corruption of IDF's Ethernet
buffers, causing an unstoppable flood of "insufficient TX buffer size" errors,
effectively severing all Ethernet connectivity.
This patch makes sure to call dns_gethostbyname from lwIP's TCP/IP context.
* Compile error if CONFIG_FREERTOS_HZ != 1000
* add a check at the CMake level, per feedback
* fix a punctuation glitch
* Remove `_Static_assert` per feedback
* add documentation on threading issues with WiFi.onEvent()
* more comments
* thin out comments, add docs
* Update WiFiProv.ino merge conflict issue fixed
* Added the CLK type and MAC from eFuse to Ethernet begin
* Fixed the order and arguments on the Ethernet begin function
---------
Co-authored-by: Pedro Minatel <pedro.minatel@espressif.com>
Co-authored-by: Pedro Minatel <pminatel@gmail.com>
* Added USBMIDI support to libraries/USB
* Added MIDI examples to libraries/USB
* Added missing newline at end of file to MidiController.ino
* Added USBMIDI.cpp to CMake file
* Fix narrowing conversion warning in USBMIDI.cpp
* Fix incomplete initializers warning in USBMIDI.cpp
* Apply suggestions from code review
Co-authored-by: Lucas Saavedra Vaz <lucassvaz@yahoo.com.br>
* add skip files for C6+H2
* remove already patched workaroud for bug
* move #define to top of file
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: Lucas Saavedra Vaz <lucas.vaz@espressif.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: Lucas Saavedra Vaz <lucassvaz@yahoo.com.br>
1. Like a real keyboard, the USB interface descriptor will have an interface
subclass of boot and an interface protocol of keyboard. This will cause
some PC BIOS to send a SET PROTOCOL BOOT request to the device.
2. When the device sends reports to the host, if the host requested boot
protocol, don't send a report ID because boot protocol does not use report
IDs.
3. To work with some simple PC BIOS:
a. Use endpoint address of 1 for input and output.
b. Use separate reports for the shift key. These extra reports can be
disabled by calling USBHIDKeyboard::setShiftKeyReports(false).
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Update BLERemoteCharacteristic.cpp
Fix kernel panic issue when trying to release BLEClient when the target device have a ble descriptor.
* Update BLERemoteCharacteristic.cpp
Co-authored-by: Lucas Saavedra Vaz <lucassvaz@yahoo.com.br>
---------
Co-authored-by: Lucas Saavedra Vaz <lucas.vaz@espressif.com>
Co-authored-by: Lucas Saavedra Vaz <lucassvaz@yahoo.com.br>
Turns out that disabling the periman APIs from remap has a negligible
effect on the source: the core is already excluded from remapping, as
are most of the libraries. It's also expected to be a private API not
exposed by default.
This patch removes it from both esp32-hal.h and io_pin_remap.h,
adjusting the relevant libraries.
* Modified 'BLEAdvertising.h' & 'BLEAdvertising.cpp'
Added three methods for removing service UUID from BLEAdvertised
* Update BLEAdvertising.cpp
Changed 'i' to 'index'
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* esp32-hal-bt.c free Bluetooth LE memory if CONFIG_BTDM_CONTROLLER_MODE_BR_EDR_ONLY is set
BLE memory can be released if bluetooth-classic - only is requested
* tStart( add error output
* ble mem_release only for esp32
* disable BLE with BT_MODE define
* BluetoothSerial add begin()+disableBLE; add memrelease
* btStart with BT_MODE parameter
* beautification
* Update BluetoothSerial.cpp fix wrong merges
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* [pin_remap 1/3] platform: define ARDUINO_CORE_BUILD when building core files
* [pin_remap 2/3] core,libs: add pin remap hooks
* platform: remove previous build options if file is missing
"touch" would create the file if not present, but not delete its
contents if a previous run left the file in the build dir.
* platform: make debug_custom.json file customizable by board
* platform: fix default debug prefix
"debug.toolchain.prefix" must end with a dash, since only the tool name is
appended to this string.
The reason this is not a major issue is that the "debug_custom.json" file
(copied in the sketch directory when debugging is enabled) forces its own
prefix. And to make things more interesting, the "toolchainPrefix" entry
in that file should _not_ end with a dash.
* [pin_remap 3/3]: add Arduino Nano ESP32 board
* fix: periman: include it by default, add include guard
* fix: io_pin_remap: adjust for new perimap APIs
* fix: libraries: manually handled pin remapping files
Previously all libraries invoked either high-level APIs (transparently
remapped, like the user sketch) or low-level ESP-IDF calls (where the
remap to GPIO numbers had to be added manually).
Since 3.x, some of these are mixed (for example, periman* APIs are
remapped, while soc* are not). This must be handled by disabling the
automatic API remapping and making sure all calls use GPIO numbers.
* feat: show remapped pins in chip debug reports
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* Example sketch prints MAC for different interfaces
Interfaces described in documenation: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/system/misc_system_api.html#mac-address
* Update README.md to include 'MacAddress'
* Add files via upload
* Delete libraries/ESP32/examples/MacAddress/GetMacAddress.ino
* Delete libraries/ESP32/examples/MacAddress/GetMacAddress/GetMacAddress.ino
* Delete libraries/ESP32/examples/MacAddress/GetMacAddress/MacAddress directory
* Add files via upload
* Add files via upload
* Adds necessary MAC header file
* Reverting - moving to the sketch
* Adds include with esp_mac_type_t values
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Update WiFiClient.h
Added missing getSocketOption() with full access to level and option
* Update WiFiClient.h
* Handle timeout settings below 1 second
Fix error with connect timeout settings below 1000ms.
Add getsocketoptions function.
* Add cast for setsockopt length
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* Added Bandwith setting method
* Separted AP and STA on it's own class each
* Missing WiFi
* Rename for consistency
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
esp8266 and esp32 server.available() is not implemented as documented
it is implemented like server.accept() is documented by Arduino
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Extended bus types for peripheral manager
* add extra_type to peripheral manager
* Fix function call
* Fix check for no extra_type
* Add extra_type for SD and ETH CS pin
* added bus_num and bus_channel to pin structure
* update printPerimanInfo with new fields
* replaced setting bus to INIT with DetachPin call
* add defines for extra attributes
* use new required parameters in perimanSetPinBus
* function rename
* removed duplicate define
* Update print format
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
to change initial WiFi.status() because WL_NO_SHIELD
is checked in any generic Arduino WiFi example
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* IDF release/v5.1 b6a66b7d8c
* Fix CI - RMakerCustomAirCooler.ino
No use of `#include "led_strip.h"` in the code
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Update/upgrade OTAWebUpdater.ino example
* Wrong side of the MAC address in ssid
* Better not to cheat it on an example :)
* Changes requested by @me-no-dev
* improve neopixel definition for all boards
* Improve NeoPixel definition for all boards
* neopixelWrite uses Peirpheral Manager now
The function can now be used for many GPIOs in the same sketch by using Peripheral Manager attach/detach, not being necesary to worry about initialization.
* improve error message
* check if pin is RGB_BUILTIN
* fixes boards that don't RGB_BUILTIN
* Uses IDF Managed Components
This changes is targeted to be used within Arduino Lib Builder and with projects that use Arduino as IDF Component.
* Fixes RainMaker QR code
Fixes RainMaker in order to use it as Managed Component and with the latest RainMaker release.
* Removes Camera Component
* SR Component only needed for the S3
* Serial as a #define
* Typo
* fixes USBCDC declaration
* Fixes Examples
* simplifies examples
* Adds USB Serial Events
* adds error msg when ESP32 is used with USB
* [I2S][SR] Add new I2S library and Sound Recognition support
* periman + TDM and PDM support
* separated init function + default values for pins
* fix SR example
* fix init functions
* remove old I2S from CmakeList
* Add ESP_I2S and ESP_SR to Cmakelist includedirs
* TDM slot_mask fix
* Peripheral manager pin check fix
* Compile ESP_SR Arduino code only if ESP-SR is available as component
* Guard I2S modes, depending on what is supported by the chip
* add check if i2s is supported
* Remove old I2S Example
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Fix memory leak and undefined behavour in Updater #7984
* Update error message
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Update error message
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* Adds Analog Continuous mode API
* fix when stopping/starting ADC data are not complete
* Added example
* fix size check
* update frequency in example
* set buffer to NULL if error occurs
* add docs
* set buffer to null on error
* fix example
* update docs
* fix example
* change return value to bool type
* updated adc modes description in docs
* Add empty line at the end of sketch
* Initial changes to compile under ESP-IDF v5.1
* Initial import for ESP-IDF v5.1 libs
* Update toolchain
* Update esp32-hal-psram.c
* Add missing LDs
* Update platform.txt
* Stop some CI jobs, because they will always fail
* Fix examples
* Update app_httpd.cpp
* Update ResetReason.ino
* Warnings fixes
* Added the example guideline and template (#7665)
* Added the example guideline and template
* PR review changes with some typos and grammar fixes
* Changes according to the PR review
* Added ESP32-S3 link to the datasheet (#7738)
* Update HiFreq_ADC.ino
* Replace periph_ctrl.h use because of deprecation
* Replace esp_spi_flash.h use because of deprecation
* Add includes to male mDNS::enableWorkstation compile
* Fix ssl_client mbedtls_pk_parse_key callback
* Update temperature sensor driver
* Allow sketch_utils to compile with arduino-cli
* Run CI with arduino-cli
* Fix arduino-cli CI build on Windows
* Refactor platform.txt to not use components installed through the board manager when running from git
* Initial Peripheral Manager Implementation
* Update SigmaDelta driver to use the new ESP-IDF driver API
* Small improvements to peripheral manager and SigmaDelta
* Remove deleted function from SigmaDelta header
* Update DAC driver to use the new ESP-IDF driver API
* Adds softAp(String) to make it compatible with ESP8266 (#7801)
* Fix commentary (#7800)
Minor fix based on observation done in https://github.com/espressif/arduino-esp32/issues/7795#issuecomment-1416868611
* add adafruit new board feather esp32s2 reserve tft (#7794)
* bugfix: add <stdint.h> for uint8_t to avoid compilation failure (GCC 11.2.0) (#7744)
* Adding 3rd party boards for VALTRACK-V4-VTS-ESP32-C3 & VALTRACK-V4-MFW-ESP32-C3 (#7735)
* Added VALTRACK-V4-VTS-ESP32-C3 board definition
Created pins_arduino.h & made changes to boards.txt with necessary changes
* Modified the URL
* Renamed json
* renamed all auRL
* Adding VALTRACK-V4 series board definitions
Added VALTRACK-V4-VTS-ESP32C3 & VALTRACK-V4-MFW-ESP32-C3 board variants
* Adding VALTRACK-V4 series board definitions
Added VALTRACK-V4-VTS-ESP32C3 & VALTRACK-V4-MFW-ESP32-C3 board variants
* Reverted package_esp32_index.template.json
restored package_esp32_index.template.json from edits
* Reverted package_esp32_index.template.json
Added new line to package_esp32_index.template.json
* Update Platformio CI (#7725)
* WiFiClient example fix (#7711)
* Modified WiFiClient example to use thingspeak instead of non-functionig sparkfun
* Moved instructions to README
* Fixed spelling
* Added link to S3 datasheet
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Mirror update from Heltec repository (#7709)
Heltec updated the I2C pins in b10f4bf85d
* Fixes BLE data printing (#7699)
* Fixes BLE data printing
BLE data has no '\0' terminator, therefore it can't be printed as a regular C string.
This fix just prints the BLE data based on its length.
* Simplify printing to a single call
* split menu options + lora_32_V3 fix (#7697)
* Change header gaurd name (#7696)
* Fix Name (#7691)
Wrong name in definitions.
* Fix error in WiFiClient.cpp where the connect function fails for timeouts below 1 second (#7686)
* Update WiFiClient.cpp
This change will allow specifying connect timeouts below 1 second. Without this change, if connect timeouts under 1 second are given, the connect defaults to 0ms and fails.
This will also allow timeouts in fractions of seconds, e.g. 1500ms. Without this change, connect timeouts are truncated to full second increments.
* Make parameter timeout_ms clear
* Change connection timeout_ms name for clarity
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* fixed the function header (#7674)
* fixed the function header
* fixed function name and paramaters
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Ticker fix solving #6155 (#7664)
* Wrapped Ticker functions with #pragma disabling -Wcast-function-type
* Revert "Wrapped Ticker functions with #pragma disabling -Wcast-function-type"
This reverts commit 160be7e67a10d01b6e44c4bf2521c0ccd6348976.
* Fixed Ticker example
* Modified Ticker example
* Fixed LED_BUILTIN err for ESP32
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* setPins fix ESP32 "specified pins are not supported by this chip." (#7646)
[ESP32: SDMMCFS::begin hardcodes the usage of slot 1, only check if the pins match slot 1 pins.]
setPins() was testing pins D1, D2 and D3 all against D1 ... fine in 1 pin mode when all are -1 not so much if you're trying to get 4 pin mode working.
I now see this function doesn't really do anything on the ESP32...accept now correctly checks that you are trying to use the slot 1 pins.
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Allow passing IP as connect method parameter in WiFiClientSecure and skip unnecessary host-ip conversions (#7643)
* Add LED_BUILTIN* definitions and initialization for LEDs to stop them floating. (#7636)
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Expand path to tinuf2 image when checking existence in platformio-build.py (#7631)
* Expand path to tinuf2 image when checking existence
* More isFiles fixed
* Remove (useless) trailing semicolon from Print.cpp (#7622)
* ADD: New variant Edgebox-ESP-100 (#7771)
* ADD: New variant Edgebox-ESP-100
* FIX: Edgebox-ESP-100 Board.txt usb mode option change back to default value as ESP32S3
* Add Crabik Slot ESP32-S3 board (#7790)
* Added Crabik Slot ESP32-S3
* Adding CPU frequency settings and removing excess from partition scheme settings
* new variant LilyGO T-Display-S3 (#7763)
* new variant LilyGO T-Display-S3
https://github.com/Xinyuan-LilyGO/T-Display-S3
* Add boards.txt definition
---------
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* Update get.py to support Apple ARM64
* Update package_esp32_index.template.json
* WString Return bool (#7774)
* Add Roboheart Hercules development board to the esp32-core (#7672)
* added Roboheart Hercules pin definitions and board.txt entries
* added package_roboheat.json for prototyping
* Roboheart Hercules pins
* Updated the pins
* Delete package_roboheart.json
* Requested changes
---------
Co-authored-by: renebohne <rene.bohne@gmail.com>
* Reword "ESP-IDF as Component" (#7812)
I think "Arduino as an ESP-IDF component" or just "As ESP-IDF component" instead of "ESP-IDF as Component" is more correct way to name the link.
1. "ESP-IDF as Component" would imply that ESP-IDF is some sort of library for Arduino, which is (IMO) misleading, because it's true the other way around.
2. It's written as "Arduino as an ESP-IDF component" on the webpage it points to as well.
- Also I removed the capitalization from "Component" as I have not found a reason why is it capitalized.
* add new board Adafruit Feather ESP32-S3 Reverse TFT (#7811)
* Multi threading examples (tasks, queues, semaphores, mutexes) (#7660)
* Moved and renamed example ESP32/FreeRTOS to MultiThreading/BasicMultiThreading
* Added dummy files
* Modified original example
* Fixed BasicMultiThreading.ino
* Added Example demonstrating use of queues
* Extended info in BasicMultiThreading
* Renamed Queues to singular Queue
* Added Mutex example
* Added Semaphore example
* Moved info from example to README
* Moved doc from Mutex to README
* Added Queue README
* Removed unecesary text
* Fixed grammar
* Increased stack size for Sempahore example
* Added headers into .ino files
* Added word Example at the end of title in README
* removed unused line
* Added forgotten README
* Modified BasicMultiThreading example
* Added missing S3 entry in README
* moved location
* Update ESP-IDF libs
* Update CMakeLists.txt
* Update esptool to v4.4
* Add function timerAttachInterruptFlag (#7809)
* Update esptool to v4.5
* ADC refactoring (#7827)
* Adc refactored + periman implementation
Peripheral manager still needs to be checked if the implementation is right.
* switched to working solution for milivolts read
* Periman detachbus fix
* coding style
* fix CI warnings
* fix FreeRTOS example
* Update ETH.cpp
* Update FunctionalInterruptStruct.ino
* Update package_esp32_index.template.json
* Update package_esp32_index.template.json
* Fixes for the latest IDF v5.1
* update esp-idf libs and toolchain
* Turn OFF auto crystal frequency for ESP32 (needed by TWAI)
* Update examples
* Switch build to mostly use flags from files
Includes can not be done this way
* Reorganize flag files
* Optimize chip build flags further
* Revert defines from file. MBEDTLS_CONFIG_FILE does not properly expand
* Add support for includes and defines from file
* Replace old sdk path references in platform.txt
* use gcc-ar (#8013)
* Makes F_CPU generic for all SoC (#8007)
Based on CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ that is correctly defined in the sdkconfig file for each SoC.
* TIMER refactoring (#7904)
* refactor using GPtimer
* Updated timer HW test
* fix examples
* Add v2.0.7 in issue template (#7871)
* refactor using GPtimer
* Updated timer HW test
* fix examples
* Revert "Add v2.0.7 in issue template (#7871)"
This reverts commit fcc3b17d62ff57861f8913ca1f142fd5163b7457.
* Update upload-artifact to v3 in HW CI
* Revert "Update upload-artifact to v3 in HW CI"
This reverts commit 1ba228071718ba37c4e26d98db22f77b2a7364a6.
* replace resolution with frequency
* remove count_down option
* countup removed from examples + header
* Refactored timer object
* code cleanup + examples and tests fixes
* TimerAlarm fix
---------
Co-authored-by: Vojtěch Bartoška <76958047+VojtechBartoska@users.noreply.github.com>
* [Docs] ADC and Timer API Update (+some docs fixes) (#7906)
* updated docs
* remove hall sensor docs
Removed Hall sensor documentation as its no longer supported in IDF-5
* Fixed ESPNow examples location in docs
* Last timer refactored API + gpio small fix
* AlarmWrite fix
* Fixes APLL/PLL with RTC Frequency (#8025)
log_d() was displaying APLL for any SoC, but S3 and C3 has not such option, causing compilation errors.
* Update IDF libs and fix OPI PSRAM on S3
* Add setMode function HardwareSerial.c to set the esp32 uart mode for use with RS485 auto RTS (#7935)
* Added setMode function to set the esp32 uart mode
Used to set the esp32 uart mode for use with RS485 Half Duplex and the auto RTS pin mode. This will set/clear the RTS pin output to control the RE/DE pin on most RS485 chips.
* Add Success (bool) return in some functions
* Add Success (bool) return code to some functions
* Add Success (bool) return to some functions
* Add Success (bool) return to some functions
* Fix uartSetRxTimeout return type
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Add support for esp-elf-gdb
* WFG Crashfix (#8044)
* Update component libs
* IDF release/v5.1 (#8061)
* IDF release/v5.1 bb9200acec
* Update Esp.cpp
* IDF release/v5.1 420ebd208a
* Update esp32-hal-psram.c
* Switch SDK to be an external package
* fix path (#8096)
* Makes UART work at any APB Frequency (#8097)
Fixes HardwareSerial to work with IDF 5.1 on any CPU/APB Frequency (240MHz to 10MHZ), including user created low power modes.
* Add required callbacks for TinyUSB DFU
* Update version to 3.0.0
* Add ESP.getCoreVersion() and update ESP.getChipModel()
* Update timer hal for the latest 5.1
* Use separate RX and TX buffer sizes in HTTP client
optimizes download by allowing up to 4K packets to be received
* Rename clock tree enum name in latest 5.1
* ESP32-H4 support was removed in ESP-IDF v5.1
* IDF release/v5.1 2004bf4e11 (#8165)
* Deinit previous bus first (#8180)
* TIMER - add timer_started flag, fix timerEnd() + timer HW test (#8135)
* Add timer_started flag and stop before disable
* Fix timer HW test
* TOUCH - Peripheral manager implementation (#8129)
* Touch periman implemented
* Deinit previous bus first
* LEDC Refactoring - Peripheral manager implemented (#8126)
* LEDC periman implementation
* Fix examples
* Rework tone
* Update ledc docs
* fix missing bracket
* Update analog funtions esp32-hal.h
* Update CameraWebServer example
* Fix HiFreq_ADC example
* minor fixes - typos
* Avoid calling tone/notone when tone already runs on dif. pin
* Remove unused channels_resolution
* GPIO - Peripheral manager implementation (#8179)
* periman-implementation
* fix RGB_BUILTIN and remove space
* Enforces more consistency into Peripheral Manager (#8188)
* Avoid log_i() message the first time a bus is assigned
* Prevent operation with ESP32_BUS_TYPE_INIT
* keeps coding style
* do not print messages on INIT bus type
* [Arduino Core 3.0.0] RMT IDF5.1 Refactoring (#7994)
* RMT IDF5.1 refactoring
* Fixes initial value setting
* removed rmtRead() with user callback
* simplify/remove Read data structure
* Deep API simplification
* fixes the examples
* fix rmt.h
* adds support to APB different frequencies
* fixes CI and not defined RGB_BUILTIN
* new RMT API and examples
* fixing commentaties
* Update esp32-hal-rgb-led.c
* changes Filter API
* Fixes example with Filter API
* Update PlatformIO scripts for the upcoming 3.0 core (#8183)
* Update PlatformIO scripts for the upcoming 3.0 core
* Dynamically select proper framework-arduinoespressif32-libs package
With this change the dev-platform will be dynamically configured to
pull the latest .zip package with precompiled libraries from extracted from
package_esp32_index.template.json
* free memory on detach (#8264)
* SPI - Peripheral manager implementation (#8255)
* spi periman implementation
* fix header file
* remove unused struct
* fix missing braces
* Update esp32-hal-rmt.c (#8216)
Optimizing Peripheral Manager Test
* I2C - Peripheral manager implementation (#8220)
* i2c-master periman initial commit
* i2c-master make detachbus static + comment remove
* i2c-slave periman implementation
* SetPinBus to INIT on i2cDeinits
* Fix slave pins deinit
* remove dbg logs
* set ret to ESP_FAIL instead of returning
* Fix warnings in hal-spi caused by pariman transition
* Update esptool.py to version 4.6
* Add platform support for ESP_SR
* Add USB Type and valid pin check to periman
* replace bus with spi->num+1 (#8279)
* Remove default pins from SPI HAL
* Add commented out handlers for esptool.js in TinyUSB CDC
For future use
* Add build defines for host os and fqbn (for debug purposes)
* Provide proper memory caps total size
* Update Esp.cpp
* SDMMC - Peripheral manager implementation (#8289)
* sdmmc periman implemented
* save pins when SOC_SDMMC_USE_IOMUX
* IDF release/v5.1 4bc762621d (#8292)
* Adds missing pinMode (#8312)
* Adds missing pinMode
The example code lacks a pinMode() to initialize the GPIO 0 (button). In Arduino Core 3.0.0, it prints an error message when trying to read a not initialized GPIO.
* Update KeyboardLogout.ino
Adds <buttonPin> to keep code standard
* Update KeyboardReprogram.ino
Adds <buttonPin> to keep code standard
* LEDC Fade implementation (#8338)
* fade API + pointer fixes
* Add fade api
* Add fade example
* update ledc docs
* remove unused variables
* fix path to example
* Adds USB to Peripheral Manager - Arduino Core 3.0.0 (#8335)
* ETHERNET - Peripheral manager implementation (#8297)
* Peripheral manager implemented
* remove unused variable
* Add all RMII pins
* fix typo
* Adds HardwareSerial to Peripheral Manager Arduino 3.0.0 (#8328)
* Do not limit ETHERNET in periman to only ESP32. SPI is also an option
* Initial support for ESP32-C6 (#8337)
* Add checks for SOC defines (#8351)
* Add checks for SOC defines
* Add SoC checks to BLE library
* fix i2c compilation error
* fix wrong placement of include
* add check to SPI library
* add check to USB library
* add checks to Wire library
* Feature/esp32h2 support (#8373)
* Initial support for ESP32H2
* Additional changes for ESP32H2
* Update libs for ESP32H2
* Fix flashing on ESP32-H2
* Fix GPIO Configs for ESP32-C6 and ESP32-H2
* Update Timer test sketch
* Fix upload flash parameters
* Use ets_write_char_uart instead of ets_printf in log_printfv
* Print full chip report when log level is sufficient (#8282)
* ESP32-C3 does not have ets_write_char_uart
* Fix BLE gap event name
* HW Testing - Pytest update (#8389)
* update tests requirements
* remove already handled components
* Update version of pytest
* Add missing ESP32-H2 to hil.yml
* Updated FreeRTOS names (#8418)
* HW Testing - ESP32-C6 + ESP32-H2 fixes (#8404)
* add C6/H2 to tests cfg.json
* remove ,
* workflow runs-on runner by matrix
* Add need for arduino tag to select runner
* Add cryptography to requirements.txt
* Removed duplicate TX1 define for H2 (#8402)
* Fix broken examples
* Fixes RMT filter & idle timing and setup (#8359)
* Fixes Filter and Idle parameter to uint32
* Fixes Filter and Idle setup
* Fixes it to 5.1Libs branch
* fix RMT CLK source and Filter API
* fixes missing ;
* fixes missing ;
* fixes RMT example
* IDF release/v5.1 a7b62bbcaf (#8438)
* Add workflow to build executables from python scripts (#8290)
* Add workflow to build executables from python scripts
* Push binary to tools
* Enable executable signing on Windows
* Update get.py
* Push binary to tools
* Try with multiple files
* Try more actions
* Try powershell
* Restore tools so they do not get rebuilt
* Finalize scripts
* Push binary to tools
* App rollback should be after PSRAM is initialized
* Correcting RX1 to GPIO4 and TX1 to GPIO5 to be consistent with documentation. Previous pin use works but is inconsistent with C6 docs.
* Fixes Memory Leak (#8486)
* fixes preprocessor test (#8485)
* fixes preprocessor test
When using `#define USE_SOFT_AP`
Change
`&& not USE_SOFT_AP` ==> `&& !defined(USE_SOFT_AP)`
* Adds any BLE capable device in WiFiProv.ino
Removing ESP32 restriction for BLE Provisioning.
* fix flash mode read out for C6
* Add option for custom partitions without restrictions
* SD_MMC update (#8298)
* Updated SD_MMC lib and examples
* Removed getter implementation and commented usage in examples
* squashed updates
* IDF release/v5.1 f0437b945f (#8599)
* Update package_esp32_index.template.json
* Fix printf format build error in BTAdvertisedDeviceSet.cpp
---------
Co-authored-by: Pedro Minatel <pedro.minatel@espressif.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: Ha Thach <thach@tinyusb.org>
Co-authored-by: Martin Turski <quiret@vfemail.net>
Co-authored-by: raviypujar <raviypujar@gmail.com>
Co-authored-by: Jason2866 <24528715+Jason2866@users.noreply.github.com>
Co-authored-by: Tomáš Pilný <34927466+PilnyTomas@users.noreply.github.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: Daniel Berlin <dberlin@dberlin.org>
Co-authored-by: Nima Askari (نیما عسکری) <nimaltd@yahoo.com>
Co-authored-by: rtpmsys <106180646+rtpmsys@users.noreply.github.com>
Co-authored-by: bytiful <55647551+bytiful@users.noreply.github.com>
Co-authored-by: tmfarrington <tmfarrington@users.noreply.github.com>
Co-authored-by: Krzysiek S <chris.streh@gmail.com>
Co-authored-by: surt <carl.olsson@gmail.com>
Co-authored-by: Max Scheffler <max.scheffler@pm.me>
Co-authored-by: Clemens Kirchgatterer <clemens@1541.org>
Co-authored-by: Peter Pan's Techland <twinkle-pirate@hotmail.com>
Co-authored-by: Roman <programmeofficemilkyway@gmail.com>
Co-authored-by: Eistee <Eistee82@users.noreply.github.com>
Co-authored-by: David McCurley <44048235+mrengineer7777@users.noreply.github.com>
Co-authored-by: Gaya3N25 <30388176+Gaya3N25@users.noreply.github.com>
Co-authored-by: renebohne <rene.bohne@gmail.com>
Co-authored-by: Olivér Remény <25034625+remenyo@users.noreply.github.com>
Co-authored-by: davidk88 <david.kotar@gmail.com>
Co-authored-by: Vojtěch Bartoška <76958047+VojtechBartoska@users.noreply.github.com>
Co-authored-by: James Armstrong <jamesarmstrong3@me.com>
Co-authored-by: Valerii Koval <valeros@users.noreply.github.com>
Co-authored-by: Peter G. Jensen <root@petergjoel.dk>
* Updated preferences.rst
* Added into FAQ info about SPIFFS failed mount
* Updated troubleshooting
* Moved SPIFFS paragraph from FAQ to troubleshooting
* Minor updates
* Updated troubleshooting
* Updated SD README files and example comments
* Updated troubleshooting with SD issue
* Added note about S3 pins
* Updated SDMMC test setPins calls + added definition for default pins
* Updated SD_MMC comments
* Added pin table to SD_MMC readme
* Updated table in SD_SPI
* Updated based on comments
* Update io_mux.rst
* Update README.md
In WiFiSTA you can ask for the subnet mask, but not in WiFiAP.
Only the CIDR is reported.
Therefor the missing method is added to have the same features in softAP as well.
This PR fixes an issue of multiple device callbacks (one callback per device) were not getting registered and invoked.
Consider an example where I create two devices, a switch and a fan; each of them having their own write callbacks. On controlling either switch/fan through Rainmaker app, the callback that got registered at last gets invoked. This is also seen in the issue reported in #8231
Resolves deprecation warnings in CameraWebServer.ino. pin_sscb_sda -> pin_sccb_sda. pin_sscb_scl -> pin_sccb_scl.
The variables are in the same union and are identical.
* Makes sure it can be tested with Windows 10/11
Initial code had no effect with Win10/11 because BUTTON_START was not recognized.
This change makes it visible in the Windows Game Controller Testing TAB.
* Examples tests all USB gamepad APIs.
It is possible to change the selected gamepad button when pressing BOOT (long/short press).
The selected button is used as parameter to change R/L Stick and Trigger as well as the Hat.
* Remove __FlashStringHelper from ESP32, it's not needed - all the files using it are different from their ESP8266 counterparts anyway.
* Revert removal of class __FlashStringHelper forward for continued compatibility with external libs
* Improved fix, works for libs that return const __FlashStringHelper*
* Inline all wrappers using const __FlashStringHelper*.
* new variant Seeed XIAO_ESP32S3
* add pin define for camera example
* Remove excess comments and fix minor errors
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Changed data type of temperature
* Changed data type in EddystoneTLM class and example
* Revert "Changed data type in EddystoneTLM class and example"
This reverts commit 1f3a9414ee13341f80bd6d51cdbd57254aadfe97.
* Draft of Eddystone TLM example
* Adds MACROs to convert beacon temperature
2 Macros
EDDYSTONE_TEMP_U16_TO_FLOAT(tempU16) - takes the TLM BigEndian 8.8 fixed point representation and returns its float value
EDDYSTONE_TEMP_FLOAT_TO_U16(tempFloat) - takes a float (temperature) and returns its BigEndian 8.8 fixed point representation
* Fixed temp
* Changed to conform with PR comments
* Fixed comment on closing bracket
* Prints negative TEMP big endian as just 2 bytes
* Extacts correct Eddyston Service Data
* Fixes BLEEddystoneTLM::toString() negative temp
* Fixes URL field length
* Fixes Eddystone URL decoding
* Fixes MSB for iBeacon UUID
iBeacons use big endian BLE fields.
* Fix to detect iBeacon that also has Service UUID
This fix makes the BLE_iBeacon.ino to work correctly with the BLE_Beacon_Scanner.ino example
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Remove inline code comments for the struct description
* Renamed ESPNow examples
* Changed example from C++ class to C struct
* Updated MultiHomedServers
* Updated BT Serial examples
* Added short overview of exaples - missing Enterprise
* Added draft of Enterprise header note
* Fixed note in README
* Fixed compilation error
* Changed FunctionalInterrupt example
* Fixes
* Returned FunctionalInterrupts to original state + added modified version as new example
* Added methods + example to retrive local MAC for BT
* Added .skip files in the new example folder
* Fixed typos and formatting + added doxygen comments
* changed std::string to String
* another std::string -> String
* Changed std::string to String
* chaged string type in example
* Moved and renamed example ESP32/FreeRTOS to MultiThreading/BasicMultiThreading
* Added dummy files
* Modified original example
* Fixed BasicMultiThreading.ino
* Added Example demonstrating use of queues
* Extended info in BasicMultiThreading
* Renamed Queues to singular Queue
* Added Mutex example
* Added Semaphore example
* Moved info from example to README
* Moved doc from Mutex to README
* Added Queue README
* Removed unecesary text
* Fixed grammar
* Increased stack size for Sempahore example
* Added headers into .ino files
* Added word Example at the end of title in README
* removed unused line
* Added forgotten README
* Modified BasicMultiThreading example
* Added missing S3 entry in README
* moved location
[ESP32: SDMMCFS::begin hardcodes the usage of slot 1, only check if the pins match slot 1 pins.]
setPins() was testing pins D1, D2 and D3 all against D1 ... fine in 1 pin mode when all are -1 not so much if you're trying to get 4 pin mode working.
I now see this function doesn't really do anything on the ESP32...accept now correctly checks that you are trying to use the slot 1 pins.
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Update WiFiClient.cpp
This change will allow specifying connect timeouts below 1 second. Without this change, if connect timeouts under 1 second are given, the connect defaults to 0ms and fails.
This will also allow timeouts in fractions of seconds, e.g. 1500ms. Without this change, connect timeouts are truncated to full second increments.
* Make parameter timeout_ms clear
* Change connection timeout_ms name for clarity
---------
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Fixes BLE data printing
BLE data has no '\0' terminator, therefore it can't be printed as a regular C string.
This fix just prints the BLE data based on its length.
* Simplify printing to a single call
* Modified WiFiClient example to use thingspeak instead of non-functionig sparkfun
* Moved instructions to README
* Fixed spelling
* Added link to S3 datasheet
---------
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Fixed issue where esp32 won't reconnect to WiFi AP if the AP was restarted
* Added the autoReconnect condition and removed the reconnect reason
* Chenges on the WiFi reconnection and added new example
* Added new line at the end
* Changes reverted with some minor changes. New example remained
* Changes reverted and sync
Co-authored-by: pedro.minatel <pedro.minatel@espressif.com>
* ESP Insights: Added library support
* ESP Insights: Added Examples
* ESP Insights: Added custom partitions file
* ESP Insights: Added API documentation.
* Added recipe and script to create Insights package
* Updated ESP Insights examples.
* Changed Insights Firmware package output directory
* Changed license to include SPDX license
* Fix Insights package for Windows
* Updated .exe of insights script
* Added coredump partition to all schemes
* Updated header files of Insights diagnostics
* hotfix: Added elf-sha256-offset flag in elf2bin
builder
* Update API to be more Arduino-like and partitions offsets
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
* adds extended HardwareSerial examples
* Adds new example with Serial RxTimeout
* adds and improves Serial onReceive expamples
* adjust includes CMake - UART example
* adjust includes CMake - UART example
* fixes CMake and CI
* adds ESP/Serial to CMakeList
* adds ESP/Serial to CMakeList
* fixes demo include
* fixes BREAK demo
* fixes onReceive demo
* Changes FIFO Full criteria
Changed the "1-by-1" Serial only when baud rate is 57600 or lower.
* example code replacement
* replaces functions in hal
* Update `WiFiScan` example to show more useful data
* Add channel to output.
* Add type of encryption to output.
* Format output as table.
* Update outdated example description.
* Add `scanDelete()` as hint to free memory.
* added 32 chars SSID + readme edit
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* replaced original iBeacon example with a known-good one
* addressed VojtechBartoska's comment
* incorporated P-R-O-C-H-Y's change
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* refactor(toString method): Add RSSI / serviceData
These are key characteristics of the BLE advertising packet. Really useful, adding to this method allows data to be easily obtained and passed over TCP/IP for processing.
* fix: remove line 565 bug
Currently, if a second connection occur in Bluetooth, this second connection is automatically disconnected (line 284).
This disconnection trigger the ESP_SPP_CLOSE_EVT, which clear the bit SPP_CONNECTED.
But the first connection remain active, and this flag shouldn't be cleared.
This fix the issue, by clearing the flag only if the last connection is closed
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
This commit addes an example showing how to receive messages using the TWAI
driver interface and a CAN transceiver. Specifically, the example demonstrates:
- How to configure and install the TWAI drvier
- How to poll for TWAI events (i.e., alerts) using twai_read_alerts()
- How to handle the various events (such as TWAI_ALERT_RX_DATA)
Closes https://github.com/espressif/arduino-esp32/pull/7430
Co-authored-by: Stephan Martin <designer2k2@gmail.com>
* Added enableScenes API
* Added enableScenes API documentation
* Added enableScenes API to example
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Fixed#7406 . The "reason2str" macro in WiFiGeneric.cpp tries to read memory from index "-1" in "system_event_reasons" array when handling STA_DISCONNECTED event with reason 0. Dealing with reason 0 as a reason 1 (WIFI_REASON_UNSPECIFIED) will solve the problem (the reason for this event to arrive with reason 0 is unknown). #7406
The original code assumes 100Hz FreeRTOS tick rate and just supplies vTaskDelay with the assumed number of ticks required for the wanted delay. This patch simply fixes it to use portTICK_PERIOD_MS, thereby working correctly regardless of what tick rate FreeRTOS has been configured to run at.
The HID semaphore allows USBHID::SendReport() to wait for the completion of
report sending.
With a zero timeout xSemaphoreTake() after calling tud_hid_n_report(),
occasionally, the following would happening:
1. USBHID::SendReport() would send a report by calling tud_hid_n_report().
2. The send would complete and (presumably on another thread)
tud_hid_report_complete_cb() would be called and it would xSemaphoreGive()
the semaphore.
3. In USBHID::SendReport(), the zero timeout xSemaphoreTake(sem, 0) would
succeed, taking the semaphore.
4. On the next line, xSemaphoreTake(sem, timeout_ms ...) would timeout
because the semaphore was already taken by the previous line of code.
The result would be waiting timeout_ms for no reason.
The purpose of the zero timeout xSemaphoreTake() is to clear the semaphore in
case a previous SendReport() timed out waiting for the semaphore. In that case,
tud_hid_report_complete_cb() may be called after the timeout, giving the
semaphore. Then the next SendReport() would start with the semaphore given,
which isn't desired if we want to call xSemaphoreTake(sem, timeout_ms ...) on
it.
There have also been other cases where tud_hid_report_complete_cb() is called
an extra time, causing the same situation.
The fix is to move the zero timeout xSemaphoreTake() before the call to
tud_hid_n_report(). This eliminates the race between the zero timeout
xSemaphoreTake() and tud_hid_report_complete_cb() in the common case when no
timeout occurs.
There is still a possible race condition between the zero timeout
xSemaphoreTake() and tud_hid_report_complete_cb() in the case of a timeout,
but that should be rarer.
Arduino-esp32 2.0.4 was released with a version of TinyUSB hid_device.h
that uses uint16_t for the last argument:
https://github.com/espressif/arduino-esp32/blob/2.0.4/tools/sdk/esp32s2/include/arduino_tinyusb/tinyusb/src/class/hid/hid_device.h
TU_ATTR_WEAK void tud_hid_report_complete_cb(uint8_t instance, uint8_t const* report, uint16_t len);
But USBHID implements this callback with uint8_t:
https://github.com/espressif/arduino-esp32/blob/2.0.4/libraries/USB/src/USBHID.cpp
void tud_hid_report_complete_cb(uint8_t instance, uint8_t const* report, uint8_t len){
if (tinyusb_hid_device_input_sem) {
xSemaphoreGive(tinyusb_hid_device_input_sem);
}
}
The result is that when USBHIDKeyboard sends a report to the host, it
times out, waiting 100 ms for the callback to be called. It does this
once for pressing the key and once for releasing the key, so
100 ms * 2 = 200 ms.
The latest version of hid_device.h reverts the last argument to uint8_t:
860b104691/tools/sdk/esp32s2/include/arduino_tinyusb/tinyusb/src/class/hid/hid_device.h
TU_ATTR_WEAK void tud_hid_report_complete_cb(uint8_t instance, uint8_t const* report, /*uint16_t*/ uint8_t len );
But these commits suggest that the last argument will eventually be
changed to uint16_t:
556b5d5044
change report len in hid API from uint8_t to uint16_t
since HS interrupt endpoint can be up to 1024, 8-bit is not enough.
affected APIs are:
- tud_hid_n_report() / tud_hid_report()
- tud_hid_report_complete_cb()
b495d6f8ec
temporarily revert len back to uint8_t in tud_hid_report_complete_cb() for up coming release
To prevent this from becoming broken again, in preparation for the change
to uint16_t, make USBHID resilient to any type for the last argument for
tud_hid_report_complete_cb() by using some C++ template metaprogramming,
adapted from https://stackoverflow.com/a/22632571.
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
* Removed option to change CHANNEL
* Revert "Removed option to change CHANNEL"
This reverts commit b2ec27de1d2d4703a15f6397550a46896413828a.
* Fixed the ability to change CHANNEL
* WiFi scan only on selected channel
otherwise the compiler will complain about unused variable event
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Improve RGB LED Driver
Replaces the use of the `LED_BUILTIN` variable by creating a new variable called `RGB_BUILTIN`. On boards with both a regular LED and RGB LED, this change provides functionality to control either LED.
The `LED_BRIGHTNESS` variable is changed to `RGB_BRIGHTNESS`, which aligns more closely with the `RGB_BUILTIN` variable name.
`BOARD_HAS_NEOPIXEL` is no longer necessary; it is replaced by `RGB_BUILTIN`.
* Update BlinkRGB example
Update example code for changes with the RGB driver:
- Replace `LED_BUILTIN` and `BOARD_HAS_NEOPIXEL` with `RGB_BUILTIN`
- Replace `LED_BRIGHTNESS` with `RGB_BRIGHTNESS`
* Update board variants
Update board variants for changes with the RGB driver:
- Remove `BOARD_HAS_NEOPIXEL`
- Define `RGB_BUILTIN` pin
- Replace `LED_BRIGHTNESS` with `RGB_BRIGHTNESS` to align with `RGB_BUILTIN` name
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: Vojtěch Bartoška <76958047+VojtechBartoska@users.noreply.github.com>
With recent compiler update, the following warning is generated:
packages/esp32/hardware/esp32/2.0.4/libraries/LittleFS/src/LittleFS.cpp:85:5: warning: missing initializer for member 'esp_vfs_littlefs_conf_t::dont_mount' [-Wmissing-field-initializers]
This commit adds the missing identifier.
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
* Added definitions for various parameters and UI types.
* Overload for `const char*` added.
* Function `addValidStrList` added.
This is needed for mode parameters (see example RMakerCustomAirCooler.ino).
* Example of a custom device that uses toggle, mode and range parameters.
* Revert: Added definitions for various parameters and UI types.
* Fixed declaration for addValidStrList
* Fixed missing gpio definition for ESP32C3 target
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Description of Change
Original code does not work (crashing) - related issue #6832 - now fixed.
Extended description to be more helpful.
Added options to modify the setup at the top of the code via constants.
Added option do plot with Arduino Serial plotter.
Even if the crashing was solved alone the ledc PWM would not output any signal.
Tests scenarios
Tested on ESP32 with oscilloscope and signal generator.
Related links
Closing #6832
Fixed issue with ssl_client->socket being closed without being consistently set to -1. Changed close to lwip_close to be consistent with lwip_socket, resolved issue with long term assert after 4+ days (assert failed: lock_release_generic locks.c:186).
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Description of Change
This PR fixes an issue related to BLE Server and Descriptors.
The issue:
If the BLE Server code changes its own descriptors, it is not reflected in the GATTS database.
BLE2902 CCCD also didn't reflect any changes to the GATTS database.
Because of this issue, the client could never read the real Descriptor values from the remote Server.
Tests scenarios
Tested with ESP32.
Related links
Fixes#6863Fixes#6868
* Initial implementation of RGB driver via digitalWrite
* Moved constants to pins_arduino.h
* Changed pin definition + added example
* Wrapped BlinkRGB in #ifdef BOARD_HAS_NEOPIXEL
* Removed forgotten log from example
* Moved RGBLedWrite to new file esp32-hal-rgb-led and created pinMode in variatn.cpp
* Updated example - lowered single channel brightness to LED_BRIGHTNESS
* Changed function name from RGBLedWrite to neopixelWrite + code polishing
* Moved pinSetup portion related to RGB back to common file
- Created new temporary variable, stopping confusion with the reuse of "error". As Wire.requestFrom() doesn't return an error.
- Added a cast to help clarify when and why bytes are being read
When building the core with `-Wextra` a few locations have `case:`
fall throughs or skipped field initializers.
Add proper comments for B64 cases to avoid GCC warnings
Initialized unused fields in Tone and WiFiGeneric to avoid missing
field initializer warnings.
````
2022-05-19T17:40:42.2280300Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c: In function 'base64_decode_block_signed':
2022-05-19T17:40:42.2282122Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:42:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
2022-05-19T17:40:42.2283247Z *plainchar = (fragment & 0x03f) << 2;
2022-05-19T17:40:42.2284240Z ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
2022-05-19T17:40:42.2285087Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:43:7: note: here
2022-05-19T17:40:42.2285435Z case step_b:
2022-05-19T17:40:42.2285691Z ^~~~
2022-05-19T17:40:42.2286515Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:53:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
2022-05-19T17:40:42.2286932Z *plainchar = (fragment & 0x00f) << 4;
2022-05-19T17:40:42.2287219Z ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
2022-05-19T17:40:42.2287609Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:54:7: note: here
2022-05-19T17:40:42.2287909Z case step_c:
2022-05-19T17:40:42.2288200Z ^~~~
2022-05-19T17:40:42.2288972Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:64:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
2022-05-19T17:40:42.2289491Z *plainchar = (fragment & 0x003) << 6;
2022-05-19T17:40:42.2289745Z ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
2022-05-19T17:40:42.2290162Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cdecode.c:65:7: note: here
2022-05-19T17:40:42.2290509Z case step_d:
2022-05-19T17:40:42.2290714Z ^~~~
2022-05-19T17:40:42.2482744Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c: In function 'base64_encode_block':
2022-05-19T17:40:42.2484713Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c:46:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
2022-05-19T17:40:42.2485415Z result = (fragment & 0x003) << 4;
2022-05-19T17:40:42.2486713Z ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
2022-05-19T17:40:42.2487696Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c:47:9: note: here
2022-05-19T17:40:42.2488519Z case step_B:
2022-05-19T17:40:42.2489175Z ^~~~
2022-05-19T17:40:42.2492458Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c:56:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
2022-05-19T17:40:42.2493351Z result = (fragment & 0x00f) << 2;
2022-05-19T17:40:42.2494227Z ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
2022-05-19T17:40:42.2496324Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/libb64/cencode.c:57:9: note: here
2022-05-19T17:40:42.2496937Z case step_C:
2022-05-19T17:40:42.2497261Z ^~~~
2022-05-19T17:40:44.6354962Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp: In function 'void setToneChannel(uint8_t)':
2022-05-19T17:40:44.6356417Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:99:5: warning: missing initializer for member 'tone_msg_t::pin' [-Wmissing-field-initializers]
2022-05-19T17:40:44.6357120Z };
2022-05-19T17:40:44.6358732Z ^
2022-05-19T17:40:44.6364470Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:99:5: warning: missing initializer for member 'tone_msg_t::frequency' [-Wmissing-field-initializers]
2022-05-19T17:40:44.6367914Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:99:5: warning: missing initializer for member 'tone_msg_t::duration' [-Wmissing-field-initializers]
2022-05-19T17:40:44.6372875Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp: In function 'void noTone(uint8_t)':
2022-05-19T17:40:44.6373943Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:110:5: warning: missing initializer for member 'tone_msg_t::frequency' [-Wmissing-field-initializers]
2022-05-19T17:40:44.6375154Z };
2022-05-19T17:40:44.6375825Z ^
2022-05-19T17:40:44.6379852Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:110:5: warning: missing initializer for member 'tone_msg_t::duration' [-Wmissing-field-initializers]
2022-05-19T17:40:44.6383291Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:110:5: warning: missing initializer for member 'tone_msg_t::channel' [-Wmissing-field-initializers]
2022-05-19T17:40:44.6388688Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp: In function 'void tone(uint8_t, unsigned int, long unsigned int)':
2022-05-19T17:40:44.6389829Z /home/runner/arduino_ide/hardware/espressif/esp32/cores/esp32/Tone.cpp:128:5: warning: missing initializer for member 'tone_msg_t::channel' [-Wmissing-field-initializers]
2022-05-19T17:40:44.6390677Z };
2022-05-19T17:40:44.6391420Z ^
2022-05-19T17:42:00.6768353Z /home/runner/arduino_ide/hardware/espressif/esp32/libraries/WiFi/src/WiFiGeneric.cpp: In static member function 'static bool WiFiGenericClass::setDualAntennaConfig(uint8_t, uint8_t, wifi_rx_ant_t, wifi_tx_ant_t)':
2022-05-19T17:42:00.6769293Z /home/runner/arduino_ide/hardware/espressif/esp32/libraries/WiFi/src/WiFiGeneric.cpp:1333:5: warning: missing initializer for member 'wifi_ant_config_t::rx_ant_default' [-Wmissing-field-initializers]
2022-05-19T17:42:00.6769658Z };
2022-05-19T17:42:00.6769824Z ^
````
add a comment to make it clear, since platformIO still creating the `spiffs.bin` for filesystem image. The file name `spiffs.bin` is so much CONFUSING! it makes the user fill the LittleFS creating is fail.
Better allocate the buffer for f_mkfs from the heap otherwise the stack requirement of this library is huge due to a work buffer allocated for f_mkfs in sdcard_mount. The work buffer is only needed if argument format_if_empty is set true (which is by default false).
This change is quite important if you plan to use this library in a task. as now it increased the tasks stacks size by 4k, even this memory is never used if users are not aware of the large stack requirement during init this library may have other variables on stack that would have written memory outsides its range which can cause various side effects.
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
The internal _isRemoteAddressSet variable is set to true
when calling connect() functions. If connecting fails _isRemoteAddressSet
needs to be re-set to false, otherwise other functions, such as
discover() will fail without clear error messages.
Summary
Added compiler.warning_flags to all chips in platform.txt to reflect users setting of warning level output during compilation (set up in Arduino IDE preferences)
Impact
When a warning is set to none the compilation will no longer display warnings
Related links
Solves issue #6118
Description of Change
Fixes IPAddress INADDR_NONE declaration when using Arduino WiFi or ETH.
This symbol was defined as 0xffffffff by lwip /inet.h, making it impossible to use INADDR_NONE correctly.
This PR only works when <wifi-provisioning/wifi_config.h> has a modification to include <lwip/ip4_addr.h> instead of <lwip/inet.h>. This will be done directly to the sdk folder in the github structure and it has been fixed in IDF by a separated Merge Request. This will be reflected in the future, for good.
Tests scenarios
This PR was tested with all Arduino WiFi examples, including AsyncUDP. Also with ETH examples.
It was also tested for #6610 test cases.
Testing done for ESP32, ESP32-S2, ESP32-C3 and ESP32-S3.
Related links
fixes#6610fixes#6247fixes#4732
Added options to WiFi STA for connect:
- setMinSecurity: default WIFI_AUTH_WPA2_PSK
- setScanMethod: default WIFI_FAST_SCAN
- setSortMethod: default WIFI_CONNECT_AP_BY_SIGNAL (required all channels scan method)
Added parameters for SSID and BSSID to WiFi.scanNetworks()
Fixes: #6485
Fixes: Any issue about WiFi connecting slower now than in 1.0.x
Private Key. Issue presented during any subsequent invocation of loadCACert, loadCertificate, and
loadPrivateKey, respectively, after the first invocation.
* Revert "Edited VFSFileImpl::read to use both read/fread (#6456)"
This reverts commit 7b89b39e10.
* Added default file buffer size + function to change it by user
