Add a build of all variants to CI (#2262)

* Add a build of all variants to CI using P.IO
* Split out into separate job, use BOOTSEL sketch
* Fix Breadstick variant
* Fix Bridgetech boards with illegal define names
  Dash(-) to underscore(_) in define and variant for the -7 and -43.
* Bridgetech JSON updates
* Temporarily remove Bridgetech boards from CI
  Needs an update to the P.IO external repo to work since the names
  of the boards have changed.

.github/workflows/pull-request.yml

@@ -223,3 +223,47 @@ jobs:
       run: pio ci --board=rpipicow -O "platform_packages=framework-arduinopico@symlink:///home/runner/work/arduino-pico/arduino-pico" libraries/ArduinoOTA/examples/SignedOTA/SignedOTA.ino
     - name: Build Bluetooth Example
       run: pio ci --board=rpipicow -O "platform_packages=framework-arduinopico@symlink:///home/runner/work/arduino-pico/arduino-pico" -O "build_flags=-DPIO_FRAMEWORK_ARDUINO_ENABLE_BLUETOOTH" libraries/MouseBLE/examples/BLECircle/BLECircle.ino
+
+# Build every variant using PIO for simplicity
+  build-variants:
+    name: Build Every Variant
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        submodules: 'true'
+    - name: Initialize needed submodules
+      run: |
+        cd pico-sdk
+        git submodule update --init
+        cd ../libraries/Adafruit_TinyUSB_Arduino
+        git submodule update --init
+        cd ../..
+    - name: Cache pip
+      uses: actions/cache@v4
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
+        restore-keys: |
+          ${{ runner.os }}-pip-
+    - name: Cache PlatformIO
+      uses: actions/cache@v4
+      with:
+        path: ~/.platformio
+        key: ${{ runner.os }}-${{ hashFiles('**/lockfiles') }}
+    - name: Set up Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: '3.x'
+    - name: Install PlatformIO
+      run: |
+        python -m pip install --upgrade pip
+        pip install --upgrade platformio
+        pio pkg install --global --platform https://github.com/maxgerhardt/platform-raspberrypi.git
+        pio pkg install --global --tool symlink://.
+    - name: Build Every Variant
+      run: |
+        # Temporarily remove bridgeteck since they had borked names and need an update to the PIO config
+        for b in $(cut -f1 -d. /home/runner/work/arduino-pico/arduino-pico/boards.txt | sed 's/#.*//' | sed 's/^menu$//' | sed 's/bridgetek.*//' | sort -u); do
+          pio ci --board=$b -O "platform_packages=framework-arduinopico@symlink:///home/runner/work/arduino-pico/arduino-pico" libraries/rp2040/examples/Bootsel/Bootsel.ino
+        done

tools/json/bridgetek_idm2040_43a.json

@@ -9,7 +9,7 @@
     },
     "core": "earlephilhower",
     "cpu": "cortex-m0plus",
-    "extra_flags": "-D ARDUINO_BRIDGETEK_IDM2040-43A -DARDUINO_ARCH_RP2040 -DUSBD_MAX_POWER_MA=250 -DFT8XX_TYPE=BT883 -DDISPLAY_RES=WQVGA -DPLATFORM_RP2040",
+    "extra_flags": "-D ARDUINO_BRIDGETEK_IDM2040_43A -DARDUINO_ARCH_RP2040 -DUSBD_MAX_POWER_MA=250 -DFT8XX_TYPE=BT883 -DDISPLAY_RES=WQVGA -DPLATFORM_RP2040",
     "f_cpu": "133000000L",
     "hwids": [
       [
@@ -22,7 +22,7 @@
       ]
     ],
     "mcu": "rp2040",
-    "variant": "bridgetek_idm2040-43a"
+    "variant": "bridgetek_idm2040_43a"
   },
   "debug": {
     "jlink_device": "RP2040_M0_0",

tools/json/bridgetek_idm2040_7a.json

@@ -9,7 +9,7 @@
     },
     "core": "earlephilhower",
     "cpu": "cortex-m0plus",
-    "extra_flags": "-D ARDUINO_BRIDGETEK_IDM2040-7A -DARDUINO_ARCH_RP2040 -DUSBD_MAX_POWER_MA=250 -DFT8XX_TYPE=BT817 -DDISPLAY_RES=WVGA -DPLATFORM_RP2040",
+    "extra_flags": "-D ARDUINO_BRIDGETEK_IDM2040_7A -DARDUINO_ARCH_RP2040 -DUSBD_MAX_POWER_MA=250 -DFT8XX_TYPE=BT817 -DDISPLAY_RES=WVGA -DPLATFORM_RP2040",
     "f_cpu": "133000000L",
     "hwids": [
       [
@@ -22,7 +22,7 @@
       ]
     ],
     "mcu": "rp2040",
-    "variant": "bridgetek_idm2040-7a"
+    "variant": "bridgetek_idm2040_7a"
   },
   "debug": {
     "jlink_device": "RP2040_M0_0",

tools/makeboards.py

@@ -406,8 +406,8 @@ MakeBoard("artronshop_rp2_nano", "ArtronShop", "RP2 Nano", "0x2e8a", "0x000a", 2
 MakeBoard("breadstick_raspberry", "Breadstick", "Raspberry", "0x2e8a", "0x105e" , 500, "Breadstick_Raspberry", 16, "boot2_w25q080_2_padded_checksum", board_url="https://shop.breadstick.ca/products/raspberry-breadstick-rp2040")
 
 # BridgeTek
-MakeBoard("bridgetek_idm2040-7a", "BridgeTek", "IDM2040-7A", "0x2e8a", "0x1041", 250, "BRIDGETEK_IDM2040-7A", 8, "boot2_w25q080_2_padded_checksum", ["FT8XX_TYPE=BT817", "DISPLAY_RES=WVGA", "PLATFORM_RP2040"])
+MakeBoard("bridgetek_idm2040_7a", "BridgeTek", "IDM2040-7A", "0x2e8a", "0x1041", 250, "BRIDGETEK_IDM2040_7A", 8, "boot2_w25q080_2_padded_checksum", ["FT8XX_TYPE=BT817", "DISPLAY_RES=WVGA", "PLATFORM_RP2040"])
-MakeBoard("bridgetek_idm2040-43a", "BridgeTek", "IDM2040-43A", "0x2e8b", "0xf00a", 250, "BRIDGETEK_IDM2040-43A", 8, "boot2_w25q080_2_padded_checksum", ["FT8XX_TYPE=BT883", "DISPLAY_RES=WQVGA", "PLATFORM_RP2040"])
+MakeBoard("bridgetek_idm2040_43a", "BridgeTek", "IDM2040-43A", "0x2e8b", "0xf00a", 250, "BRIDGETEK_IDM2040_43A", 8, "boot2_w25q080_2_padded_checksum", ["FT8XX_TYPE=BT883", "DISPLAY_RES=WQVGA", "PLATFORM_RP2040"])
  
 # Cytron
 MakeBoard("cytron_maker_nano_rp2040", "Cytron", "Maker Nano RP2040", "0x2e8a", "0x100f", 250, "CYTRON_MAKER_NANO_RP2040", 2, "boot2_w25q080_2_padded_checksum")

variants/breadstick_raspberry/pins_arduino.h

@@ -11,6 +11,10 @@
 #define PIN_SERIAL1_TX (20u)
 #define PIN_SERIAL1_RX (21u)
 
+// Not pinned
+#define PIN_SERIAL2_TX (31)
+#define PIN_SERIAL2_RX (31)
+
 // SPI
 
 #define PIN_SPI1_MISO  (8u)
@@ -36,6 +40,7 @@
 #define ADC_RESOLUTION      (12u)
 #define WIRE_INTERFACES_COUNT (WIRE_HOWMANY)
 
+// TODO - fix to use newly defined common.h
 static const uint8_t D1 = (27u);
 static const uint8_t D2 = (26u);
 static const uint8_t D3 = (11u);
@@ -57,9 +62,9 @@ static const uint8_t D18 = (28u);
 
 
 #ifdef __PIN_A2
-static const uint8_t A2 = __PIN_A2;
+static const uint8_t A0 = __PIN_A0;
 #else
-static const uint8_t A2 = (26u);
+static const uint8_t A0 = (26u);
 #endif
 
 #ifdef __PIN_A1
@@ -69,15 +74,15 @@ static const uint8_t A1 = (27u);
 #endif
 
 #ifdef __PIN_A18
-static const uint8_t A18 = __PIN_A18;
+static const uint8_t A2 = __PIN_A2;
 #else
-static const uint8_t A18 = (28u);
+static const uint8_t A2 = (28u);
 #endif
 
 #ifdef __PIN_A17
-static const uint8_t A17 = __PIN_A17;
+static const uint8_t A3 = __PIN_A3;
 #else
-static const uint8_t A17 = (29u);
+static const uint8_t A3 = (29u);
 #endif
 
 static const uint8_t SS = PIN_SPI1_SS;
@@ -92,4 +97,4 @@ static const uint8_t IMU_SDA = PIN_WIRE0_SDA;
 static const uint8_t IMU_SCL = PIN_WIRE0_SCL;
 
 static const uint8_t DOTSTAR_CLOCK = (16u);
-static const uint8_t DOTSTAR_DATA = (17u);
+static const uint8_t DOTSTAR_DATA = (17u);