adafruit-mirror/circuitpython
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve update to mp_hal_delay_ms:

Browse source 
o Test for console interrupt during RUN_BACKGROUND_TASK
o Handle signedness of remaining tick/subtick values correctly for very large delays
o Improve comments
This commit is contained in:
eightycc 2025-05-07 08:06:41 -07:00
parent fcf7df857e
commit 61071cb41c
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
supervisor/shared/tick.c
View file

@ -114,13 +114,14 @@ void mp_hal_delay_ms(mp_uint_t delay_ms) {
// or the user.
while (remaining > 0 && !mp_hal_is_interrupted()) {
RUN_BACKGROUND_TASKS;
remaining = end_subtick - supervisor_get_raw_subticks();
// We break a bit early so we don't risk setting the alarm before the time when we call
// sleep.
if (remaining < 1) {
// Exit if interrupted while running background tasks
if (mp_hal_is_interrupted()) {
break;
}
uint32_t remaining_ticks = remaining / 32;
// Recalculate remaining delay after running background tasks
remaining = end_subtick - supervisor_get_raw_subticks();
// If remaining delay is less than 1 tick, idle loop until end of delay
int64_t remaining_ticks = remaining / 32;
if (remaining_ticks > 0) {
port_interrupt_after_ticks(remaining_ticks);
// Idle until an interrupt happens.