twister: Remove 'xtools' toolchain variant references

This commit removes all references to the `xtools` toolchain variant in the
twister scripts.

Note that the `xtools` toolchain variant has been deprecated since Zephyr
v3.3.0 and now removed.

Signed-off-by: Stephanos Ioannidis <root@stephanos.io>

scripts/pylib/twister/twisterlib/platform.py

@@ -149,18 +149,18 @@ class Platform:
 
         support_toolchain_variants = {
           # we don't provide defaults for 'arc' intentionally: some targets can't be built with GNU
-          # toolchain ("zephyr", "cross-compile", "xtools" options) and for some targets we haven't
+          # toolchain ("zephyr", "cross-compile" options) and for some targets we haven't provided
-          # provided MWDT compiler / linker options in corresponding SoC file in Zephyr, so these
+          # MWDT compiler / linker options in corresponding SoC file in Zephyr, so these targets
-          # targets can't be built with ARC MWDT toolchain ("arcmwdt" option) by Zephyr build system
+          # can't be built with ARC MWDT toolchain ("arcmwdt" option) by Zephyr build system Instead
-          # Instead for 'arc' we rely on 'toolchain' option in board yaml configuration.
+          # for 'arc' we rely on 'toolchain' option in board yaml configuration.
-          "arm": ["zephyr", "gnuarmemb", "xtools", "armclang", "llvm"],
+          "arm": ["zephyr", "gnuarmemb", "armclang", "llvm"],
           "arm64": ["zephyr", "cross-compile"],
-          "mips": ["zephyr", "xtools"],
+          "mips": ["zephyr"],
-          "nios2": ["zephyr", "xtools"],
+          "nios2": ["zephyr"],
           "riscv": ["zephyr", "cross-compile"],
           "posix": ["host", "llvm"],
-          "sparc": ["zephyr", "xtools"],
+          "sparc": ["zephyr"],
-          "x86": ["zephyr", "xtools", "llvm"],
+          "x86": ["zephyr", "llvm"],
           # Xtensa is not listed on purpose, since there is no single toolchain
           # that is supported on all board targets for xtensa.
         }

scripts/tests/twister/test_data/boards/1_level/2_level/board_config_1.yaml

@@ -5,7 +5,6 @@ arch: arm
 toolchain:
   - zephyr
   - gnuarmemb
-  - xtools
 ram: 256
 flash: 1024
 supported:

scripts/tests/twister/test_data/boards/1_level/2_level/board_config_2.yaml

@@ -5,7 +5,6 @@ arch: x86
 toolchain:
   - zephyr
   - gnuarmemb
-  - xtools
 ram: 256
 flash: 1024
 supported:

scripts/tests/twister/test_data/boards/1_level/2_level/board_config_3.yaml

@@ -5,7 +5,6 @@ arch: arm
 toolchain:
   - zephyr
   - gnuarmemb
-  - xtools
 ram: 256
 flash: 1024
 supported: