adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

net: lib: coap_client: Remove duplicate token comparison

Browse source 
Response tokens are already compared in get_request_with_token().

Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
This commit is contained in:
Seppo Takalo 2024-10-25 13:32:43 +03:00 committed by Mahesh Mahadevan
parent e96e95b6f6
commit 1dc24872ce
1 changed files with 0 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
subsys/net/lib/coap/coap_client.c
View file

@ -594,21 +594,6 @@ static int handle_poll(void)
return 0;
}
static bool token_compare(struct coap_client_internal_request *internal_req,
const struct coap_packet *resp)
{
uint8_t response_token[COAP_TOKEN_MAX_LEN];
uint8_t response_tkl;
response_tkl = coap_header_get_token(resp, response_token);
if (internal_req->request_tkl != response_tkl) {
return false;
}
return memcmp(&internal_req->request_token, &response_token, response_tkl) == 0;
}
static int recv_response(struct coap_client *client, struct coap_packet *response, bool *truncated)
{
int total_len;
@ -768,11 +753,6 @@ static int handle_response(struct coap_client *client, const struct coap_packet
return 0;
}
if (internal_req == NULL || !token_compare(internal_req, response)) {
LOG_WRN("Not matching tokens");
return 1;
}
/* MID-based deduplication */
if (response_id == internal_req->last_response_id) {
LOG_WRN("Duplicate MID, dropping");