adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

usb: cdc_acm: Fix tx false data drop logging

Browse source 
cdc_acm_fifo_fill() logged warnings about dropped data
when they in fact just couldn't be sent (due to connection
of filled buffer). Not being able to send (all) data is
a valid behaviour and data isn't dropped. Return value
shows how many data was accepted (which can be zero).

Logging will now instead only inform data can't be sent
due to the respective issue (connection not ready/ buffer full).

Signed-off-by: Martin Koehler <koehler@metratec.com>
This commit is contained in:
Martin Koehler 2024-07-22 15:47:36 +02:00 committed by Johan Hedberg
parent d9f567051e
commit 22a615b3e6
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
subsys/usb/device/class/cdc_acm.c
View file

@ -527,8 +527,7 @@ static int cdc_acm_fifo_fill(const struct device *dev,
dev_data, len, ring_buf_space_get(dev_data->tx_ringbuf));
if (!dev_data->configured || dev_data->suspended) {
LOG_WRN("Device not configured or suspended, drop %d bytes",
len);
LOG_INF("Device suspended or not configured");
return 0;
}
@ -537,9 +536,7 @@ static int cdc_acm_fifo_fill(const struct device *dev,
lock = irq_lock();
wrote = ring_buf_put(dev_data->tx_ringbuf, tx_data, len);
irq_unlock(lock);
if (wrote < len) {
LOG_WRN("Ring buffer full, drop %zd bytes", len - wrote);
}
LOG_DBG("Wrote %zu of %d bytes to TX ringbuffer", wrote, len);
k_work_schedule_for_queue(&USB_WORK_Q, &dev_data->tx_work, K_NO_WAIT);