adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

drivers: mipi_dbi: smartbond: Optimize driver PM

Browse source 
This commit should optimize the way the device is allowed
to enter the suspended state. Instead of returning a PM
error code to abort the PM process, the standby power state
is constrained as long as the device is not allowed to enter
suspension. With that approach, acquiring PD_SYS is not needed
when in PM device runtime mode.

Signed-off-by: Ioannis Karachalios <ioannis.karachalios.px@renesas.com>
This commit is contained in:
Ioannis Karachalios 2024-05-21 19:25:47 +03:00 committed by Anas Nashif
parent 33665348c2
commit 2958f691bb
1 changed files with 21 additions and 43 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

62
drivers/mipi_dbi/mipi_dbi_smartbond.c
View file

@ -14,6 +14,7 @@
#include <zephyr/device.h> #include <zephyr/device.h>
#include <zephyr/pm/device.h> #include <zephyr/pm/device.h>
#include <zephyr/pm/device_runtime.h> #include <zephyr/pm/device_runtime.h>
#include <zephyr/pm/policy.h>
#include <DA1469xAB.h> #include <DA1469xAB.h>
#include <zephyr/drivers/clock_control.h> #include <zephyr/drivers/clock_control.h>
#include <zephyr/drivers/clock_control/smartbond_clock_control.h> #include <zephyr/drivers/clock_control/smartbond_clock_control.h>
@ -62,10 +63,6 @@ struct mipi_dbi_smartbond_data {
struct k_sem sync_sem; struct k_sem sync_sem;
/* Flag indicating whether or not an underflow took place */ /* Flag indicating whether or not an underflow took place */
volatile bool underflow_flag; volatile bool underflow_flag;
#if defined(CONFIG_PM_DEVICE) || defined(CONFIG_PM_DEVICE_RUNTIME)
/* Flag to designate whether or not a frame update is in progress */
bool is_active;
#endif
/* Layer settings */ /* Layer settings */
lcdc_smartbond_layer_cfg layer; lcdc_smartbond_layer_cfg layer;
}; };
@ -82,23 +79,20 @@ struct mipi_dbi_smartbond_config {
}; };
/* Mark the device is is progress and so it's not allowed to enter the sleep state. */ /* Mark the device is is progress and so it's not allowed to enter the sleep state. */
static void mipi_dbi_pm_get(const struct device *dev) static inline void mipi_dbi_smartbond_pm_policy_state_lock_get(void)
{ {
#ifdef CONFIG_PM_DEVICE /*
struct mipi_dbi_smartbond_data *data = dev->data; * Prevent the SoC from etering the normal sleep state as PDC does not support
* waking up the application core following LCDC events.
data->is_active = true; */
#endif pm_policy_state_lock_get(PM_STATE_STANDBY, PM_ALL_SUBSTATES);
} }
/* Mark that device is inactive and so it's allowed to enter the sleep state */ /* Mark that device is inactive and so it's allowed to enter the sleep state */
static void mipi_dbi_pm_put(const struct device *dev) static inline void mipi_dbi_smartbond_pm_policy_state_lock_put(void)
{ {
#ifdef CONFIG_PM_DEVICE /* Allow the SoC to enter the nornmal sleep state once LCDC is inactive */
struct mipi_dbi_smartbond_data *data = dev->data; pm_policy_state_lock_put(PM_STATE_STANDBY, PM_ALL_SUBSTATES);
data->is_active = false;
#endif
} }
/* Helper function to trigger the LCDC fetching data from frame buffer to the connected display */ /* Helper function to trigger the LCDC fetching data from frame buffer to the connected display */
@ -217,6 +211,8 @@ static int mipi_dbi_smartbond_command_read(const struct device *dev,
k_sem_take(&data->device_sem, K_FOREVER); k_sem_take(&data->device_sem, K_FOREVER);
mipi_dbi_smartbond_pm_policy_state_lock_get();
/* /*
* Add an arbitrary valid color format to satisfy subroutine. The MIPI DBI command/data * Add an arbitrary valid color format to satisfy subroutine. The MIPI DBI command/data
* engine should not be affected. * engine should not be affected.
@ -283,6 +279,8 @@ _mipi_dbi_read_exit:
LOG_ERR("Could not apply MIPI DBI pins' default state (%d)", ret); LOG_ERR("Could not apply MIPI DBI pins' default state (%d)", ret);
} }
mipi_dbi_smartbond_pm_policy_state_lock_put();
k_sem_give(&data->device_sem); k_sem_give(&data->device_sem);
return ret; return ret;
@ -300,7 +298,7 @@ static int mipi_dbi_smartbond_command_write(const struct device *dev,
k_sem_take(&data->device_sem, K_FOREVER); k_sem_take(&data->device_sem, K_FOREVER);
mipi_dbi_pm_get(dev); mipi_dbi_smartbond_pm_policy_state_lock_get();
/* /*
* Add an arbitrary valid color format to satisfy subroutine. The MIPI DBI command/data * Add an arbitrary valid color format to satisfy subroutine. The MIPI DBI command/data
@ -321,7 +319,7 @@ static int mipi_dbi_smartbond_command_write(const struct device *dev,
da1469x_lcdc_send_cmd_data(false, data_buf, len); da1469x_lcdc_send_cmd_data(false, data_buf, len);
} }
mipi_dbi_pm_put(dev); mipi_dbi_smartbond_pm_policy_state_lock_put();
k_sem_give(&data->device_sem); k_sem_give(&data->device_sem);
@ -349,7 +347,7 @@ static int mipi_dbi_smartbond_write_display(const struct device *dev,
k_sem_take(&data->device_sem, K_FOREVER); k_sem_take(&data->device_sem, K_FOREVER);
mipi_dbi_pm_get(dev); mipi_dbi_smartbond_pm_policy_state_lock_get();
/* /*
* Mainly check if the frame generator is busy with a pending frame update (might happen * Mainly check if the frame generator is busy with a pending frame update (might happen
@ -388,7 +386,7 @@ static int mipi_dbi_smartbond_write_display(const struct device *dev,
_mipi_dbi_write_exit: _mipi_dbi_write_exit:
mipi_dbi_pm_put(dev); mipi_dbi_smartbond_pm_policy_state_lock_put();
k_sem_give(&data->device_sem); k_sem_give(&data->device_sem);
@ -488,33 +486,14 @@ static int mipi_dbi_smartbond_suspend(const struct device *dev)
static int mipi_dbi_smartbond_pm_action(const struct device *dev, enum pm_device_action action) static int mipi_dbi_smartbond_pm_action(const struct device *dev, enum pm_device_action action)
{ {
/* Initialize with an error code that should abort sleeping */ int ret = 0;
int ret = -EBUSY;
struct mipi_dbi_smartbond_data *data = dev->data;
switch (action) { switch (action) {
case PM_DEVICE_ACTION_SUSPEND: case PM_DEVICE_ACTION_SUSPEND:
/* Sleep is only allowed when there are no active LCDC operations */ /* A non-zero value should not affect sleep */
if (!data->is_active) {
(void)mipi_dbi_smartbond_suspend(dev); (void)mipi_dbi_smartbond_suspend(dev);
/*
* Once the display block is turned off, its power domain
* can be released as well.
*/
da1469x_pd_release_nowait(MCU_PD_DOMAIN_SYS);
ret = 0;
}
break; break;
case PM_DEVICE_ACTION_RESUME: case PM_DEVICE_ACTION_RESUME:
__ASSERT_NO_MSG(!data->is_active);
/*
* Although PD_SYS should already be turned on, make sure LCD controller's
* power domain is up and running before accessing the display block.
* Acquiring PD_SYS is mandatory when in PM runtime mode.
*/
da1469x_pd_acquire(MCU_PD_DOMAIN_SYS);
/* /*
* The resume error code should not be taken into consideration * The resume error code should not be taken into consideration
* by the PM subsystem. * by the PM subsystem.
@ -559,7 +538,6 @@ static int mipi_dbi_smartbond_init(const struct device *dev)
ret = pm_device_runtime_enable(dev); ret = pm_device_runtime_enable(dev);
#else #else
da1469x_pd_acquire(MCU_PD_DOMAIN_SYS);
/* Resme if either PM is not used at all or if PM without runtime is used. */ /* Resme if either PM is not used at all or if PM without runtime is used. */
ret = mipi_dbi_smartbond_resume(dev); ret = mipi_dbi_smartbond_resume(dev);
#endif #endif