adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 8

drivers: hwinfo: shell: fix error message when no hardware support

Browse source 
When there is no implementation for a particular hardware information
device, the API return -ENOSYS, while the hardware information shell
checks for -ENOTSUP. This returns a non-user friendly message:

  uart:~$ hwinfo devid
  Error: -88

The API can't be changed easily without breaking things, so let's change
the shell instead. This gives:

  uart:~$ hwinfo devid
  Not supported by hardware

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
This commit is contained in:
Aurelien Jarno 2024-04-28 19:24:32 +02:00 committed by Fabio Baltieri
parent 1188305c1e
commit 3da656388d
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/hwinfo/hwinfo_shell.c
View file

@ -18,9 +18,9 @@ static int cmd_get_device_id(const struct shell *sh, size_t argc, char **argv)
length = hwinfo_get_device_id(dev_id, sizeof(dev_id));
if (length == -ENOTSUP) {
if (length == -ENOSYS) {
shell_error(sh, "Not supported by hardware");
return -ENOTSUP;
return -ENOSYS;
} else if (length < 0) {
shell_error(sh, "Error: %zd", length);
return length;
@ -138,7 +138,7 @@ static int cmd_show_reset_cause(const struct shell *sh, size_t argc,
ARG_UNUSED(argv);
res = hwinfo_get_reset_cause(&cause);
if (res == -ENOTSUP) {
if (res == -ENOSYS) {
shell_error(sh, "Not supported by hardware");
return res;
} else if (res != 0) {
@ -165,7 +165,7 @@ static int cmd_clear_reset_cause(const struct shell *sh, size_t argc,
ARG_UNUSED(argv);
res = hwinfo_clear_reset_cause();
if (res == -ENOTSUP) {
if (res == -ENOSYS) {
shell_error(sh, "Not supported by hardware");
} else if (res != 0) {
shell_error(sh, "Error clearing the reset causes [%d]", res);
@ -185,7 +185,7 @@ static int cmd_supported_reset_cause(const struct shell *sh, size_t argc,
ARG_UNUSED(argv);
res = hwinfo_get_supported_reset_cause(&cause);
if (res == -ENOTSUP) {
if (res == -ENOSYS) {
shell_error(sh, "Not supported by hardware");
} else if (res != 0) {
shell_error(sh, "Could not get the supported reset causes [%d]", res);