adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

ztest: shell: Fix memory leaks processing test arguments

Browse source 
Fix Ztest shell memory leaks when it process test arguments.

Signed-off-by: Dmitrii Golovanov <dmitrii.golovanov@intel.com>
This commit is contained in:
Dmitrii Golovanov 2024-07-03 11:47:02 +02:00 committed by Alberto Escolar
parent 64f38fc348
commit 5d80e253b7
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
subsys/testsuite/ztest/src/ztest_shell.c
View file

@ -37,11 +37,15 @@ void z_ztest_run_all(const void *state, bool shuffle, int suite_iter, int case_i
void ztest_reset_test_args(void) void ztest_reset_test_args(void)
{ {
if (test_args != NULL) {
free((void *)test_args);
}
test_args = NULL; test_args = NULL;
} }
void ztest_set_test_args(char *args) void ztest_set_test_args(char *args)
{ {
ztest_reset_test_args();
test_args = strdup(args); test_args = strdup(args);
} }
@ -95,6 +99,7 @@ static bool z_ztest_testargs_contains(const char *suite_name, const char *test_n
suite_test_pair = strtok_r(NULL, ",", &last_suite_test_pair); suite_test_pair = strtok_r(NULL, ",", &last_suite_test_pair);
} }
free((void *)test_args_local);
return found; return found;
} }
@ -122,6 +127,9 @@ bool z_ztest_should_suite_run(const void *state, struct ztest_suite_node *suite)
run_suite = suite->predicate(state); run_suite = suite->predicate(state);
} }
if (test_args_local != NULL) {
free((void *)test_args_local);
}
return run_suite; return run_suite;
} }