adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

soc/intel_adsp: ipc: Remove unnecessary device state lock

Browse source 
There is no needed to lock/unlock a device state in its pm action
callback. The power management subsystem should take care of
serialize these calls.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2024-03-12 11:11:03 -07:00 committed by Carles Cufí
parent 17abc2743b
commit 741bbaca6d
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
soc/intel/intel_adsp/common/ipc.c
View file

@ -292,7 +292,6 @@ static int ipc_pm_action(const struct device *dev, enum pm_device_action action)
switch (action) { switch (action) {
case PM_DEVICE_ACTION_SUSPEND: case PM_DEVICE_ACTION_SUSPEND:
pm_device_state_lock(dev);
if (api->suspend_fn) { if (api->suspend_fn) {
ret = api->suspend_fn(dev, api->suspend_fn_args); ret = api->suspend_fn(dev, api->suspend_fn_args);
if (!ret) { if (!ret) {
@ -301,7 +300,6 @@ static int ipc_pm_action(const struct device *dev, enum pm_device_action action)
} }
break; break;
case PM_DEVICE_ACTION_RESUME: case PM_DEVICE_ACTION_RESUME:
pm_device_state_lock(dev);
irq_enable(DT_IRQN(INTEL_ADSP_IPC_HOST_DTNODE)); irq_enable(DT_IRQN(INTEL_ADSP_IPC_HOST_DTNODE));
if (!irq_is_enabled(DT_IRQN(INTEL_ADSP_IPC_HOST_DTNODE))) { if (!irq_is_enabled(DT_IRQN(INTEL_ADSP_IPC_HOST_DTNODE))) {
ret = -EINTR; ret = -EINTR;
@ -321,7 +319,6 @@ static int ipc_pm_action(const struct device *dev, enum pm_device_action action)
return -ENOTSUP; return -ENOTSUP;
} }
pm_device_state_unlock(dev);
return ret; return ret;
} }