adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

drivers: can: can_mcan.c: transparent error code propagation

Browse source 
The implementation of can_mcan_start() function
hides retun code of underlying function.
It makes root-cause search more difficult.
This change strives fro transparent error code
propagation to higher software layers.

Signed-off-by: Alexander Kozhinov <ak.alexander.kozhinov@gmail.com>
This commit is contained in:
Alexander Kozhinov 2024-12-02 09:27:27 +01:00 committed by Benjamin Cabé
parent c6b3527d44
commit 753d788997
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/can/can_mcan.c
View file

@ -292,7 +292,7 @@ int can_mcan_start(const struct device *dev)
{
const struct can_mcan_config *config = dev->config;
struct can_mcan_data *data = dev->data;
int err;
int err = 0;
if (data->common.started) {
return -EALREADY;
@ -311,19 +311,19 @@ int can_mcan_start(const struct device *dev)
err = can_mcan_leave_init_mode(dev, K_MSEC(CAN_INIT_TIMEOUT_MS));
if (err != 0) {
LOG_ERR("failed to leave init mode");
LOG_ERR("failed to leave init mode (err %d)", err);
if (config->common.phy != NULL) {
/* Attempt to disable the CAN transceiver in case of error */
(void)can_transceiver_disable(config->common.phy);
}
return -EIO;
return err;
}
data->common.started = true;
return 0;
return err;
}
int can_mcan_stop(const struct device *dev)