From 8183c991f8e0de9f4038004c5b159722ed2f3ac7 Mon Sep 17 00:00:00 2001 From: Fabio Baltieri Date: Thu, 12 Dec 2024 17:05:02 +0000 Subject: [PATCH] tests: fix various unit tests warnings Fix various unit test build warnings, unused variables, set but unused variables, wrong types etc... Signed-off-by: Fabio Baltieri --- tests/bluetooth/audio/bap_broadcast_source/src/main.c | 2 +- .../audio/cap_commander/src/test_broadcast_reception.c | 3 +-- .../audio/cap_commander/uut/bap_broadcast_assistant.c | 3 --- tests/bluetooth/audio/codec/src/main.c | 4 ++-- tests/bluetooth/controller/ctrl_phy_update/src/main.c | 3 --- tests/bluetooth/host/conn/mocks/scan.c | 1 + tests/unit/pot/nhpot.cpp | 2 +- 7 files changed, 6 insertions(+), 12 deletions(-) diff --git a/tests/bluetooth/audio/bap_broadcast_source/src/main.c b/tests/bluetooth/audio/bap_broadcast_source/src/main.c index 38a2b0a6e50..31396ba9cfe 100644 --- a/tests/bluetooth/audio/bap_broadcast_source/src/main.c +++ b/tests/bluetooth/audio/bap_broadcast_source/src/main.c @@ -19,7 +19,7 @@ #include #include #include -#include +#include #include #include diff --git a/tests/bluetooth/audio/cap_commander/src/test_broadcast_reception.c b/tests/bluetooth/audio/cap_commander/src/test_broadcast_reception.c index 61827719bb5..b23af065472 100644 --- a/tests/bluetooth/audio/cap_commander/src/test_broadcast_reception.c +++ b/tests/bluetooth/audio/cap_commander/src/test_broadcast_reception.c @@ -104,13 +104,12 @@ static void cap_commander_test_broadcast_reception_before(void *f) static void cap_commander_test_broadcast_reception_after(void *f) { struct cap_commander_test_broadcast_reception_fixture *fixture = f; - int err; bt_cap_commander_unregister_cb(&mock_cap_commander_cb); bt_bap_broadcast_assistant_unregister_cb(&fixture->broadcast_assistant_cb); /* We need to cleanup since the CAP commander remembers state */ - err = bt_cap_commander_cancel(); + (void)bt_cap_commander_cancel(); for (size_t i = 0; i < ARRAY_SIZE(fixture->conns); i++) { mock_bt_conn_disconnected(&fixture->conns[i], BT_HCI_ERR_REMOTE_USER_TERM_CONN); diff --git a/tests/bluetooth/audio/cap_commander/uut/bap_broadcast_assistant.c b/tests/bluetooth/audio/cap_commander/uut/bap_broadcast_assistant.c index 8331c292e0c..3ea01833905 100644 --- a/tests/bluetooth/audio/cap_commander/uut/bap_broadcast_assistant.c +++ b/tests/bluetooth/audio/cap_commander/uut/bap_broadcast_assistant.c @@ -182,14 +182,11 @@ int bt_bap_broadcast_assistant_set_broadcast_code( struct bt_conn *conn, uint8_t src_id, const uint8_t broadcast_code[BT_ISO_BROADCAST_CODE_SIZE]) { - struct bap_broadcast_assistant_instance *inst; struct bt_bap_broadcast_assistant_cb *listener, *next; int err; zassert_not_null(conn, "conn is NULL"); - inst = inst_by_conn(conn); - zassert_equal(src_id, RANDOM_SRC_ID, "Invalid src_id"); err = strncmp((const char *)broadcast_code, BROADCAST_CODE, sizeof(BROADCAST_CODE)); diff --git a/tests/bluetooth/audio/codec/src/main.c b/tests/bluetooth/audio/codec/src/main.c index a3a189e86ca..fcddfbb0523 100644 --- a/tests/bluetooth/audio/codec/src/main.c +++ b/tests/bluetooth/audio/codec/src/main.c @@ -659,7 +659,7 @@ ZTEST(audio_codec_test_suite, test_bt_audio_codec_cfg_meta_set_lang) struct bt_audio_codec_cfg codec_cfg = BT_AUDIO_CODEC_CFG( BT_HCI_CODING_FORMAT_LC3, 0x0000, 0x0000, {}, {BT_AUDIO_CODEC_DATA(BT_AUDIO_METADATA_TYPE_LANG, 'e', 'n', 'g')}); - char new_expected_data[] = "deu"; + const uint8_t new_expected_data[] = "deu"; char expected_data[] = "eng"; const uint8_t *lang; int ret; @@ -1701,7 +1701,7 @@ ZTEST(audio_codec_test_suite, test_bt_audio_codec_cap_meta_set_lang) struct bt_audio_codec_cap codec_cap = BT_AUDIO_CODEC_CAP( BT_HCI_CODING_FORMAT_LC3, 0x0000, 0x0000, {}, {BT_AUDIO_CODEC_DATA(BT_AUDIO_METADATA_TYPE_LANG, 'e', 'n', 'g')}); - char new_expected_data[] = "deu"; + const uint8_t new_expected_data[] = "deu"; char expected_data[] = "eng"; const uint8_t *lang; int ret; diff --git a/tests/bluetooth/controller/ctrl_phy_update/src/main.c b/tests/bluetooth/controller/ctrl_phy_update/src/main.c index 5951b685932..9a4c3d078d5 100644 --- a/tests/bluetooth/controller/ctrl_phy_update/src/main.c +++ b/tests/bluetooth/controller/ctrl_phy_update/src/main.c @@ -589,13 +589,10 @@ ZTEST(phy_periph, test_phy_update_periph_loc_invalid_central) { uint8_t err; struct node_tx *tx; - struct node_rx_pdu *ntf; struct pdu_data_llctrl_phy_req req = { .rx_phys = PHY_2M, .tx_phys = PHY_2M }; uint16_t instant; struct pdu_data_llctrl_conn_param_req conn_param_req = { }; - struct node_rx_pu pu = { .status = BT_HCI_ERR_SUCCESS }; - struct pdu_data_llctrl_phy_upd_ind phy_update_ind = { .c_to_p_phy = PHY_2M, .p_to_c_phy = PHY_2M }; diff --git a/tests/bluetooth/host/conn/mocks/scan.c b/tests/bluetooth/host/conn/mocks/scan.c index 6ccccd7bb88..1359f539606 100644 --- a/tests/bluetooth/host/conn/mocks/scan.c +++ b/tests/bluetooth/host/conn/mocks/scan.c @@ -5,6 +5,7 @@ */ #include +#include #include "scan.h" diff --git a/tests/unit/pot/nhpot.cpp b/tests/unit/pot/nhpot.cpp index 469072b7276..1a8385d270c 100644 --- a/tests/unit/pot/nhpot.cpp +++ b/tests/unit/pot/nhpot.cpp @@ -39,7 +39,7 @@ ZTEST(pot, test_constexpr_NHPOT) zassert_equal(0, NHPOT(UINT64_MAX)); zassert_equal(64, val); - zassert_equal(64, nhpot(42)); + zassert_equal(64ULL, nhpot(42ULL)); zassert_equal(BIT64(33), val64); zassert_equal(BIT64(33), nhpot(42 + BIT64(32))); }