adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

llext: fix minor Coverity issue #434586 (again)

Browse source 
The check combination of "is zero" and then "less than zero" leaves open
the theoretical possibility of a positive return value, which would
continue on with an uinitialized 'sym'.

Checking for "not zero" has the same effect and covers all situations.

Commit 56fd85442 did the same thing for 'rela' a few lines above, but
missed this instance. No other places in the llext code have this issue.

Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
This commit is contained in:
Luca Burelli 2024-11-26 10:26:30 +01:00 committed by Benjamin Cabé
parent ec7d272979
commit 820f0ae15b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subsys/llext/llext_link.c
View file

@ -188,7 +188,7 @@ static void llext_link_plt(struct llext_loader *ldr, struct llext *ext, elf_shdr
ret = llext_read(ldr, &sym, sizeof(sym)); ret = llext_read(ldr, &sym, sizeof(sym));
} }
if (ret < 0) { if (ret != 0) {
LOG_ERR("PLT: failed to read symbol table #%u RELA #%u, trying to continue", LOG_ERR("PLT: failed to read symbol table #%u RELA #%u, trying to continue",
j, i); j, i);
continue; continue;