adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

Drivers: Sensor: mc3419: Added LPF CutOff select using dt

Browse source 
For applications that rely on low noise/variance in accelerometer
sample reading. Application can take advantage of integrated LPF
Thus this PR adds LPF configuration capability to the mc3419 driver

Signed-off-by: Anuj Pathak <anuj@croxel.com>
This commit is contained in:
Anuj Pathak 2024-08-07 19:21:45 +05:30 committed by Carles Cufí
parent 4ab8073b87
commit 932e207741
4 changed files with 74 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
drivers/sensor/mc3419/mc3419.c
View file

@ -271,6 +271,12 @@ static int mc3419_init(const struct device *dev)
}
#endif
ret = i2c_reg_update_byte_dt(&cfg->i2c, MC3419_REG_RANGE_SELECT_CTRL, MC3419_LPF_MASK,
cfg->lpf_fc_sel);
if (ret < 0) {
LOG_ERR("Failed to configure LPF (%d)", ret);
return ret;
}
/* Leave the sensor in default power on state, will be
* enabled by configure attr or setting trigger.
*/
@ -297,18 +303,14 @@ static const struct sensor_driver_api mc3419_api = {
#define MC3419_CFG_IRQ(idx)
#endif
#define MC3419_DEFINE(idx) \
static const struct mc3419_config mc3419_config_##idx = { \
.i2c = I2C_DT_SPEC_INST_GET(idx), \
MC3419_CFG_IRQ(idx) \
}; \
static struct mc3419_driver_data mc3419_data_##idx; \
SENSOR_DEVICE_DT_INST_DEFINE(idx, \
mc3419_init, NULL, \
&mc3419_data_##idx, \
&mc3419_config_##idx, \
POST_KERNEL, \
CONFIG_SENSOR_INIT_PRIORITY, \
&mc3419_api);
#define MC3419_DEFINE(idx) \
static const struct mc3419_config mc3419_config_##idx = { \
.i2c = I2C_DT_SPEC_INST_GET(idx), \
.lpf_fc_sel = DT_INST_PROP(idx, lpf_fc_sel), \
MC3419_CFG_IRQ(idx)}; \
static struct mc3419_driver_data mc3419_data_##idx; \
SENSOR_DEVICE_DT_INST_DEFINE(idx, mc3419_init, NULL, &mc3419_data_##idx, \
&mc3419_config_##idx, POST_KERNEL, \
CONFIG_SENSOR_INIT_PRIORITY, &mc3419_api);
DT_INST_FOREACH_STATUS_OKAY(MC3419_DEFINE)

2
drivers/sensor/mc3419/mc3419.h
View file

@ -29,6 +29,7 @@
#define MC3419_REG_ANY_MOTION_THRES 0x43
#define MC3419_RANGE_MASK GENMASK(6, 4)
#define MC3419_LPF_MASK GENMASK(3, 0)
#define MC3419_DATA_READY_MASK BIT(7)
#define MC3419_ANY_MOTION_MASK BIT(2)
#define MC3419_INT_CLEAR 0x00
@ -71,6 +72,7 @@ struct mc3419_config {
struct gpio_dt_spec int_gpio;
bool int_cfg;
#endif
uint8_t lpf_fc_sel;
};
struct mc3419_driver_data {

30
dts/bindings/sensor/memsic,mc3419.yaml
View file

@ -1,7 +1,17 @@
# SPDX-License-Identifier: Apache-2.0
# Copyright (c) 2023 Linumiz
description: MC3419 3-axis accel sensor
description: |
MC3419 3-axis accel sensor
Example:
#include <zephyr/dt-bindings/sensor/mc3419.h>
mc3419: mc3419@0 {
...
lpf-fc-sel = <MC3419_LPF_DISABLE>;
};
compatible: "memsic,mc3419"
@ -21,3 +31,21 @@ properties:
has two interrupt pins.By default the interrupt are routed
to interrupt pin 1, by enabled this property interrupt are
routed to interrupt pin 2.
lpf-fc-sel:
type: int
default: 0
enum: [0, 9, 10, 11, 13]
description: |
Enable and select LPF cutoff frequency for a given IDR (Input Data Rate).
Possible values are listed below. Either use Int value or Macro Name in node definition.
+-----------+-------------------------------------+
| int value | Macro Name |
+-----------+-------------------------------------+
| 0 | MC3419_LPF_DISABLE |
| 9 | MC3419_LPF_EN_WITH_IDR_BY_4p255_FC |
| 10 | MC3419_LPF_EN_WITH_IDR_BY_6_FC |
| 11 | MC3419_LPF_EN_WITH_IDR_BY_12_FC |
| 13 | MC3419_LPF_EN_WITH_IDR_BY_16_FC |
+-----------+-------------------------------------+
Default is LPF disabled (reset value of the register).

28
include/zephyr/dt-bindings/sensor/mc3419.h Normal file
View file

@ -0,0 +1,28 @@
/*
* Copyright (c) 2024 Croxel Inc
*
* SPDX-License-Identifier: Apache-2.0
*/
#ifndef ZEPHYR_INCLUDE_DT_BINDINGS_MEMSIC_MC3419_H_
#define ZEPHYR_INCLUDE_DT_BINDINGS_MEMSIC_MC3419_H_
/**
* @defgroup MC3419 memsic DT Options
* @ingroup sensor_interface
* @{
*/
/**
* @defgroup MC3419_LPF_CONFIGS Lowe pass filter configurations
* @{
*/
#define MC3419_LPF_DISABLE 0
#define MC3419_LPF_EN_WITH_IDR_BY_4p255_FC 9
#define MC3419_LPF_EN_WITH_IDR_BY_6_FC 10
#define MC3419_LPF_EN_WITH_IDR_BY_12_FC 11
#define MC3419_LPF_EN_WITH_IDR_BY_16_FC 13
/** @} */
/** @} */
#endif /*ZEPHYR_INCLUDE_DT_BINDINGS_MEMSIC_MC3419_H_ */