adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

lib: smf: use while (true) in get_child_of for better clarity

Browse source 
Replace the condition-less `for` loop (`;;`) in `get_child_of` with
a `while (true)` loop and remove the redundant `return NULL;`
at the end, which is never reached.

This change aims to enhance readability since `while (true)` is better
suited for this scenario.

Signed-off-by: Pisit Sawangvonganan <pisit@ndrsolution.com>
This commit is contained in:
Pisit Sawangvonganan 2024-06-26 00:35:10 +07:00 committed by Anas Nashif
parent f371ea4b97
commit 94b752d2b4
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/smf/smf.c
View file

@ -36,7 +36,9 @@ static bool share_paren(const struct smf_state *test_state, const struct smf_sta
static const struct smf_state *get_child_of(const struct smf_state *states, static const struct smf_state *get_child_of(const struct smf_state *states,
const struct smf_state *parent) const struct smf_state *parent)
{ {
for (const struct smf_state *tmp = states;; tmp = tmp->parent) { const struct smf_state *tmp = states;
while (true) {
if (tmp->parent == parent) { if (tmp->parent == parent) {
return tmp; return tmp;
} }
@ -44,9 +46,9 @@ static const struct smf_state *get_child_of(const struct smf_state *states,
if (tmp->parent == NULL) { if (tmp->parent == NULL) {
return NULL; return NULL;
} }
}
return NULL; tmp = tmp->parent;
}
} }
static const struct smf_state *get_last_of(const struct smf_state *states) static const struct smf_state *get_last_of(const struct smf_state *states)