adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

modem: ppp: Implement TRANSMIT_IDLE event

Browse source 
Implement TRANSMIT_IDLE event for modem_ppp module. This addition
optimizes the sys workque CPU time when performing a throughput
test from 36% to 5%, while only reducing the throughput by 12%.

Signed-off-by: Bjarki Arge Andreasen <bjarki@arge-andreasen.me>
This commit is contained in:
Bjarki Arge Andreasen 2023-11-27 15:09:01 +01:00 committed by Fabio Baltieri
parent e5fe1c1625
commit a9779eca40
1 changed files with 21 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
subsys/modem/modem_ppp.c
View file

@ -314,8 +314,17 @@ static void modem_ppp_pipe_callback(struct modem_pipe *pipe, enum modem_pipe_eve
{
struct modem_ppp *ppp = (struct modem_ppp *)user_data;
if (event == MODEM_PIPE_EVENT_RECEIVE_READY) {
switch (event) {
case MODEM_PIPE_EVENT_RECEIVE_READY:
k_work_submit(&ppp->process_work);
break;
case MODEM_PIPE_EVENT_TRANSMIT_IDLE:
k_work_submit(&ppp->send_work);
break;
default:
break;
}
}
@ -351,22 +360,20 @@ static void modem_ppp_send_handler(struct k_work *item)
}
}
reserved_size = ring_buf_get_claim(&ppp->transmit_rb, &reserved, UINT32_MAX);
if (reserved_size == 0) {
ring_buf_get_finish(&ppp->transmit_rb, 0);
return;
}
while (!ring_buf_is_empty(&ppp->transmit_rb)) {
reserved_size = ring_buf_get_claim(&ppp->transmit_rb, &reserved, UINT32_MAX);
ret = modem_pipe_transmit(ppp->pipe, reserved, reserved_size);
if (ret < 0) {
ring_buf_get_finish(&ppp->transmit_rb, 0);
break;
}
ret = modem_pipe_transmit(ppp->pipe, reserved, reserved_size);
if (ret < 0) {
ring_buf_get_finish(&ppp->transmit_rb, 0);
} else {
ring_buf_get_finish(&ppp->transmit_rb, (uint32_t)ret);
}
/* Resubmit send work if data remains */
if ((ring_buf_is_empty(&ppp->transmit_rb) == false) || (ppp->tx_pkt != NULL)) {
k_work_submit(&ppp->send_work);
if (ret < reserved_size) {
break;
}
}
}