adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 8

logging: the 'log backend' shell cmd will result in the infinite loop.

Browse source 
The backend_name_get() function always sets 'entry->syntax' to
the name of the last backend, but a calling function iterates
over the idx until 'entry->syntax' is null.
Solution: Added a check that the index is less than the number
of backends and added getting the name of the backend
by the given index.

Signed-off-by: Mikhail Siomin <victorovich.01@mail.ru>
This commit is contained in:
Mikhail Siomin 2023-02-01 16:53:21 +03:00 committed by Anas Nashif
parent 0c0d73721e
commit b608ddc40f
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
subsys/logging/log_cmds.c
View file

@ -399,12 +399,20 @@ SHELL_STATIC_SUBCMD_SET_CREATE(sub_log_backend,
static void backend_name_get(size_t idx, struct shell_static_entry *entry)
{
uint32_t section_count = 0;
entry->handler = NULL;
entry->help = NULL;
entry->subcmd = &sub_log_backend;
entry->syntax = NULL;
STRUCT_SECTION_FOREACH(log_backend, backend) {
STRUCT_SECTION_COUNT(log_backend, &section_count);
if (idx < section_count) {
struct log_backend *backend = NULL;
STRUCT_SECTION_GET(log_backend, idx, &backend);
__ASSERT_NO_MSG(backend != NULL);
entry->syntax = backend->name;
}
}