adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

usb: device: use irq_update in CDC ACM UART implementation

Browse source 
Move the TX/RX ready flag updates into irq_update() where they belong.

Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
This commit is contained in:
Johann Fischer 2024-09-11 15:08:22 +02:00 committed by Fabio Baltieri
parent c5a31aec3c
commit b79ffe3582
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
subsys/usb/device/class/cdc_acm.c
View file

@ -531,10 +531,6 @@ static int cdc_acm_fifo_fill(const struct device *dev,
irq_unlock(lock);
LOG_DBG("Wrote %zu of %d bytes to TX ringbuffer", wrote, len);
if (!ring_buf_space_get(dev_data->tx_ringbuf)) {
dev_data->tx_ready = false;
}
if (wrote) {
k_work_schedule_for_queue(&USB_WORK_Q, &dev_data->tx_work, K_NO_WAIT);
}
@ -563,10 +559,6 @@ static int cdc_acm_fifo_read(const struct device *dev, uint8_t *rx_data,
len = ring_buf_get(dev_data->rx_ringbuf, rx_data, size);
if (ring_buf_is_empty(dev_data->rx_ringbuf)) {
dev_data->rx_ready = false;
}
if (dev_data->rx_paused == true) {
if (ring_buf_space_get(dev_data->rx_ringbuf) >= CDC_ACM_BUFFER_SIZE) {
struct usb_cfg_data *cfg = (void *)dev->config;
@ -698,7 +690,15 @@ static int cdc_acm_irq_is_pending(const struct device *dev)
*/
static int cdc_acm_irq_update(const struct device *dev)
{
ARG_UNUSED(dev);
struct cdc_acm_dev_data_t * const dev_data = dev->data;
if (!ring_buf_space_get(dev_data->tx_ringbuf)) {
dev_data->tx_ready = false;
}
if (ring_buf_is_empty(dev_data->rx_ringbuf)) {
dev_data->rx_ready = false;
}
return 1;
}