adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

driver: i2c: npcx: clear status register by setting a single bit.

Browse source 
Since all fields' type in SMBST is R/W1C and RO, setting a single bit to
clear a specified event is a more suitable solution. Or we might clear
the other pending bits that occurred at the same moment unexpectedly.

Signed-off-by: Mulin Chao <mlchao@nuvoton.com>
This commit is contained in:
Mulin Chao 2021-02-04 22:03:02 -08:00 committed by Anas Nashif
parent 7c8cb78b23
commit c3beabd3c8
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/i2c/i2c_npcx_controller.c
View file

@ -427,7 +427,7 @@ static int i2c_ctrl_recovery(const struct device *dev)
* - Wait for STOP condition completed
* - Then clear BB (BUS BUSY) bit
*/
inst_fifo->SMBST |= BIT(NPCX_SMBST_BER) | BIT(NPCX_SMBST_NEGACK);
inst_fifo->SMBST = BIT(NPCX_SMBST_BER) | BIT(NPCX_SMBST_NEGACK);
ret = i2c_ctrl_wait_stop_completed(dev, I2C_MAX_TIMEOUT);
inst_fifo->SMBCST |= BIT(NPCX_SMBCST_BB);
if (ret != 0) {
@ -686,7 +686,7 @@ static void i2c_ctrl_isr(const struct device *dev)
i2c_ctrl_stop(dev);
/* Clear BER Bit */
inst_fifo->SMBST |= BIT(NPCX_SMBST_BER);
inst_fifo->SMBST = BIT(NPCX_SMBST_BER);
/* Make sure slave doesn't hold bus by reading FIFO again */
tmp = i2c_ctrl_fifo_read(dev);
@ -705,7 +705,7 @@ static void i2c_ctrl_isr(const struct device *dev)
i2c_ctrl_stop(dev);
/* Clear NEGACK Bit */
inst_fifo->SMBST |= BIT(NPCX_SMBST_NEGACK);
inst_fifo->SMBST = BIT(NPCX_SMBST_NEGACK);
/* End transaction */
data->oper_state = NPCX_I2C_WAIT_STOP;