From c6b663e50bb3906d5c84ba7a88ad4cdaa16d034b Mon Sep 17 00:00:00 2001 From: Fabian Kainka Date: Fri, 15 Nov 2024 10:56:25 +0100 Subject: [PATCH] drivers: modem: initialize variables to avoid warn The variables 'first' and 'next' in function 'stats_buffer_list_first()' and 'stats_buffer_list_next()' were potentially used uninitialized. Depending on the compiler and target architecture, this can lead to different behavior, including warnings or errors when using strict warning flags. By initializing these pointers to 'NULL', we ensure consistent and expected behavior across all toolchains and configurations. Signed-off-by: Fabian Kainka --- subsys/modem/modem_stats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subsys/modem/modem_stats.c b/subsys/modem/modem_stats.c index 2ab90d3be6e..e1790cb815a 100644 --- a/subsys/modem/modem_stats.c +++ b/subsys/modem/modem_stats.c @@ -32,7 +32,7 @@ static void stats_buffer_list_append(struct modem_stats_buffer *buffer) static struct modem_stats_buffer *stats_buffer_list_first(void) { - struct modem_stats_buffer *first; + struct modem_stats_buffer *first = NULL; K_SPINLOCK(&stats_buffer_lock) { first = stats_buffer_from_node(sys_slist_peek_head(&stats_buffer_list)); @@ -43,7 +43,7 @@ static struct modem_stats_buffer *stats_buffer_list_first(void) static struct modem_stats_buffer *stats_buffer_list_next(struct modem_stats_buffer *buffer) { - struct modem_stats_buffer *next; + struct modem_stats_buffer *next = NULL; K_SPINLOCK(&stats_buffer_lock) { next = stats_buffer_from_node(sys_slist_peek_next(&buffer->node));