adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

drivers: ethernet: ksz8081: simplify gpio reset logic in reset

Browse source 
Simplifies GPIO reset logic in `phy_mc_ksz8081_reset()` by introducing
a dedicated function, `phy_ksz8081_reset_gpio`. If this function returns
`-ENODEV`, it will fall back to using a command-based reset instead.

Signed-off-by: Pisit Sawangvonganan <pisit@ndrsolution.com>
This commit is contained in:
Pisit Sawangvonganan 2024-11-24 02:24:31 +07:00 committed by Benjamin Cabé
parent 38ef52b1d4
commit c96f236a1b
1 changed files with 32 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
drivers/ethernet/phy/phy_microchip_ksz8081.c
View file

@ -263,30 +263,19 @@ static int phy_mc_ksz8081_static_cfg(const struct device *dev)
return 0;
}
static int phy_mc_ksz8081_reset(const struct device *dev)
{
#if DT_ANY_INST_HAS_PROP_STATUS_OKAY(reset_gpios)
const struct mc_ksz8081_config *config = dev->config;
#endif /* DT_ANY_INST_HAS_PROP_STATUS_OKAY(reset_gpios) */
struct mc_ksz8081_data *data = dev->data;
static int phy_ksz8081_reset_gpio(const struct mc_ksz8081_config *config)
{
int ret;
/* Lock mutex */
ret = k_mutex_lock(&data->mutex, K_FOREVER);
if (ret) {
LOG_ERR("PHY mutex lock error");
return ret;
}
#if DT_ANY_INST_HAS_PROP_STATUS_OKAY(reset_gpios)
if (!config->reset_gpio.port) {
goto skip_reset_gpio;
return -ENODEV;
}
/* Start reset */
ret = gpio_pin_set_dt(&config->reset_gpio, 0);
if (ret) {
goto done;
return ret;
}
/* Wait for at least 500 us as specified by datasheet */
@ -298,9 +287,35 @@ static int phy_mc_ksz8081_reset(const struct device *dev)
/* After deasserting reset, must wait at least 100 us to use programming interface */
k_busy_wait(200);
goto done;
skip_reset_gpio:
return ret;
}
#else
static int phy_ksz8081_reset_gpio(const struct mc_ksz8081_config *config)
{
ARG_UNUSED(config);
return -ENODEV;
}
#endif /* DT_ANY_INST_HAS_PROP_STATUS_OKAY(reset_gpios) */
static int phy_mc_ksz8081_reset(const struct device *dev)
{
const struct mc_ksz8081_config *config = dev->config;
struct mc_ksz8081_data *data = dev->data;
int ret;
/* Lock mutex */
ret = k_mutex_lock(&data->mutex, K_FOREVER);
if (ret) {
LOG_ERR("PHY mutex lock error");
return ret;
}
ret = phy_ksz8081_reset_gpio(config);
if (ret != -ENODEV) { /* On -ENODEV, attempt command-based reset */
goto done;
}
ret = phy_mc_ksz8081_write(dev, MII_BMCR, MII_BMCR_RESET);
if (ret) {
goto done;