adafruit-mirror/zephyr
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 9

drivers: ethernet: w5500: improve type consistency

Browse source 
Improve type safety and consistency by adjusting variable and
parameter types to avoid signed/unsigned comparisons and implicit casts.

Moreover, explicit casts were applied when converting from
`size_t` to `uint16_t`.

Signed-off-by: Pisit Sawangvonganan <pisit@ndrsolution.com>
This commit is contained in:
Pisit Sawangvonganan 2024-11-16 00:52:19 +07:00 committed by Anas Nashif
parent 82e2709ed8
commit d81a8d452e
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
drivers/ethernet/eth_w5500.c
View file

@ -35,7 +35,7 @@ LOG_MODULE_REGISTER(eth_w5500, CONFIG_ETHERNET_LOG_LEVEL);
((W5500_SPI_BLOCK_SELECT(addr) << 3) | BIT(2))
static int w5500_spi_read(const struct device *dev, uint32_t addr,
uint8_t *data, uint32_t len)
uint8_t *data, size_t len)
{
const struct w5500_config *cfg = dev->config;
int ret;
@ -75,7 +75,7 @@ static int w5500_spi_read(const struct device *dev, uint32_t addr,
}
static int w5500_spi_write(const struct device *dev, uint32_t addr,
uint8_t *data, uint32_t len)
uint8_t *data, size_t len)
{
const struct w5500_config *cfg = dev->config;
int ret;
@ -105,13 +105,13 @@ static int w5500_spi_write(const struct device *dev, uint32_t addr,
}
static int w5500_readbuf(const struct device *dev, uint16_t offset, uint8_t *buf,
int len)
size_t len)
{
uint32_t addr;
int remain = 0;
size_t remain = 0;
int ret;
const uint32_t mem_start = W5500_Sn_RX_MEM_START;
const uint16_t mem_size = W5500_RX_MEM_SIZE;
const uint32_t mem_size = W5500_RX_MEM_SIZE;
offset %= mem_size;
addr = mem_start + offset;
@ -130,11 +130,11 @@ static int w5500_readbuf(const struct device *dev, uint16_t offset, uint8_t *buf
}
static int w5500_writebuf(const struct device *dev, uint16_t offset, uint8_t *buf,
int len)
size_t len)
{
uint32_t addr;
int ret = 0;
int remain = 0;
size_t remain = 0;
int ret;
const uint32_t mem_start = W5500_Sn_TX_MEM_START;
const uint32_t mem_size = W5500_TX_MEM_SIZE;
@ -160,7 +160,7 @@ static int w5500_command(const struct device *dev, uint8_t cmd)
k_timepoint_t end = sys_timepoint_calc(K_MSEC(100));
w5500_spi_write(dev, W5500_S0_CR, &cmd, 1);
while (1) {
while (true) {
w5500_spi_read(dev, W5500_S0_CR, &reg, 1);
if (!reg) {
break;
@ -176,7 +176,7 @@ static int w5500_command(const struct device *dev, uint8_t cmd)
static int w5500_tx(const struct device *dev, struct net_pkt *pkt)
{
struct w5500_runtime *ctx = dev->data;
uint16_t len = net_pkt_get_len(pkt);
uint16_t len = (uint16_t)net_pkt_get_len(pkt);
uint16_t offset;
uint8_t off[2];
int ret;
@ -260,9 +260,9 @@ static void w5500_rx(const struct device *dev)
w5500_readbuf(dev, reader, data_ptr, frame_len);
net_buf_add(pkt_buf, frame_len);
reader += frame_len;
reader += (uint16_t)frame_len;
read_len -= frame_len;
read_len -= (uint16_t)frame_len;
pkt_buf = pkt_buf->frags;
} while (read_len > 0);