From ed12a0cc35aaf30c1915526f23cbec3af86ff410 Mon Sep 17 00:00:00 2001
From: Hess Nathan <nhess@baumer.com>
Date: Tue, 7 May 2024 08:53:44 +0200
Subject: [PATCH] coding guidelines: comply with MISRA Rule 11.8

modified parameter types to receive a const pointer when a
non-const pointer is not needed

Signed-off-by: Hess Nathan <nhess@baumer.com>
---
 arch/arc/core/mpu/arc_core_mpu.c              | 2 +-
 arch/arc/core/mpu/arc_mpu_common_internal.h   | 2 +-
 arch/arc/core/mpu/arc_mpu_v4_internal.h       | 2 +-
 arch/arm/core/mpu/arm_core_mpu.c              | 2 +-
 arch/arm/core/mpu/arm_core_mpu_dev.h          | 2 +-
 arch/arm/core/mpu/arm_mpu.c                   | 2 +-
 arch/arm/core/mpu/arm_mpu_v7_internal.h       | 2 +-
 arch/arm/core/mpu/arm_mpu_v8_internal.h       | 4 ++--
 arch/arm/core/mpu/nxp_mpu.c                   | 2 +-
 arch/arm64/core/userspace.S                   | 2 +-
 arch/riscv/core/pmp.c                         | 2 +-
 arch/x86/core/x86_mmu.c                       | 8 ++++----
 arch/xtensa/core/mpu.c                        | 2 +-
 arch/xtensa/core/ptables.c                    | 2 +-
 include/zephyr/arch/arc/v2/mpu/arc_core_mpu.h | 2 +-
 include/zephyr/arch/arch_interface.h          | 2 +-
 16 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/arch/arc/core/mpu/arc_core_mpu.c b/arch/arc/core/mpu/arc_core_mpu.c
index 0ffcdc875b4..2d739d7a233 100644
--- a/arch/arc/core/mpu/arc_core_mpu.c
+++ b/arch/arc/core/mpu/arc_core_mpu.c
@@ -34,7 +34,7 @@ int arch_mem_domain_max_partitions_get(void)
 /*
  * Validate the given buffer is user accessible or not
  */
-int arch_buffer_validate(void *addr, size_t size, int write)
+int arch_buffer_validate(const void *addr, size_t size, int write)
 {
 	return arc_core_mpu_buffer_validate(addr, size, write);
 }
diff --git a/arch/arc/core/mpu/arc_mpu_common_internal.h b/arch/arc/core/mpu/arc_mpu_common_internal.h
index 736a9742af9..a9ff5518b2f 100644
--- a/arch/arc/core/mpu/arc_mpu_common_internal.h
+++ b/arch/arc/core/mpu/arc_mpu_common_internal.h
@@ -207,7 +207,7 @@ int arc_core_mpu_get_max_domain_partition_regions(void)
 /**
  * @brief validate the given buffer is user accessible or not
  */
-int arc_core_mpu_buffer_validate(void *addr, size_t size, int write)
+int arc_core_mpu_buffer_validate(const void *addr, size_t size, int write)
 {
 	/*
 	 * For ARC MPU, smaller region number takes priority.
diff --git a/arch/arc/core/mpu/arc_mpu_v4_internal.h b/arch/arc/core/mpu/arc_mpu_v4_internal.h
index e7e91fed93f..3bf6fca6c43 100644
--- a/arch/arc/core/mpu/arc_mpu_v4_internal.h
+++ b/arch/arc/core/mpu/arc_mpu_v4_internal.h
@@ -779,7 +779,7 @@ int arc_core_mpu_get_max_domain_partition_regions(void)
 /**
  * @brief validate the given buffer is user accessible or not
  */
-int arc_core_mpu_buffer_validate(void *addr, size_t size, int write)
+int arc_core_mpu_buffer_validate(const void *addr, size_t size, int write)
 {
 	int r_index;
 	int key = arch_irq_lock();
diff --git a/arch/arm/core/mpu/arm_core_mpu.c b/arch/arm/core/mpu/arm_core_mpu.c
index 2fb0f141125..dde98c0b07f 100644
--- a/arch/arm/core/mpu/arm_core_mpu.c
+++ b/arch/arm/core/mpu/arm_core_mpu.c
@@ -338,7 +338,7 @@ int arch_mem_domain_max_partitions_get(void)
 	return ARM_CORE_MPU_MAX_DOMAIN_PARTITIONS_GET(available_regions);
 }
 
-int arch_buffer_validate(void *addr, size_t size, int write)
+int arch_buffer_validate(const void *addr, size_t size, int write)
 {
 	return arm_core_mpu_buffer_validate(addr, size, write);
 }
diff --git a/arch/arm/core/mpu/arm_core_mpu_dev.h b/arch/arm/core/mpu/arm_core_mpu_dev.h
index fd56131d7dc..254d6d9dda3 100644
--- a/arch/arm/core/mpu/arm_core_mpu_dev.h
+++ b/arch/arm/core/mpu/arm_core_mpu_dev.h
@@ -261,7 +261,7 @@ int arm_core_mpu_get_max_available_dyn_regions(void);
  *       spans multiple enabled MPU regions (even if these regions all
  *       permit user access).
  */
-int arm_core_mpu_buffer_validate(void *addr, size_t size, int write);
+int arm_core_mpu_buffer_validate(const void *addr, size_t size, int write);
 
 #endif /* CONFIG_ARM_MPU */
 
diff --git a/arch/arm/core/mpu/arm_mpu.c b/arch/arm/core/mpu/arm_mpu.c
index cd4c8ccd7a0..52ad585b79c 100644
--- a/arch/arm/core/mpu/arm_mpu.c
+++ b/arch/arm/core/mpu/arm_mpu.c
@@ -341,7 +341,7 @@ int arm_core_mpu_get_max_available_dyn_regions(void)
  *
  * Presumes the background mapping is NOT user accessible.
  */
-int arm_core_mpu_buffer_validate(void *addr, size_t size, int write)
+int arm_core_mpu_buffer_validate(const void *addr, size_t size, int write)
 {
 	return mpu_buffer_validate(addr, size, write);
 }
diff --git a/arch/arm/core/mpu/arm_mpu_v7_internal.h b/arch/arm/core/mpu/arm_mpu_v7_internal.h
index 1fe3417901e..9641ab25000 100644
--- a/arch/arm/core/mpu/arm_mpu_v7_internal.h
+++ b/arch/arm/core/mpu/arm_mpu_v7_internal.h
@@ -169,7 +169,7 @@ static inline int is_user_accessible_region(uint32_t r_index, int write)
  * This internal function validates whether a given memory buffer
  * is user accessible or not.
  */
-static inline int mpu_buffer_validate(void *addr, size_t size, int write)
+static inline int mpu_buffer_validate(const void *addr, size_t size, int write)
 {
 	int32_t r_index;
 	int rc = -EPERM;
diff --git a/arch/arm/core/mpu/arm_mpu_v8_internal.h b/arch/arm/core/mpu/arm_mpu_v8_internal.h
index 751786d5a4c..66a00a452a7 100644
--- a/arch/arm/core/mpu/arm_mpu_v8_internal.h
+++ b/arch/arm/core/mpu/arm_mpu_v8_internal.h
@@ -408,7 +408,7 @@ static inline int is_user_accessible_region(uint32_t rnr, int write)
  * This internal function validates whether a given memory buffer
  * is user accessible or not.
  */
-static inline int mpu_buffer_validate(void *addr, size_t size, int write)
+static inline int mpu_buffer_validate(const void *addr, size_t size, int write)
 {
 	int32_t rnr;
 	int rc = -EPERM;
@@ -455,7 +455,7 @@ static inline int mpu_buffer_validate(void *addr, size_t size, int write)
  * in case the fast address range check fails.
  *
  */
-static inline int mpu_buffer_validate(void *addr, size_t size, int write)
+static inline int mpu_buffer_validate(const void *addr, size_t size, int write)
 {
 	uint32_t _addr = (uint32_t)addr;
 	uint32_t _size = (uint32_t)size;
diff --git a/arch/arm/core/mpu/nxp_mpu.c b/arch/arm/core/mpu/nxp_mpu.c
index 39d7cde6f8f..b0fe24c6bf6 100644
--- a/arch/arm/core/mpu/nxp_mpu.c
+++ b/arch/arm/core/mpu/nxp_mpu.c
@@ -602,7 +602,7 @@ static inline int is_user_accessible_region(uint32_t r_index, int write)
 /**
  * @brief validate the given buffer is user accessible or not
  */
-int arm_core_mpu_buffer_validate(void *addr, size_t size, int write)
+int arm_core_mpu_buffer_validate(const void *addr, size_t size, int write)
 {
 	uint8_t r_index;
 
diff --git a/arch/arm64/core/userspace.S b/arch/arm64/core/userspace.S
index 618aa6b2c20..968d2a436bc 100644
--- a/arch/arm64/core/userspace.S
+++ b/arch/arm64/core/userspace.S
@@ -51,7 +51,7 @@ strlen_done:
 	ret
 
 /*
- * int arch_buffer_validate(void *addr, size_t size, int write)
+ * int arch_buffer_validate(const void *addr, size_t size, int write)
  */
 
 GTEXT(arch_buffer_validate)
diff --git a/arch/riscv/core/pmp.c b/arch/riscv/core/pmp.c
index 3807b3b103b..50b5dd58f5d 100644
--- a/arch/riscv/core/pmp.c
+++ b/arch/riscv/core/pmp.c
@@ -667,7 +667,7 @@ int arch_mem_domain_thread_remove(struct k_thread *thread)
 	((inner_start) >= (outer_start) && (inner_size) <= (outer_size) && \
 	 ((inner_start) - (outer_start)) <= ((outer_size) - (inner_size)))
 
-int arch_buffer_validate(void *addr, size_t size, int write)
+int arch_buffer_validate(const void *addr, size_t size, int write)
 {
 	uintptr_t start = (uintptr_t)addr;
 	int ret = -1;
diff --git a/arch/x86/core/x86_mmu.c b/arch/x86/core/x86_mmu.c
index 5540cebce70..8591e0a8ba4 100644
--- a/arch/x86/core/x86_mmu.c
+++ b/arch/x86/core/x86_mmu.c
@@ -848,7 +848,7 @@ static inline pentry_t pte_finalize_value(pentry_t val, bool user_table,
 __pinned_func
 static inline pentry_t atomic_pte_get(const pentry_t *target)
 {
-	return (pentry_t)atomic_ptr_get((atomic_ptr_t *)target);
+	return (pentry_t)atomic_ptr_get((const atomic_ptr_t *)target);
 }
 
 __pinned_func
@@ -1301,7 +1301,7 @@ void arch_mem_unmap(void *addr, size_t size)
 {
 	int ret;
 
-	ret = range_map_unlocked((void *)addr, 0, size, 0, 0,
+	ret = range_map_unlocked(addr, 0, size, 0, 0,
 				 OPTION_FLUSH | OPTION_CLEAR);
 	__ASSERT_NO_MSG(ret == 0);
 	ARG_UNUSED(ret);
@@ -1387,7 +1387,7 @@ void z_x86_set_stack_guard(k_thread_stack_t *stack)
 __pinned_func
 static bool page_validate(pentry_t *ptables, uint8_t *addr, bool write)
 {
-	pentry_t *table = (pentry_t *)ptables;
+	pentry_t *table = ptables;
 
 	for (int level = 0; level < NUM_LEVELS; level++) {
 		pentry_t entry = get_entry(table, addr, level);
@@ -1432,7 +1432,7 @@ static inline void bcb_fence(void)
 }
 
 __pinned_func
-int arch_buffer_validate(void *addr, size_t size, int write)
+int arch_buffer_validate(const void *addr, size_t size, int write)
 {
 	pentry_t *ptables = z_x86_thread_page_tables_get(_current);
 	uint8_t *virt;
diff --git a/arch/xtensa/core/mpu.c b/arch/xtensa/core/mpu.c
index 29e33629771..76036b32c70 100644
--- a/arch/xtensa/core/mpu.c
+++ b/arch/xtensa/core/mpu.c
@@ -969,7 +969,7 @@ out:
 	return ret;
 }
 
-int arch_buffer_validate(void *addr, size_t size, int write)
+int arch_buffer_validate(const void *addr, size_t size, int write)
 {
 	uintptr_t aligned_addr;
 	size_t aligned_size, addr_offset;
diff --git a/arch/xtensa/core/ptables.c b/arch/xtensa/core/ptables.c
index dc33d6fd5f0..d4da8366cf2 100644
--- a/arch/xtensa/core/ptables.c
+++ b/arch/xtensa/core/ptables.c
@@ -1044,7 +1044,7 @@ static bool page_validate(uint32_t *ptables, uint32_t page, uint8_t ring, bool w
 	return true;
 }
 
-int arch_buffer_validate(void *addr, size_t size, int write)
+int arch_buffer_validate(const void *addr, size_t size, int write)
 {
 	int ret = 0;
 	uint8_t *virt;
diff --git a/include/zephyr/arch/arc/v2/mpu/arc_core_mpu.h b/include/zephyr/arch/arc/v2/mpu/arc_core_mpu.h
index ad36a22eb77..8e3e02a67ce 100644
--- a/include/zephyr/arch/arc/v2/mpu/arc_core_mpu.h
+++ b/include/zephyr/arch/arc/v2/mpu/arc_core_mpu.h
@@ -88,7 +88,7 @@ void arc_core_mpu_remove_mem_domain(struct k_mem_domain *mem_domain);
 void arc_core_mpu_remove_mem_partition(struct k_mem_domain *domain,
 			uint32_t partition_id);
 int arc_core_mpu_get_max_domain_partition_regions(void);
-int arc_core_mpu_buffer_validate(void *addr, size_t size, int write);
+int arc_core_mpu_buffer_validate(const void *addr, size_t size, int write);
 
 #endif
 
diff --git a/include/zephyr/arch/arch_interface.h b/include/zephyr/arch/arch_interface.h
index d7ff2f2cad2..04aef815755 100644
--- a/include/zephyr/arch/arch_interface.h
+++ b/include/zephyr/arch/arch_interface.h
@@ -783,7 +783,7 @@ int arch_mem_domain_partition_add(struct k_mem_domain *domain,
  *
  * @return nonzero if the permissions don't match.
  */
-int arch_buffer_validate(void *addr, size_t size, int write);
+int arch_buffer_validate(const void *addr, size_t size, int write);
 
 /**
  * Get the optimal virtual region alignment to optimize the MMU table layout