This commit refactors kernel and arch headers to establish a boundary
between private and public interface headers.
The refactoring strategy used in this commit is detailed in the issue
This commit introduces the following major changes:
1. Establish a clear boundary between private and public headers by
removing "kernel/include" and "arch/*/include" from the global
include paths. Ideally, only kernel/ and arch/*/ source files should
reference the headers in these directories. If these headers must be
used by a component, these include paths shall be manually added to
the CMakeLists.txt file of the component. This is intended to
discourage applications from including private kernel and arch
headers either knowingly and unknowingly.
- kernel/include/ (PRIVATE)
This directory contains the private headers that provide private
kernel definitions which should not be visible outside the kernel
and arch source code. All public kernel definitions must be added
to an appropriate header located under include/.
- arch/*/include/ (PRIVATE)
This directory contains the private headers that provide private
architecture-specific definitions which should not be visible
outside the arch and kernel source code. All public architecture-
specific definitions must be added to an appropriate header located
under include/arch/*/.
- include/ AND include/sys/ (PUBLIC)
This directory contains the public headers that provide public
kernel definitions which can be referenced by both kernel and
application code.
- include/arch/*/ (PUBLIC)
This directory contains the public headers that provide public
architecture-specific definitions which can be referenced by both
kernel and application code.
2. Split arch_interface.h into "kernel-to-arch interface" and "public
arch interface" divisions.
- kernel/include/kernel_arch_interface.h
* provides private "kernel-to-arch interface" definition.
* includes arch/*/include/kernel_arch_func.h to ensure that the
interface function implementations are always available.
* includes sys/arch_interface.h so that public arch interface
definitions are automatically included when including this file.
- arch/*/include/kernel_arch_func.h
* provides architecture-specific "kernel-to-arch interface"
implementation.
* only the functions that will be used in kernel and arch source
files are defined here.
- include/sys/arch_interface.h
* provides "public arch interface" definition.
* includes include/arch/arch_inlines.h to ensure that the
architecture-specific public inline interface function
implementations are always available.
- include/arch/arch_inlines.h
* includes architecture-specific arch_inlines.h in
include/arch/*/arch_inline.h.
- include/arch/*/arch_inline.h
* provides architecture-specific "public arch interface" inline
function implementation.
* supersedes include/sys/arch_inline.h.
3. Refactor kernel and the existing architecture implementations.
- Remove circular dependency of kernel and arch headers. The
following general rules should be observed:
* Never include any private headers from public headers
* Never include kernel_internal.h in kernel_arch_data.h
* Always include kernel_arch_data.h from kernel_arch_func.h
* Never include kernel.h from kernel_struct.h either directly or
indirectly. Only add the kernel structures that must be referenced
from public arch headers in this file.
- Relocate syscall_handler.h to include/ so it can be used in the
public code. This is necessary because many user-mode public codes
reference the functions defined in this header.
- Relocate kernel_arch_thread.h to include/arch/*/thread.h. This is
necessary to provide architecture-specific thread definition for
'struct k_thread' in kernel.h.
- Remove any private header dependencies from public headers using
the following methods:
* If dependency is not required, simply omit
* If dependency is required,
- Relocate a portion of the required dependencies from the
private header to an appropriate public header OR
- Relocate the required private header to make it public.
This commit supersedes #20047, addresses #19666, and fixes #3056.
Signed-off-by: Stephanos Ioannidis <root@stephanos.io>
164 lines
3.9 KiB
C
164 lines
3.9 KiB
C
/*
|
|
* Copyright (c) 2016 Wind River Systems, Inc.
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
#include <kernel.h>
|
|
#include <toolchain.h>
|
|
#include <linker/sections.h>
|
|
#include <drivers/timer/system_timer.h>
|
|
#include <wait_q.h>
|
|
#include <power/power.h>
|
|
#include <stdbool.h>
|
|
|
|
#ifdef CONFIG_TICKLESS_IDLE_THRESH
|
|
#define IDLE_THRESH CONFIG_TICKLESS_IDLE_THRESH
|
|
#else
|
|
#define IDLE_THRESH 1
|
|
#endif
|
|
|
|
/* Fallback idle spin loop for SMP platforms without a working IPI */
|
|
#if (defined(CONFIG_SMP) && !defined(CONFIG_SCHED_IPI_SUPPORTED))
|
|
#define SMP_FALLBACK 1
|
|
#else
|
|
#define SMP_FALLBACK 0
|
|
#endif
|
|
|
|
#ifdef CONFIG_SYS_POWER_MANAGEMENT
|
|
/*
|
|
* Used to allow _sys_suspend() implementation to control notification
|
|
* of the event that caused exit from kernel idling after pm operations.
|
|
*/
|
|
unsigned char sys_pm_idle_exit_notify;
|
|
|
|
|
|
/* LCOV_EXCL_START
|
|
* These are almost certainly overidden and in any event do nothing
|
|
*/
|
|
#if defined(CONFIG_SYS_POWER_SLEEP_STATES)
|
|
void __attribute__((weak)) _sys_resume(void)
|
|
{
|
|
}
|
|
#endif
|
|
|
|
#if defined(CONFIG_SYS_POWER_DEEP_SLEEP_STATES)
|
|
void __attribute__((weak)) _sys_resume_from_deep_sleep(void)
|
|
{
|
|
}
|
|
#endif
|
|
/* LCOV_EXCL_STOP */
|
|
|
|
#endif /* CONFIG_SYS_POWER_MANAGEMENT */
|
|
|
|
/**
|
|
*
|
|
* @brief Indicate that kernel is idling in tickless mode
|
|
*
|
|
* Sets the kernel data structure idle field to either a positive value or
|
|
* K_FOREVER.
|
|
*
|
|
* @param ticks the number of ticks to idle
|
|
*
|
|
* @return N/A
|
|
*/
|
|
#if !SMP_FALLBACK
|
|
static void set_kernel_idle_time_in_ticks(s32_t ticks)
|
|
{
|
|
#ifdef CONFIG_SYS_POWER_MANAGEMENT
|
|
_kernel.idle = ticks;
|
|
#endif
|
|
}
|
|
|
|
static void sys_power_save_idle(void)
|
|
{
|
|
s32_t ticks = z_get_next_timeout_expiry();
|
|
|
|
/* The documented behavior of CONFIG_TICKLESS_IDLE_THRESH is
|
|
* that the system should not enter a tickless idle for
|
|
* periods less than that. This seems... silly, given that it
|
|
* saves no power and does not improve latency. But it's an
|
|
* API we need to honor...
|
|
*/
|
|
#ifdef CONFIG_SYS_CLOCK_EXISTS
|
|
z_set_timeout_expiry((ticks < IDLE_THRESH) ? 1 : ticks, true);
|
|
#endif
|
|
|
|
set_kernel_idle_time_in_ticks(ticks);
|
|
#if (defined(CONFIG_SYS_POWER_SLEEP_STATES) || \
|
|
defined(CONFIG_SYS_POWER_DEEP_SLEEP_STATES))
|
|
|
|
sys_pm_idle_exit_notify = 1U;
|
|
|
|
/*
|
|
* Call the suspend hook function of the soc interface to allow
|
|
* entry into a low power state. The function returns
|
|
* SYS_POWER_STATE_ACTIVE if low power state was not entered, in which
|
|
* case, kernel does normal idle processing.
|
|
*
|
|
* This function is entered with interrupts disabled. If a low power
|
|
* state was entered, then the hook function should enable inerrupts
|
|
* before exiting. This is because the kernel does not do its own idle
|
|
* processing in those cases i.e. skips k_cpu_idle(). The kernel's
|
|
* idle processing re-enables interrupts which is essential for
|
|
* the kernel's scheduling logic.
|
|
*/
|
|
if (_sys_suspend(ticks) == SYS_POWER_STATE_ACTIVE) {
|
|
sys_pm_idle_exit_notify = 0U;
|
|
k_cpu_idle();
|
|
}
|
|
#else
|
|
k_cpu_idle();
|
|
#endif
|
|
}
|
|
#endif
|
|
|
|
void z_sys_power_save_idle_exit(s32_t ticks)
|
|
{
|
|
#if defined(CONFIG_SYS_POWER_SLEEP_STATES)
|
|
/* Some CPU low power states require notification at the ISR
|
|
* to allow any operations that needs to be done before kernel
|
|
* switches task or processes nested interrupts. This can be
|
|
* disabled by calling _sys_pm_idle_exit_notification_disable().
|
|
* Alternatively it can be simply ignored if not required.
|
|
*/
|
|
if (sys_pm_idle_exit_notify) {
|
|
_sys_resume();
|
|
}
|
|
#endif
|
|
|
|
z_clock_idle_exit();
|
|
}
|
|
|
|
|
|
#if K_IDLE_PRIO < 0
|
|
#define IDLE_YIELD_IF_COOP() k_yield()
|
|
#else
|
|
#define IDLE_YIELD_IF_COOP() do { } while (false)
|
|
#endif
|
|
|
|
void idle(void *unused1, void *unused2, void *unused3)
|
|
{
|
|
ARG_UNUSED(unused1);
|
|
ARG_UNUSED(unused2);
|
|
ARG_UNUSED(unused3);
|
|
|
|
#ifdef CONFIG_BOOT_TIME_MEASUREMENT
|
|
/* record timestamp when idling begins */
|
|
|
|
extern u32_t z_timestamp_idle;
|
|
|
|
z_timestamp_idle = k_cycle_get_32();
|
|
#endif
|
|
|
|
while (true) {
|
|
#if SMP_FALLBACK
|
|
k_busy_wait(100);
|
|
k_yield();
|
|
#else
|
|
(void)z_arch_irq_lock();
|
|
sys_power_save_idle();
|
|
IDLE_YIELD_IF_COOP();
|
|
#endif
|
|
}
|
|
}
|