Apply suggestions from code review

Co-authored-by: Malcolm Smith <smith@chaquo.com>
This commit is contained in:
Russell Keith-Magee 2024-03-01 06:25:12 +08:00 committed by GitHub
parent f1dd736949
commit 6182b7c7fc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -9,7 +9,7 @@ February may be the shortest month, but that doesn't mean we've got any less pro
What we've done What we've done
---------------- ----------------
* `PEP 738 <https://peps.python.org/pep-0738/>`__, has been formally submitted to the CPython Steering Council for approval. * `PEP 738 <https://peps.python.org/pep-0738/>`__, adding official Android support to CPython, has been formally submitted to the Python Steering Council for approval.
* We've started landing patches in CPython to add formal support for `iOS <https://github.com/python/cpython/issues/114099>`__ and `Android <https://github.com/python/cpython/issues/71052>`__. There are more patches in review, and more to come, but so far we've landed patches that: * We've started landing patches in CPython to add formal support for `iOS <https://github.com/python/cpython/issues/114099>`__ and `Android <https://github.com/python/cpython/issues/71052>`__. There are more patches in review, and more to come, but so far we've landed patches that:
@ -18,11 +18,11 @@ What we've done
- `Refactor the CPython build system to allow for some of the oddities of iOS as a platform <https://github.com/python/cpython/pull/115120>`__ - `Refactor the CPython build system to allow for some of the oddities of iOS as a platform <https://github.com/python/cpython/pull/115120>`__
- `Add build targets for compiling iOS-compatible frameworks <https://github.com/python/cpython/pull/115390>`__ - `Add build targets for compiling iOS-compatible frameworks <https://github.com/python/cpython/pull/115390>`__
- `Correct the linking of extension modules on Android <https://github.com/python/cpython/pull/115780>`__ - `Correct the linking of extension modules on Android <https://github.com/python/cpython/pull/115780>`__
- `Fix a concurrent.futures test case on platforms that don't support multiprocessing <https://github.com/python/cpython/pull/115917>`__ - `Enable the concurrent.futures tests on platforms that don't support multiprocessing <https://github.com/python/cpython/pull/115917>`__
* We added macOS ARM64 machines to our CI capabilities for `Toga <https://github.com/beeware/toga/pull/2404>`__ and `Briefcase <https://github.com/beeware/briefcase/pull/1652>`__. We've officially supported ARM64 on macOS for some time, but we've been unable to test this support as part of our CI and release procedure - we've had to do ad-hoc testing on the machines we're using to develop on a day to day basis. As a result of improvements to Github's CI infrastructure, we're now able to perform automated testing. As part of these changes, we've also added testing for Python 3.13 (which will be released around October of this year). * We added macOS ARM64 machines to our CI capabilities for `Toga <https://github.com/beeware/toga/pull/2404>`__ and `Briefcase <https://github.com/beeware/briefcase/pull/1652>`__. We've officially supported ARM64 on macOS for some time, but we've been unable to test this support as part of our CI and release procedure - we've had to do ad-hoc testing on the machines we're using to develop on a day to day basis. As a result of improvements to Github's CI infrastructure, we're now able to perform automated testing. As part of these changes, we've also added testing for Python 3.13 (which will be released around October of this year).
* We `added an API for detecting the displays attached to a computer, and specify the location of windows relative to those displays <https://github.com/beeware/toga/pull/1930>`__. * We `added an API for detecting the displays attached to a computer, and specifying the location of windows relative to those displays <https://github.com/beeware/toga/pull/1930>`__.
* We `added a pluggable API for image formats <https://github.com/beeware/toga/pull/2387>`__. With this API, any third party library that has an internal format for images can implement support so that Toga can convert to and from images in that format. * We `added a pluggable API for image formats <https://github.com/beeware/toga/pull/2387>`__. With this API, any third party library that has an internal format for images can implement support so that Toga can convert to and from images in that format.
@ -34,7 +34,7 @@ What we've done
* We've added the ability to run `Linux apps that have been built for different platforms <https://github.com/beeware/briefcase/pull/1603>`__. Using Docker, it's now possible to run a Fedora system app on an Ubuntu machine, or any other combination of supported platforms. * We've added the ability to run `Linux apps that have been built for different platforms <https://github.com/beeware/briefcase/pull/1603>`__. Using Docker, it's now possible to run a Fedora system app on an Ubuntu machine, or any other combination of supported platforms.
* We've added the ability to `pass extra arguments to the Docker when building images <https://github.com/beeware/briefcase/pull/1661>`__. * We've added the ability to `pass extra arguments to Docker when building images <https://github.com/beeware/briefcase/pull/1661>`__.
* We've `improved the console output for non-interactive consoles <https://github.com/beeware/briefcase/pull/1649>`__ on some long-running commands. * We've `improved the console output for non-interactive consoles <https://github.com/beeware/briefcase/pull/1649>`__ on some long-running commands.