jepler/circuitpython
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

objint_longlong: Fix signed comparison error.

Browse source 
Under `afl-cc` (acting as a wrapper for clang), the following
diagnostic occurs (wrapped for clarity):
```
../../py/objint_longlong.c:232:32: error:
    comparison of integers of different signs:
    'long long' and 'unsigned long' [-Werror,-Wsign-compare]
```

Add a cast to silence it. The value is known statically to fit inside
`long long`.

Signed-off-by: Jeff Epler <jepler@gmail.com>
This commit is contained in:
Jeff Epler 2025-08-02 11:51:05 -05:00
parent 9e6c14b0ff
commit ab1986ec0b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
py/objint_longlong.c
View file

@ -229,7 +229,7 @@ mp_obj_t mp_obj_int_binary_op(mp_binary_op_t op, mp_obj_t lhs_in, mp_obj_t rhs_i
// negative shift not allowed
mp_raise_ValueError(MP_ERROR_TEXT("negative shift count"));
}
overflow = rhs_val >= (sizeof(long long) * MP_BITS_PER_BYTE)
overflow = rhs_val >= (long long)(sizeof(long long) * MP_BITS_PER_BYTE)
|| lhs_val > (LLONG_MAX >> rhs_val)
|| lhs_val < (LLONG_MIN >> rhs_val);
result = (unsigned long long)lhs_val << rhs_val;