Address review comments
Some checks failed
CMake / Linux (push) Has been cancelled
MicroPython / pico_plus2_rp2350_psram (PIMORONI_PICO_PLUS2 PSRAM) (push) Has been cancelled

This commit is contained in:
Jeff Epler 2025-02-19 19:15:00 -06:00
parent 3e8ba7ca42
commit a513f8b60e
2 changed files with 2 additions and 2 deletions

View file

@ -42,7 +42,7 @@ Other pinouts can be used by passing a `pinout` parameter to the `init`
function.
This pinout consists of 4 numbers giving the *positive* pin in each differential pair, in the order CK, D0, D1, D2, D3, using GPIO numbering.
The default pinout is written `{13, 15, 17, 19}`.
Only pin numbers from 12 to 20 are valid, as other pins are not connected to the HSTX peripheral.
Only pin numbers from 12 to 19 are valid, as other pins are not connected to the HSTX peripheral.
Using invalid pin numbers is an undignosed error.
TODO

View file

@ -910,7 +910,7 @@ bool DVHSTX::init(uint16_t width, uint16_t height, Mode mode_, Pinout pinout)
// The two halves of each pair get identical data, but one pin is inverted.
hstx_ctrl_hw->bit[bit ] = lane_data_sel_bits;
hstx_ctrl_hw->bit[bit ^ 1] = lane_data_sel_bits | HSTX_CTRL_BIT0_INV_BITS;
}
}
for (int i = 12; i <= 19; ++i) {
gpio_set_function(i, GPIO_FUNC_HSTX);