jepler/fruitjam-doom
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

strife: explicitly declare a bit-shifted 1 literal as unsigned

Browse source 
This fixes a future "Shifting signed 32-bit value by 31 bits is
undefined behaviour" cppcheck error.
This commit is contained in:
Fabian Greffrath 2019-01-28 09:26:54 +01:00
parent 6478a56726
commit 173300a37b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/strife/doomdef.h
View file

@ -269,7 +269,7 @@ enum
QF_QUEST29 = (1 << tk_quest29), // Destroyed the Mines Transmitter QF_QUEST29 = (1 << tk_quest29), // Destroyed the Mines Transmitter
QF_QUEST30 = (1 << tk_quest30), QF_QUEST30 = (1 << tk_quest30),
QF_QUEST31 = (1 << tk_quest31), QF_QUEST31 = (1 << tk_quest31),
QF_QUEST32 = (1 << tk_quest32), // Unused; BUG: Broken Coupling accidentally sets it. QF_QUEST32 = (1U << tk_quest32), // Unused; BUG: Broken Coupling accidentally sets it.
QF_ALLQUESTS = (QF_QUEST31 + (QF_QUEST31 - 1)) // does not include bit 32! QF_ALLQUESTS = (QF_QUEST31 + (QF_QUEST31 - 1)) // does not include bit 32!
}; };