jepler/fruitjam-doom
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

txt: free already loaded libraries on LoadLibraryW() failure

Browse source 
This fixes a future "Resource leak" cppcheck error.
This commit is contained in:
Fabian Greffrath 2019-01-28 09:34:12 +01:00
parent 173300a37b
commit 59f737ad1b
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
textscreen/txt_fileselect.c
View file

@ -175,14 +175,21 @@ static BOOL (*MySHGetPathFromIDList)(LPITEMIDLIST, LPTSTR) = NULL;
static int LoadDLLs(void) static int LoadDLLs(void)
{ {
HMODULE comdlg32 = LoadLibraryW(L"comdlg32.dll"); HMODULE comdlg32, shell32
HMODULE shell32 = LoadLibraryW(L"shell32.dll");
if (comdlg32 == NULL || shell32 == NULL) comdlg32 = LoadLibraryW(L"comdlg32.dll");
if (comdlg32 == NULL)
{ {
return 0; return 0;
} }
shell32 = LoadLibraryW(L"shell32.dll");
if (shell32 == NULL)
{
FreeLibrary(comdlg32);
return 0;
}
MyGetOpenFileName = MyGetOpenFileName =
(void *) GetProcAddress(comdlg32, "GetOpenFileNameA"); (void *) GetProcAddress(comdlg32, "GetOpenFileNameA");
MySHBrowseForFolder = MySHBrowseForFolder =