jepler/fruitjam-doom
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use a heuristic approach to detect infinite state cycles

Browse source 
Count the number of times the loop in P_SetMobjState() executes
and exit with an error once an arbitrary very large limit is reached.
This commit is contained in:
Fabian Greffrath 2016-05-24 21:02:05 +02:00
parent ed8cbb08e8
commit 7607140288
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/doom/p_mobj.c
View file

@ -44,12 +44,19 @@ void P_SpawnMapThing (mapthing_t* mthing);
//
int test;
// Use a heuristic approach to detect infinite state cycles: Count the number
// of times the loop in P_SetMobjState() executes and exit with an error once
// an arbitrary very large limit is reached.
#define MOBJ_CYCLE_LIMIT 1000000
boolean
P_SetMobjState
( mobj_t* mobj,
statenum_t state )
{
state_t* st;
int cycle_counter = 0;
do
{
@ -72,6 +79,11 @@ P_SetMobjState
st->action.acp1(mobj);
state = st->nextstate;
if (cycle_counter++ > MOBJ_CYCLE_LIMIT)
{
I_Error("P_SetMobjState: Infinite state cycle detected!");
}
} while (!mobj->tics);
return true;