improve import by URL feature. closes #171

* Drop dependency on temp module
 * Download files to music-folder/.tmp/ before moving them.
 * Don't watch folders that start with a '.'
 * Don't allow generated paths to start with a '.'

Fixes import file race condition.

Prevents needless file copy operation when importing in situations where
the music directory is in a different device than /tmp.

lib/player.js

@@ -1,6 +1,7 @@
 var groove = require('groove');
 var EventEmitter = require('events').EventEmitter;
 var util = require('util');
+var mkdirp = require('mkdirp');
 var fs = require('fs');
 var uuid = require('uuid');
 var path = require('path');
@@ -16,7 +17,6 @@ var safePath = require('./safe_path');
 var PassThrough = require('stream').PassThrough;
 var url = require('url');
 var superagent = require('superagent');
-var temp = require('temp').track();
 
 module.exports = Player;
 
@@ -382,6 +382,7 @@ Player.prototype.refreshFilesIndex = function(args, cb) {
     var dirEntry = self.getOrCreateDir(dirName, stat);
     if (fullDirPath === dirWithSlash) return; // ignore root search path
     var baseName = path.basename(dirName);
+    if (isFileIgnored(baseName)) return;
     var parentDirName = path.dirname(dirName);
     if (parentDirName === '.') parentDirName = '';
     var parentDirEntry = self.getOrCreateDir(parentDirName);
@@ -629,21 +630,43 @@ Player.prototype.importUrl = function(urlString, cb) {
   var self = this;
   cb = cb || logIfError;
 
-  var parsedUrl = url.parse(urlString);
+  var tmpDir = path.join(self.musicDirectory, '.tmp');
-  var remoteFilename = path.basename(parsedUrl.pathname);
+  var destPath = path.join(tmpDir, uuid() + path.extname(urlString));
-  var req = superagent.get(urlString);
-  var ws = temp.createWriteStream({suffix: path.extname(urlString)});
-  req.pipe(ws);
-  ws.on('close', function(){
-    self.importFile(ws.path, remoteFilename, cleanAndCb);
-  });
-  ws.on('error', cleanAndCb);
-  req.on('error', cleanAndCb);
 
-  function cleanAndCb(err, dbFile) {
+  mkdirp(tmpDir, function(err) {
-    temp.cleanup();
+    if (err) return cb(err);
-    cb(err, dbFile);
+
-  }
+    var parsedUrl = url.parse(urlString);
+    var remoteFilename = path.basename(parsedUrl.pathname);
+    var ws = fs.createWriteStream(destPath);
+    var calledCallback = false;
+    var req = superagent.get(urlString);
+    req.pipe(ws);
+    ws.on('close', function(){
+      if (calledCallback) return;
+      self.importFile(ws.path, remoteFilename, function(err, dbFile) {
+        if (err) {
+          cleanAndCb(err);
+        } else {
+          calledCallback = true;
+          cb(null, dbFile);
+        }
+      });
+    });
+    ws.on('error', cleanAndCb);
+    req.on('error', cleanAndCb);
+
+    function cleanAndCb(err) {
+      fs.unlink(destPath, function(err) {
+        if (err) {
+          console.warn("Unable to clean up temp file:", err.stack);
+        }
+      });
+      if (calledCallback) return;
+      calledCallback = true;
+      cb(err);
+    }
+  });
 
   function logIfError(err) {
     if (err) {

lib/safe_path.js

@@ -6,5 +6,6 @@ function safePath(string) {
   string = string.replace(/[<>:"\/\\|?*%]/g, "_");
   string = string.substring(0, MAX_LEN);
   string = string.replace(/\.$/, "_");
+  string = string.replace(/^\./, "_");
   return string;
 }

package.json

@@ -34,7 +34,6 @@
     "uuid": "~1.4.1",
     "music-library-index": "^1.1.0",
     "keese": "~1.0.0",
-    "temp": "~0.7.0",
     "ws": "~0.4.31",
     "jsondiffpatch": "~0.1.4",
     "connect-static": "^1.1.0",