errordesc.cc: Correctly append a single character to a std::string

The idiom
    char c = ...;
    _userMsg.append( &c );
is not correct C++, because it treats the address of 'c' as a NUL-
terminated C string.  However, this is not guaranteed.

When building and testing on Debian Stretch with AddressSanitizer:
    ASAN_OPTIONS="detect_leaks=false" CXX="clang++" CC=clang CXXFLAGS="-fsanitize=address" LDFLAGS="-fsanitize=address" cmake .. -DSC_ENABLE_TESTING=ON  -DSC_BUILD_SCHEMAS="ifc2x3;ap214e3;ap209"
    ASAN_OPTIONS="detect_leaks=false" make
    ASAN_OPTIONS="detect_leaks=false" ctest . --output-on-failure
an error like the following is encountered:

==15739==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffeb2ca7621 at pc 0x00000043c943 bp 0x7ffeb2ca75d0 sp 0x7ffeb2ca6d80
READ of size 33 at 0x7ffeb2ca7621 thread T0
    #0 0x43c942 in __interceptor_strlen.part.45 (/home/jepler/src/stepcode/build/bin/lazy_sdai_ap214e3+0x43c942)
    #1 0x7fb9056e6143 in std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::append(char const*) (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0x11f143)
    #2 0x7fb905b677c3 in ErrorDescriptor::AppendToDetailMsg(char) /home/jepler/src/stepcode/src/clutils/errordesc.cc:150:5

Address 0x7ffeb2ca7621 is located in stack of thread T0 at offset 33 in frame
    #0 0x7fb905b676af in ErrorDescriptor::AppendToDetailMsg(char) /home/jepler/src/stepcode/src/clutils/errordesc.cc:149

  This frame has 1 object(s):
    [32, 33) '' <== Memory access at offset 33 overflows this variable

A similar problem with AppendToUserMsg is found by inspection.

After this change, all 200 tests pass under the AddressSanitizer
configuration

.appveyor.yml

@@ -2,6 +2,10 @@ version: '{build}'
 
 # for Appveyor CI (windows)
 
+branches:
+  only:
+    - master
+
 os: Windows Server 2012 R2
 
 clone_folder: c:\projects\STEPcode
@@ -42,127 +46,19 @@ build_script:
     cd build
     cmake -version
     grep --version
-    cmake .. -DSC_ENABLE_TESTING=ON -G"$env:GENERATOR" -DSC_BUILD_SCHEMAS="ifc2x3"
+    cmake .. -DSC_ENABLE_TESTING=ON -G"$env:GENERATOR" -DSC_BUILD_SCHEMAS="ifc2x3;ap214e3;ap209"
-    cmake --build . --config Debug --target tst_inverse_attr3
+    echo "filtering build output with grep"
+    cmake --build . --config Debug | grep -ve "CMake does not need to re-run because" -e "ZERO_CHECK.ZERO_CHECK" -e "^  Creating directory"
 
 #msbuld seems to provide no benefits, and I can't filter its output...
 #msbuild SC.sln /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll" /p:Configuration=Debug /p:Platform=x64
 # /toolsversion:14.0 /p:PlatformToolset=v140
 
 test_script:
-  - cmd: echo inverse_attr3 test 100x
+  - cmd: echo Running CTest...
   - cmd: cd c:\projects\STEPcode\build
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
+  - cmd: echo excluding test_inverse_attr3, which hangs
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
+  - cmd: ctest -j1 . -C Debug -E test_inverse_attr3 --output-on-failure
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 10
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 20
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 30
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 40
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 50
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 60
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 70
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 80
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 90
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: bin\tst_inverse_attr3 ..\test\p21\test_inverse_attr.p21
-  - cmd: echo 100
-  - cmd: echo done
 
 # - cmd: grep -niB20 "Test Failed" Testing/Temporary/LastTest.log
 

.travis.yml

@@ -3,6 +3,17 @@ language: cpp
 compiler:
   - clang
 script: mkdir build && cd build && cmake .. -DSC_ENABLE_TESTING=ON && make -j3 && ctest -j2 --output-on-failure
+branches:
+  only:
+    - master
+notifications:
+  irc: "chat.freenode.net#stepcode"
+  email: scl-dev@groups.google.com
+  on_success: change
+  on_failure: always
 os:
   - linux
   - osx
+matrix:
+  allow_failures:
+    - os: osx

cmake/sc_version_string.cmake

@@ -47,24 +47,37 @@ string(REPLACE "\n" "" GIT_COMMIT_ID ${GIT_COMMIT_ID})
 #once cmake_minimum_required is >= 2.8.11, we can use TIMESTAMP:
 #string(TIMESTAMP date_time_string)
 
+if(UNIX)
+  execute_process(COMMAND date "+%d %b %Y %H:%M" OUTPUT_VARIABLE date_time_string OUTPUT_STRIP_TRAILING_WHITESPACE)
+elseif(WIN32)
+  execute_process(COMMAND cmd /c date /t OUTPUT_VARIABLE currentDate OUTPUT_STRIP_TRAILING_WHITESPACE)
+  execute_process(COMMAND cmd /c time /t OUTPUT_VARIABLE currentTime OUTPUT_STRIP_TRAILING_WHITESPACE)
+  set (date_time_string "${currentDate} ${currentTime}")
+else()
+  set(date_time_string "\" __DATE__ \" \" __TIME__ \" ")
+  if(NOT SC_IS_SUBBUILD)
+    message(STATUS "Unknown platform - using date from preprocessor")
+  endif(NOT SC_IS_SUBBUILD)
+endif()
+
 set(header_string "/* sc_version_string.h - written by cmake. Changes will be lost! */\n"
   "#ifndef SC_VERSION_STRING\n"
   "#define SC_VERSION_STRING\n\n"
   "/*\n** The git commit id looks like \"test-1-g5e1fb47\", where test is the\n"
   "** name of the last tagged git revision, 1 is the number of commits since that tag,\n"
   "** 'g' is unknown, and 5e1fb47 is the first 7 chars of the git sha1 commit id.\n"
-  "*/\n\n"
+  "** timestamp is created from date/time commands on known platforms, and uses\n"
+  "** preprocessor macros elsewhere.\n*/\n\n"
   "static char sc_version[512] = {\n"
-  "    \"git commit id: ${GIT_COMMIT_ID}\"\n"
+  "    \"git commit id: ${GIT_COMMIT_ID}, build timestamp ${date_time_string}\"\n"
   "}\;\n\n"
   "#endif\n"
  )
 
 #don't update the file unless somethig changed
-string(RANDOM tmpsuffix)
+file(WRITE ${SC_VERSION_HEADER}.tmp ${header_string})
-file(WRITE ${SC_VERSION_HEADER}.${tmpsuffix} ${header_string})
+execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different ${SC_VERSION_HEADER}.tmp ${SC_VERSION_HEADER})
-execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different ${SC_VERSION_HEADER}.${tmpsuffix} ${SC_VERSION_HEADER})
+execute_process(COMMAND ${CMAKE_COMMAND} -E remove ${SC_VERSION_HEADER}.tmp)
-execute_process(COMMAND ${CMAKE_COMMAND} -E remove ${SC_VERSION_HEADER}.${tmpsuffix})
 
 if(NOT SC_IS_SUBBUILD)
   message("-- sc_version_string.h is up-to-date.")

src/cllazyfile/lazyFileReader.cc

@@ -50,7 +50,7 @@ instancesLoaded_t * lazyFileReader::getHeaderInstances() {
 }
 
 lazyFileReader::lazyFileReader( std::string fname, lazyInstMgr * i, fileID fid ): _fileName( fname ), _parent( i ), _fileID( fid ) {
-    _file.open( _fileName.c_str(), std::ios::binary );
+    _file.open( _fileName.c_str() );
     _file.imbue( std::locale::classic() );
     _file.unsetf( std::ios_base::skipws );
     assert( _file.is_open() && _file.good() );

src/cllazyfile/sectionReader.cc

@@ -47,7 +47,7 @@ std::streampos sectionReader::findNormalString( const std::string & str, bool se
         }
         if( c == '\'' ) {
             //push past string
-            _file.seekg( _file.tellg() - std::streampos(1) );
+            _file.unget();
             GetLiteralStr( _file, _lazyFile->getInstMgr()->getErrorDesc() );
         }
         if( ( c == '/' ) && ( _file.peek() == '*' ) ) {
@@ -129,7 +129,7 @@ std::streampos sectionReader::seekInstanceEnd( instanceRefs ** refs ) {
                 }
                 break;
             case '\'':
-                _file.seekg( _file.tellg() - std::streampos(1) );
+                _file.unget();
                 GetLiteralStr( _file, _lazyFile->getInstMgr()->getErrorDesc() );
                 break;
             case '=':
@@ -155,7 +155,7 @@ std::streampos sectionReader::seekInstanceEnd( instanceRefs ** refs ) {
                     if( _file.get() == ';' ) {
                         return _file.tellg();
                     } else {
-                        _file.seekg( _file.tellg() - std::streampos(1) );
+                        _file.unget();
                     }
                 }
             default:
@@ -186,7 +186,7 @@ instanceID sectionReader::readInstanceNumber() {
     if( ( c == '/' ) && ( _file.peek() == '*' ) ) {
         findNormalString( "*/" );
     } else {
-        _file.seekg( _file.tellg() - std::streampos(1) );
+        _file.unget();
     }
     skipWS();
     c = _file.get();
@@ -210,7 +210,7 @@ instanceID sectionReader::readInstanceNumber() {
             digits++;
 
         } else {
-            _file.seekg( _file.tellg() - std::streampos(1) );
+            _file.unget();
             break;
         }
 
@@ -221,7 +221,7 @@ instanceID sectionReader::readInstanceNumber() {
             _error->UserMsg( "A very large instance ID encountered" );
             _error->DetailMsg( errorMsg.str() );
 
-            delete [] buffer;
+            delete buffer;
             return 0;    
         }
 
@@ -309,7 +309,7 @@ SDAI_Application_instance * sectionReader::getRealInstance( const Registry * reg
         assert( inst->getEDesc() );
         _file.seekg( begin );
         findNormalString( "(" );
-        _file.seekg( _file.tellg() - std::streampos(1) );
+        _file.unget();
         sev = inst->STEPread( instance, 0, _lazyFile->getInstMgr()->getAdapter(), _file, sName, true, false );
         //TODO do something with 'sev'
         inst->InitIAttrs();

src/express/error.c

@@ -125,9 +125,13 @@ static jmp_buf ERROR_safe_env;
 
 static int ERROR_vprintf( const char *format, va_list ap ) {
     int result = snprintf( ERROR_string, ERROR_string_end - ERROR_string, format, ap );
-    if(result < 0) ERROR_string = ERROR_string_end;
+    if(result < 0) {
-    else if(result > (ERROR_string_end - ERROR_string)) ERROR_string = ERROR_string_end;
+        ERROR_string = ERROR_string_end;
-    else ERROR_string = ERROR_string + result;
+    } else if(result > (ERROR_string_end - ERROR_string)) {
+        ERROR_string = ERROR_string_end;
+    } else {
+        ERROR_string = ERROR_string + result;
+    }
     return result;
 }
 
@@ -141,7 +145,9 @@ static int ERROR_printf( const char *format, ... ) {
 }
 
 static void ERROR_nexterror() {
-    if( ERROR_string == ERROR_string_end ) return;
+    if( ERROR_string == ERROR_string_end ) {
+        return;
+    }
     ERROR_string++;
 }