jepler/tinyuf2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix board_flash_write() on stm32f4

Browse source 
Bug symptom: if an image for stm32f4 begins with >=256 bytes that already match flash content then the image must be written twice.
Reason: if the first flash_write() into an erase block matches flash content, the erase is delayed and will destroy that matching content later.
This commit is contained in:
Oliver Joos 2021-11-17 01:18:25 +01:00
parent 22cc393dfb
commit 07e088e968
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
ports/stm32f4/board_flash.c
View file

@ -136,6 +136,7 @@ static void flash_write(uint32_t dst, const uint8_t *src, int len)
{
flash_erase(dst);
TU_LOG2("Write flash at address %08lX\r\n", dst);
for ( int i = 0; i < len; i += 4 )
{
uint32_t data = *((uint32_t*) ((void*) (src + i)));
@ -184,13 +185,10 @@ void board_flash_flush(void)
// TODO not working quite yet
void board_flash_write (uint32_t addr, void const *data, uint32_t len)
{
// skip matching contents
if ( memcmp((void*) addr, data, len) )
{
HAL_FLASH_Unlock();
flash_write(addr, data, len);
HAL_FLASH_Lock();
}
// TODO skip matching contents
HAL_FLASH_Unlock();
flash_write(addr, data, len);
HAL_FLASH_Lock();
}
void board_flash_erase_app(void)